From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C4469A04B7; Wed, 14 Oct 2020 14:41:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8B3A61DB21; Wed, 14 Oct 2020 14:41:33 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id C01041DB21 for ; Wed, 14 Oct 2020 14:41:30 +0200 (CEST) IronPort-SDR: OWSinD0rvv5aUGB+dAHQEkwfSA1x1aLvGlJtenCOcH1ZVMyVBO2sGMdc2b7WVBwSOkms4eKmc2 Tt+VyO1E/5dg== X-IronPort-AV: E=McAfee;i="6000,8403,9773"; a="165307208" X-IronPort-AV: E=Sophos;i="5.77,374,1596524400"; d="scan'208";a="165307208" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2020 05:41:28 -0700 IronPort-SDR: Y7XXQi3KfEzAL8fuZOFudFYMZSPTT2FQHsa3MYMFWaObXecF9a4UJhcdUfnM+3SSjwDSPI+bno qbYixyowE6FQ== X-IronPort-AV: E=Sophos;i="5.77,374,1596524400"; d="scan'208";a="345643988" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.2.249]) ([10.252.2.249]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2020 05:41:27 -0700 To: Leyi Rong , qi.z.zhang@intel.com Cc: dev@dpdk.org References: <20201014082857.81080-1-leyi.rong@intel.com> From: Ferruh Yigit Message-ID: <11c66b66-582a-d834-1085-ae4218949eae@intel.com> Date: Wed, 14 Oct 2020 13:41:24 +0100 MIME-Version: 1.0 In-Reply-To: <20201014082857.81080-1-leyi.rong@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] net/iavf: fix unchecked return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/14/2020 9:28 AM, Leyi Rong wrote: > Fixes coverity unchecked return value issue. > > Coverity issue: 363045 > Fixes: 02d212ca3125 ("net/iavf: rename remaining avf strings") > Hi Leyi, Can you please put some justification to the commit log, why return value can be ignored instead of handling it? Technically this patch doesn't put you in a better place, still you are not checking the return value, indeed it is worse since it is silenced and even coverity can't warn you anymore. > Signed-off-by: Leyi Rong > --- > drivers/net/iavf/iavf_rxtx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c > index 7e6e425ac..ca0f5d072 100644 > --- a/drivers/net/iavf/iavf_rxtx.c > +++ b/drivers/net/iavf/iavf_rxtx.c > @@ -2077,7 +2077,7 @@ iavf_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) > > /* Check if the descriptor ring needs to be cleaned. */ > if (txq->nb_free < txq->free_thresh) > - iavf_xmit_cleanup(txq); > + (void)iavf_xmit_cleanup(txq); > > for (nb_tx = 0; nb_tx < nb_pkts; nb_tx++) { > td_cmd = 0; >