From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id A0E771B798 for ; Fri, 13 Oct 2017 23:05:11 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP; 13 Oct 2017 14:05:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,372,1503385200"; d="scan'208";a="909761625" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.224.248]) ([10.241.224.248]) by FMSMGA003.fm.intel.com with ESMTP; 13 Oct 2017 14:05:09 -0700 To: Thomas Monjalon , shijith.thotton@caviumnetworks.com, qiming.yang@intel.com, jingjing.wu@intel.com Cc: luca.boccassi@att.com, gregory@weka.io, helin.zhang@intel.com, xuekun.hu@intel.com, harish.patil@cavium.com, dev@dpdk.org References: <20171013145104.17596-1-thomas@monjalon.net> From: Ferruh Yigit Message-ID: <11d7e3d2-a30c-cdc1-7609-c70aafde5aed@intel.com> Date: Fri, 13 Oct 2017 22:05:09 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171013145104.17596-1-thomas@monjalon.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] igb_uio: revert open and release operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Oct 2017 21:05:12 -0000 On 10/13/2017 3:51 PM, Thomas Monjalon wrote: > Some VF drivers cannot work with igb_uio because of the > reset done in these functions. > > First bug report: > http://dpdk.org/ml/archives/dev/2017-September/075236.html > > A partial reset was tried: > http://dpdk.org/patch/28940 > > Second bug report after a partial revert trial: > http://dpdk.org/ml/archives/dev/2017-September/076998.html > > The patch author agreed to revert his patch: > http://dpdk.org/ml/archives/dev/2017-October/077158.html > > There are also some patches available to fix issues with i40e: > http://dpdk.org/patch/30021 > http://dpdk.org/patch/30022 > > This patch takes the simple option of reverting the initial patch > and gives more time to properly improve igb_uio and PMDs. > > Fixes: b58eedfc7dd5 ("igb_uio: issue FLR during open and release of device file") > > Reported-by: Qiming Yang > Reported-by: Jingjing Wu > Signed-off-by: Thomas Monjalon Hi Thomas, I put already some comment into other fix patch [1]. Mainly taking into account of current time for release, this patch make sense, but I suggest giving a chance to the fix mentioned above. Because the original patch is for safer igb_uio, and fixing a few times reported issue. Since this is rc1, we have time for testing, and many parties will be doing tests. Lets get the fix for rc1, and if we find any issue revert the patch? Thanks, ferruh [1] http://dpdk.org/ml/archives/dev/2017-October/079159.html