From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B00AE4247A; Tue, 24 Jan 2023 19:04:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A3CB940223; Tue, 24 Jan 2023 19:04:33 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2052.outbound.protection.outlook.com [40.107.94.52]) by mails.dpdk.org (Postfix) with ESMTP id 713BC40150 for ; Tue, 24 Jan 2023 19:04:32 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n+aJhf9/0cOx3UuRaLo3r8bXUXI0JuK4OzYBCEMI42b2/jYiQozpAgzLu2+rzfovChQrwMxbby5R5rcuYbbTEpeXBrucUOWhqmG2htjWzwy8nB/6C9L3dtZrlVYUYiV5ZB/XUFBzHzTyPRVDbL5Iw/24+ukhEVwifZUBItCr/TqL6z3TXMMhZ4hLdFf9B3r5ZyeY2TyNRfedTTwF5eekFT3adsG+WdHTMgHMr4jrvJM7TXqeLOLUVBE8dS6LGAK9XOaNMD4HHzUkxO7VCpcV9vrT6k0GGjY6f6eKCeL5QNbJGzC8v6c+EpfRrUoBrwjTY9eAc2kYrr0U3QwrD9OCZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yu8Mv/7icN1QBkWGhvrbfmc0Sg+TIueHSysB4nWnBLY=; b=WXjA+9WEnYiPEmCCkTH0WKJT2Pw+7yavnKQrKr23gNP2B9HVrAEpDJDZ1+S+RmpgWAC1N9nnTwSZdQHV76J5JZZ+lxoQNCLi2AVz8xfHRgkNcEgtqrP8o9I4SL9hRfUoEDynUezGjlAM42JKuNU7BWzH2LiBbBQGNzEVeaDHq6immBZsTb/2nNScHWZuAj7ENu+7VBC4G88c5grmqMEneUOgWdBHaJ5dHQHi/mBERAmlW1s3Gouu7GXz6FVdkzND+dAlUeZxfM2Bl8cg8mYpZq0uAROGzQQBlnV1pHs1CXF56slYzOQmbJLrQdfA8R+RfexFVwzDXkYNbqWOBF7V6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yu8Mv/7icN1QBkWGhvrbfmc0Sg+TIueHSysB4nWnBLY=; b=N5l6VoAcIF1BOJY6TvohvoiGVmIktZDRssrJtn4hci48uahvbpbBzEeCe0rnH2wHCmn/fFSkPCd/m516VTGaVmZZhK9FROexe0TXzXDDyMWozx7bErovS4EJwGEn5vUQGFKcumXUDQ5qZYCmxi/A+7jtkhz2Q6ji6OjI58WQFPA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DS7PR12MB6024.namprd12.prod.outlook.com (2603:10b6:8:84::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.33; Tue, 24 Jan 2023 18:04:30 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a%7]) with mapi id 15.20.6002.033; Tue, 24 Jan 2023 18:04:30 +0000 Message-ID: <11fa3448-7348-09d6-b7e0-321aef1d8953@amd.com> Date: Tue, 24 Jan 2023 18:04:22 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation Content-Language: en-US To: Hanumanth Pothula , Aman Singh , Yuying Zhang Cc: dev@dpdk.org, andrew.rybchenko@oktetlabs.ru, viacheslavo@nvidia.com, jerinj@marvell.com, ndabilpuram@marvell.com References: <20221220200250.2413443-1-hpothula@marvell.com> <20221221020713.2803232-1-hpothula@marvell.com> <20221221020713.2803232-2-hpothula@marvell.com> From: Ferruh Yigit In-Reply-To: <20221221020713.2803232-2-hpothula@marvell.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR1P264CA0104.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:2cf::15) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DS7PR12MB6024:EE_ X-MS-Office365-Filtering-Correlation-Id: ffb64ffd-b3f2-4012-7f1a-08dafe3570aa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: H2nxUM2midpBW4sbLsGEEXClB+86h8dCei2PMczOCVFyjgPwwCGLgKGjyNSAIoir3sAGYn5SKc1Zj7JVneMmnjldMpwK+VcHoenWQ3lRIKGAKzCtuBZCAtYGBW6vNIJ+26RCyOF/Y15zfoVZiD5BAJYB9gkM7QNILlALDocClH3ZLFj85GPiz5pjn4SIyt6xmQ/oioeHgRsya3x1MxguY+JIXhWE1sbRI2UqV3yDEn5m1OXaRUB/EJpsS6GYojc0WOFoHhMIzM388x5DmTe81o6aif+KiPAnTw2Jjs4m9rTvDzNhl7vaJD550PJr12MTPTuTN0XAIrMkEjCehAXT+/1M+QOgRRUpdNEbPKYG+KN3Zi9+QEqLIo17kkbF7pKQURTJ23HP71ch+N8TBETTYG1BHUG1J9OgunZuCgPcatC5gceszleofTKq42QtlUaqmjcnllEuZMpFONuC0h/xYIltad0gTPKkzmVkoKu0Oq3n1IJhUAZmd1HzgM0jdugGlTIbaMkJonshlVVXC2wKWx7ma1cmr8UzSQmhYIoKN6UMNtR62YjPVUHgZMGv+Ix809yInxI8hknunZcj/YOGKwSsyJHfSBkl5KnewLVdndwtxH0FjICkbAQ2WD/P2BXTA9LmRGUtFOvmuNEI09aktNZtmDS7sD9r8/1qcB69U3G9hZk2VzLjBnrNx+XhqSUD6t8FYQuGIEqVKnMsdPLnrVylK7f93w5rrDGxDtnE8Ec= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(376002)(39860400002)(396003)(366004)(346002)(136003)(451199015)(86362001)(31696002)(36756003)(478600001)(316002)(110136005)(2906002)(6666004)(6486002)(4744005)(44832011)(5660300002)(8676002)(66556008)(66946007)(4326008)(66476007)(41300700001)(8936002)(38100700002)(6506007)(2616005)(186003)(26005)(53546011)(6512007)(83380400001)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?azc1bkswVkZYdjJMSlhTN0hTcmczeWJpS3RnaDN0blJOSVNiYXJ4QU80eFRI?= =?utf-8?B?di9lbDF1dE8reFZiV05SbENjcTZlR2ZsYW9ReG9aek1VRXZLdG8yeXcyeGVp?= =?utf-8?B?WjBuUFVGdWJPQVIxTDdDazBYd0tQYWh6b1BJcXVkUldTcWxRcGJRZ0tHOW1U?= =?utf-8?B?c1pveXE3MmpQTzlPQTRESHRHQlpkRHMxZHFiNGkyR0V1TDFEb2lYcVhxTUdW?= =?utf-8?B?MHB2Vk5UdFMzQ3FZN3M0TE51QnNrajRvb2oxelFLQVR5endKb3RvSWFpdFQ1?= =?utf-8?B?bnU5Y1RjSlI5bWR5WEdvMm1oajFJQXg0WDBWL1dKenlVSUZJL0hyVkhvVElr?= =?utf-8?B?RGVNNUlON0kyWjc1b0ZWRFNyTjhDb3NNVldKQ3VOc0hPd2syWXZWbG1kampW?= =?utf-8?B?Rk5xTVdxQ3U0bjhjb1lWYmpsa01CNStOeDNsRUVxYzVOcU9lbDc5Wk9GU3ZL?= =?utf-8?B?WXJNbDJ5YlZCWWpMWnhSK3BoenJRQ1hqem5Gc05SVlFOR0lvbllqMzBGd0RU?= =?utf-8?B?eTQ2S0NPb2ViMUdZS0FRRU52TkNXODJ3UlUwM0xwU2FQRzJ5N3BMVmg1NmpP?= =?utf-8?B?M3BqaCt5Rk9QRU13cGE0VEloMzRyems0YWJwbHBOMzB0WUhVM3UrZFA5TTRW?= =?utf-8?B?YWo0dTNzTVdKTnY5M2c3Ump6V3FyNU9kTUMzR2p6NFk1WmFmbzhCOVE3ZWRu?= =?utf-8?B?MUlHRGgxaXE1M0RhSTR2d3pjYUl2bndOV0FkWnZ6ZEd3WUdoMWtqVTVMU0E4?= =?utf-8?B?QzRTaXEyeWxYTmVFNllnOTd4Qks4a2lRRjdoNHdxM1NaZWRObytidFJoaC9h?= =?utf-8?B?T0p6cXJLTUlURTZqSEtBZjUrUUFVVGRIOEF3b2dkOXA2em9vc2Y3VzRnTE9K?= =?utf-8?B?RHB6QVBvT1dFSTBMUFFkLzlKbUhEUCtPVEVBWlVkemJSOGFaODV6UCsrYkpj?= =?utf-8?B?UWd3TjBrdUJDdGxXTW44ZlZyc1JGeTJvQkpobjVjUFc5SnBZVWhzR1lWRkk5?= =?utf-8?B?Q1VSa1VwOWNqUjdkYkVpWVJkTC9EajljZHhCUitqYVFjNXBQY2w5VmtEYlZS?= =?utf-8?B?dXV6clM4U2xrMHJnbm1FV0U5eTh4T09KeXRxZE9UUmsvaHV1R1AvUFRuU0Fo?= =?utf-8?B?RmszYlFsTk5BRGoralprRFBZZEZFQmNkN0Z6Ym9jaVpUWitUN2JvdEFyZUlp?= =?utf-8?B?dVY3d0xXcFVXTmQwUFUyblhzd3ZQbGRsclRGZTEvQVdwVDhXYTM5MVZhR2tK?= =?utf-8?B?THZxeitwMlFBekJuaGdZS3VtYWwwSEtSNisvNnFsb05jQ1NIVWZNSCtUcnpK?= =?utf-8?B?d0xaSkg5ZEVYUHV4TUdKWmEvTHFjTUNyOTBJdUhQKytpU0EyTmVLQlR2YXdE?= =?utf-8?B?QlYwU0t2QlRLQ1V3VWFFbFVldU0vUHNUejhxMHFrK1FrcVRtaWtWWlpyVHJM?= =?utf-8?B?UG9OdGtPVDV6VVdzWTFIK0pSS1hoK2RkdWtlMXFqcGtCTkFxejc1YmZaS1J6?= =?utf-8?B?STlLMzNPNzVKcDh5Snd2TkpldFAyQk9xWG9XOUlKUHppbXljUWtDNkUxQ0F6?= =?utf-8?B?VUVmUmhsQ21kMUtZTERRUU9IUnozeWIrNEJKZTN4bnVPMHl2MEtBM003eml1?= =?utf-8?B?YW1oM2VyUWI0RzhCQlNLZWtRWE1jV2d5VE5XaTR3eERqRk9qblpjQlZKaUFH?= =?utf-8?B?dzJIV1dQbDhVbnNIMVBsOUdoTEdneDJpaFJveXdQTE1aamtqWXJOZVVEK3NS?= =?utf-8?B?ZlJiQ25RR3pONTZyT3BlcWxnUm9ySXNNenlya29PcEt0UGtJdGdhZlZiR0RN?= =?utf-8?B?LzJXZGtvNHFYdjZ1RGpRVkxSMmwwQnVGN3JNUFc5UW9vL0twOEJZbTVHSDY4?= =?utf-8?B?S0pqeE1IVlNSSW9VM0F3TnVPTFZPdlJWRE1NTFZXcFhlMVE5YWRjM0lQdEx4?= =?utf-8?B?SGJ6Z2F4S0JyOUxCUEFtWGo1T0czWnlEdFMzQUc2aWZTcnhPbXFmZ2JwbnJs?= =?utf-8?B?RENNVnlxZnhCWDhnUjV2ZjBrV21FN09JYUVIWGJTRFNUNjk4Vis4dW43aHdX?= =?utf-8?B?VnQzVkthNi94OHFhMEZ4VVhnbm8rR3lMSlJ0T3RORUlOMVJ6Z3dDTCtPNWxH?= =?utf-8?Q?B8jW+w9lVyHuWUCQlegTSslZ0?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: ffb64ffd-b3f2-4012-7f1a-08dafe3570aa X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2023 18:04:30.5477 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rw1dtgErtQ7hA39sa/EVql3/szf0RR9IivOx+5AI2ZJIgFJHpvnb75G0KYW/SIPL X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6024 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12/21/2022 2:07 AM, Hanumanth Pothula wrote: > Presently, Rx metadata is sent to PMD by default, leading > to a performance drop as processing for the same in Rx path > takes extra cycles. > > Hence, add new testpmd command, > 'enable port nic_to_pmd_rx_metadata' > > This command helps in sending Rx metadata to PMD and thereby > Rx metadata flow command requests are processed. > > Signed-off-by: Hanumanth Pothula Hi Hanumanth, I agree with Thomas for the patch. 'eth_rx_metadata_negotiate_mp()' requests all Rx metadata offloads to be enabled, but at this stage if there is no flow rule for Rx metadata why it is consuming extra cycles? Can you update driver code to process Rx metadata when it is enabled by application (via 'rte_eth_rx_metadata_negotiate()') AND there is at least one flow rule for it?