From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93E9EA04E6; Wed, 9 Dec 2020 15:17:47 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 72855C9A4; Wed, 9 Dec 2020 15:17:46 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id D5D3AC9A2 for ; Wed, 9 Dec 2020 15:17:44 +0100 (CET) IronPort-SDR: 152VvO2m2kiypgILiDZlJG1ED6k9kb0yUtUpHc6ehBSigpSThZBup66xvSbtHGhCj7uJEKxGe/ ECWFkxHJzVlQ== X-IronPort-AV: E=McAfee;i="6000,8403,9829"; a="153317556" X-IronPort-AV: E=Sophos;i="5.78,405,1599548400"; d="scan'208";a="153317556" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Dec 2020 06:17:43 -0800 IronPort-SDR: HRAyeYFCr2828nOJArC4upO03VvDjXl4+uIE25GuDCQGL5KKrwjynX+HhEMOqb8r+eCdsi3mzt 1XKaQYLoleLQ== X-IronPort-AV: E=Sophos;i="5.78,405,1599548400"; d="scan'208";a="318297903" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.215.89]) ([10.213.215.89]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Dec 2020 06:17:42 -0800 To: selwin.sebastian@amd.com References: <20201119072607.5717-1-selwin.sebastian@amd.com> From: Ferruh Yigit Cc: dev@dpdk.org, "Somalapuram, Amaranath" Message-ID: <12017189-0d86-2cea-8f65-f38dc57a8120@intel.com> Date: Wed, 9 Dec 2020 14:17:38 +0000 MIME-Version: 1.0 In-Reply-To: <20201119072607.5717-1-selwin.sebastian@amd.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v1] net/axgbe: add support for reading FW version X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/19/2020 7:26 AM, selwin.sebastian@amd.com wrote: > From: Selwin Sebastian > > Added support for fw_version_get API > > Signed-off-by: Selwin Sebastian > --- > doc/guides/nics/features/axgbe.ini | 1 + > drivers/net/axgbe/axgbe_ethdev.c | 1 + > drivers/net/axgbe/axgbe_rxtx.c | 21 +++++++++++++++++++++ > drivers/net/axgbe/axgbe_rxtx.h | 3 +++ > 4 files changed, 26 insertions(+) > > diff --git a/doc/guides/nics/features/axgbe.ini b/doc/guides/nics/features/axgbe.ini > index 34df0d1ee..3adc5639f 100644 > --- a/doc/guides/nics/features/axgbe.ini > +++ b/doc/guides/nics/features/axgbe.ini > @@ -17,6 +17,7 @@ CRC offload = Y > L3 checksum offload = Y > L4 checksum offload = Y > Basic stats = Y > +FW version = Y > Linux UIO = Y > x86-32 = Y > x86-64 = Y > diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c > index cfe6aba73..1982c6a8e 100644 > --- a/drivers/net/axgbe/axgbe_ethdev.c > +++ b/drivers/net/axgbe/axgbe_ethdev.c > @@ -257,6 +257,7 @@ static const struct eth_dev_ops axgbe_eth_dev_ops = { > .timesync_adjust_time = axgbe_timesync_adjust_time, > .timesync_read_time = axgbe_timesync_read_time, > .timesync_write_time = axgbe_timesync_write_time, > + .fw_version_get = axgbe_dev_fw_version_get, > }; > > static int axgbe_phy_reset(struct axgbe_port *pdata) > diff --git a/drivers/net/axgbe/axgbe_rxtx.c b/drivers/net/axgbe/axgbe_rxtx.c > index 032e3cebc..227be33fa 100644 > --- a/drivers/net/axgbe/axgbe_rxtx.c > +++ b/drivers/net/axgbe/axgbe_rxtx.c > @@ -571,6 +571,27 @@ int axgbe_dev_tx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx, > return 0; > } > > +int axgbe_dev_fw_version_get(struct rte_eth_dev *eth_dev, > + char *fw_version, size_t fw_size) > +{ > + struct axgbe_port *pdata; > + struct axgbe_hw_features *hw_feat; > + char fw_ver[32]; Is the 'fw_ver' variable not used at all? > + > + pdata = (struct axgbe_port *)eth_dev->data->dev_private; > + hw_feat = &pdata->hw_feat; > + > + if (fw_version == NULL || fw_size <= 0) > + return -EINVAL; > + > + snprintf(fw_version, sizeof(fw_ver), "%d.%d.%d", Shouldn't use 'fw_size' for size limit, instead of 'sizeof(fw_ver)'? > + AXGMAC_GET_BITS(hw_feat->version, MAC_VR, USERVER), > + AXGMAC_GET_BITS(hw_feat->version, MAC_VR, DEVID), > + AXGMAC_GET_BITS(hw_feat->version, MAC_VR, SNPSVER)); > + > + return 0; if the fw version string doesn't fit into the provided buffer, this shouldn't ignored silently, according to the API, size of the non truncated string should be returned. > +} > +