From: Thomas Monjalon <thomas@monjalon.net>
To: David Hunt <david.hunt@intel.com>, bruce.richardson@intel.com
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v4 0/6] power: fix make build for power apps
Date: Fri, 29 Jan 2021 11:27:36 +0100 [thread overview]
Message-ID: <12030371.so1zvZZbsf@thomas> (raw)
In-Reply-To: <20210121172201.22582-1-david.hunt@intel.com>
21/01/2021 18:21, David Hunt:
> The guest channel message definitions and functions in guest_channel.h
> are needed by applications and need to be made public.
>
> This worked pre-20.11, but now with all the meson/ninja changes, making
> these apps externally no longer works. To fix, we need to move the
> header file with the API definitions for the channel commands public,
> and rename the functions accordingly.
>
> The main change is to rename channel_commands.h to
> rte_power_guest_channel.h so that it gets picked up by the installer
> and copied to /usr/local/include. Other changes include renaming #defines
> to have RTE_ at the beginning instead of CPU_. Finally we refactor the
> code to work with those changes.
>
> ---
> v2 changes
> - re-worked from monolithic patch to a 6 patch patchset for easier review
> v3 changes
> - Ensure both functions added to the API are tagged as experimental
> v4 changes
> - add @internal tag on 2 functions for Doxygen
> - add @warning EXPERIMENTAL tag on 2 functions for Doxygen
> - improve description of lcore param in API docs
> - Improve maintainability sizeof's
> - add the 2 added functions to the version.map file
Applied, thanks for the clean-up.
next prev parent reply other threads:[~2021-01-29 10:27 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 11:36 [dpdk-dev] [PATCH v1] " David Hunt
2021-01-08 14:30 ` [dpdk-dev] [PATCH 0/6] " David Hunt
2021-01-08 14:30 ` [dpdk-dev] [PATCH v2 1/6] power: create guest channel public header file David Hunt
2021-01-20 13:55 ` [dpdk-dev] [PATCH v3 0/6] power: fix make build for power apps David Hunt
2021-01-20 13:55 ` [dpdk-dev] [PATCH v3 1/6] power: create guest channel public header file David Hunt
2021-01-20 15:09 ` Burakov, Anatoly
2021-01-20 15:12 ` David Hunt
2021-01-21 17:21 ` [dpdk-dev] [PATCH v4 0/6] power: fix make build for power apps David Hunt
2021-01-21 17:21 ` [dpdk-dev] [PATCH v4 1/6] power: create guest channel public header file David Hunt
2021-01-29 10:21 ` [dpdk-dev] [PATCH v5 0/6] power: fix make build for power apps David Hunt
2021-01-29 10:21 ` [dpdk-dev] [PATCH v5 1/6] power: create guest channel public header file David Hunt
2021-01-29 10:21 ` [dpdk-dev] [PATCH v5 2/6] power: make channel msg functions public David Hunt
2021-01-29 10:21 ` [dpdk-dev] [PATCH v5 3/6] power: rename public structs David Hunt
2021-01-29 10:21 ` [dpdk-dev] [PATCH v5 4/6] power: rename defines David Hunt
2021-01-29 10:21 ` [dpdk-dev] [PATCH v5 5/6] power: add new header file to export list David Hunt
2021-01-29 10:21 ` [dpdk-dev] [PATCH v5 6/6] power: clean up includes David Hunt
2021-01-29 10:30 ` [dpdk-dev] [PATCH v5 0/6] power: fix make build for power apps Thomas Monjalon
2021-01-21 17:21 ` [dpdk-dev] [PATCH v4 2/6] power: make channel msg functions public David Hunt
2021-01-22 12:12 ` Burakov, Anatoly
2021-02-22 9:53 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2021-01-21 17:21 ` [dpdk-dev] [PATCH v4 3/6] power: rename public structs David Hunt
2021-01-22 12:15 ` Burakov, Anatoly
2021-01-22 12:18 ` Burakov, Anatoly
2021-01-22 12:18 ` Burakov, Anatoly
2021-01-28 22:57 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2021-02-22 9:56 ` Ferruh Yigit
2021-01-21 17:21 ` [dpdk-dev] [PATCH v4 4/6] power: rename defines David Hunt
2021-01-22 13:50 ` Burakov, Anatoly
2021-01-21 17:22 ` [dpdk-dev] [PATCH v4 5/6] power: add new header file to export list David Hunt
2021-01-22 13:51 ` Burakov, Anatoly
2021-01-21 17:22 ` [dpdk-dev] [PATCH v4 6/6] power: clean up includes David Hunt
2021-01-22 13:53 ` Burakov, Anatoly
2021-01-29 10:27 ` Thomas Monjalon [this message]
2021-02-24 14:54 ` [dpdk-dev] [PATCH] power: remove duplicated symbols from map file Ferruh Yigit
2021-02-25 9:11 ` David Marchand
2021-02-25 10:41 ` Ferruh Yigit
2021-02-25 10:44 ` David Marchand
2021-02-25 10:54 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2021-02-25 14:38 ` David Marchand
2021-03-02 12:42 ` David Marchand
2021-01-20 13:55 ` [dpdk-dev] [PATCH v3 2/6] power: make channel msg functions public David Hunt
2021-01-20 14:26 ` Burakov, Anatoly
2021-01-20 15:08 ` David Hunt
2021-01-20 15:23 ` Burakov, Anatoly
2021-01-20 13:55 ` [dpdk-dev] [PATCH v3 3/6] power: rename public structs David Hunt
2021-01-20 14:27 ` Burakov, Anatoly
2021-01-20 15:03 ` David Hunt
2021-01-20 13:55 ` [dpdk-dev] [PATCH v3 4/6] power: rename defines David Hunt
2021-01-20 13:55 ` [dpdk-dev] [PATCH v3 5/6] power: add new header file to export list David Hunt
2021-01-20 14:28 ` Burakov, Anatoly
2021-01-20 15:01 ` David Hunt
2021-01-20 15:17 ` Burakov, Anatoly
2021-01-20 15:08 ` Bruce Richardson
2021-01-20 15:18 ` Burakov, Anatoly
2021-01-20 15:29 ` David Hunt
2021-01-20 15:43 ` Burakov, Anatoly
2021-01-20 13:55 ` [dpdk-dev] [PATCH v3 6/6] power: clean up includes David Hunt
2021-01-08 14:30 ` [dpdk-dev] [PATCH v2 2/6] power: make channel msg functions public David Hunt
2021-01-19 14:31 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2021-01-19 14:51 ` David Hunt
2021-01-08 14:30 ` [dpdk-dev] [PATCH v2 3/6] power: rename public structs David Hunt
2021-01-08 14:30 ` [dpdk-dev] [PATCH v2 4/6] power: rename defines David Hunt
2021-01-08 14:30 ` [dpdk-dev] [PATCH v2 5/6] power: add new header file to export list David Hunt
2021-01-08 14:30 ` [dpdk-dev] [PATCH v2 6/6] power: clean up includes David Hunt
2021-01-13 11:08 ` [dpdk-dev] [PATCH 0/6] power: fix make build for power apps Burakov, Anatoly
2021-01-13 11:14 ` David Hunt
2021-01-13 11:18 ` Burakov, Anatoly
2021-01-13 13:25 ` David Hunt
2021-01-13 17:30 ` Burakov, Anatoly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12030371.so1zvZZbsf@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).