From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 64597A09E4; Fri, 29 Jan 2021 11:27:42 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EF4FB240134; Fri, 29 Jan 2021 11:27:41 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 81F8940694; Fri, 29 Jan 2021 11:27:40 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 9969A5C00B1; Fri, 29 Jan 2021 05:27:39 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 29 Jan 2021 05:27:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= Q3yFJszgdsIqZMk+3aqIwfRZ5LNasq39/pyVz93IjlQ=; b=EQmviX44aSfcS7ts QE0aFUp7CMdIyOOpiTz3ESryMB2x0OOUKQUzOtvvcNI/ySc0wsfnMPp/9/BXDK3k 0IGbo1oltOu5eCG1mks9kqTidG2T0v24MOn2/78bovx2bZMxk6WS3ZPwye5AEdpp PuUVwGRp2ZcHU1enbJgkHlAg0aCTvMQtmijlb5GoKC/417/3PMLL20kRex7MVSR7 4Xy/5Mel6bo3O8alI7lFUAynLOB5wNGgeoXM2v3nEaU6xVRmLjkOWzbhq9tdfcdC YSsq9K542IQvrZM108VSyOHyjteAAixScbipUG62vyDqALdp9uRCMv8euKXH6vLV g/PqDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=Q3yFJszgdsIqZMk+3aqIwfRZ5LNasq39/pyVz93Ij lQ=; b=oMlo6RSex+WTsYfHlxlkIatXdEcmLj++ldR8iZU3804cw4V6mNR5W3hMf qnQY+b9ySzQb0g4/QMoniKjCTDX3e5XwvsfzFBZsW95o0G6bo2ect2RXsbrHh8ub O5AEysI2GVzrxUo9642ZeH/ZscVh7M8QaSFGWRbA5QwNkrmaE3vH89Pi03tmNuQE B/dHoPPxuVflCVvuuCL0vxqbdB9SVxJD56oEtFoQh/MFVcDi4D9O5fcmhDWjIl8o qCEGDxEnYa98bmeMOHHk++HFZ6QrzC0zmN0G9Y5sDXNt6tbuxiwEtghPY/HHyvUo YWvtOm9a9xy/AnuiyCeWv0hR1ncTQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfedvgdduhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B0E2C1080059; Fri, 29 Jan 2021 05:27:38 -0500 (EST) From: Thomas Monjalon To: David Hunt , bruce.richardson@intel.com Cc: dev@dpdk.org, stable@dpdk.org Date: Fri, 29 Jan 2021 11:27:36 +0100 Message-ID: <12030371.so1zvZZbsf@thomas> In-Reply-To: <20210121172201.22582-1-david.hunt@intel.com> References: <20210120135556.33763-2-david.hunt@intel.com> <20210121172201.22582-1-david.hunt@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v4 0/6] power: fix make build for power apps X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 21/01/2021 18:21, David Hunt: > The guest channel message definitions and functions in guest_channel.h > are needed by applications and need to be made public. > > This worked pre-20.11, but now with all the meson/ninja changes, making > these apps externally no longer works. To fix, we need to move the > header file with the API definitions for the channel commands public, > and rename the functions accordingly. > > The main change is to rename channel_commands.h to > rte_power_guest_channel.h so that it gets picked up by the installer > and copied to /usr/local/include. Other changes include renaming #defines > to have RTE_ at the beginning instead of CPU_. Finally we refactor the > code to work with those changes. > > --- > v2 changes > - re-worked from monolithic patch to a 6 patch patchset for easier review > v3 changes > - Ensure both functions added to the API are tagged as experimental > v4 changes > - add @internal tag on 2 functions for Doxygen > - add @warning EXPERIMENTAL tag on 2 functions for Doxygen > - improve description of lcore param in API docs > - Improve maintainability sizeof's > - add the 2 added functions to the version.map file Applied, thanks for the clean-up.