From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f182.google.com (mail-we0-f182.google.com [74.125.82.182]) by dpdk.org (Postfix) with ESMTP id 646F658D9 for ; Thu, 18 Sep 2014 17:42:10 +0200 (CEST) Received: by mail-we0-f182.google.com with SMTP id q59so689415wes.27 for ; Thu, 18 Sep 2014 08:47:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=1kIR1EQhZxRORJO7/Bo3lf2YE21G3x8CU4dukMPDJIU=; b=c1R0sMA+kRUJiNIgv8ntpd2Ak10Z7pP/8fLiT86KCrMa/KjnGVEK5W7hA27OC3YDSK WY6JMaxOc5gU9WEn0nI1rBb/LYYWvlwMF/KJmxImxa/sQZlRqbhyt/BF/Lr/tTnnrLkb ZUGZd0otK6ajEDrUERpmJe1x/1Qih6lJ3EznAxs4d5cszrUu3tCm0BMyDuKIARtFOZ04 1kQc9Q9WSsZe3gC8GUQ4EOSYA5Z6MpN77eQ3b+G8daeRVtDdsNiycDjAxbxL8hUQuOWh RqQ7edgawafejpQ1b4ZC7uGz/ObN58JfXmBivfBj1org98O5FxQN7wGBHWbY9w+ygfIi +7+w== X-Gm-Message-State: ALoCoQk7YSH+qor/z9sxLsXcn8+1VIsgJusBytZUgO8uBB1iQ+YO+xRWi2y3hQRBYovbGx1mwxon X-Received: by 10.180.88.167 with SMTP id bh7mr50107306wib.12.1411055275483; Thu, 18 Sep 2014 08:47:55 -0700 (PDT) Received: from xps13.localnet (13.17.90.92.rev.sfr.net. [92.90.17.13]) by mx.google.com with ESMTPSA id ba3sm3439664wib.10.2014.09.18.08.47.53 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Sep 2014 08:47:54 -0700 (PDT) From: Thomas Monjalon To: "De Lara Guarch, Pablo" Date: Thu, 18 Sep 2014 17:45:17 +0200 Message-ID: <12060866.mqQxRznRol@xps13> Organization: 6WIND User-Agent: KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; ) In-Reply-To: References: <1411036471-3822-1-git-send-email-pablo.de.lara.guarch@intel.com> <20140918122129.GD20389@hmsreliant.think-freely.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 0/3] New Thread Safe Hash Library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Sep 2014 15:42:10 -0000 2014-09-18 15:31, De Lara Guarch, Pablo: > From: Neil Horman [mailto:nhorman@tuxdriver.com] > > Thread safe hash tables seem to me like a configuration option rather than > > a new > > library. Instead of creating a whole new library (with a new API and ABI > > to maintain, why not just add thread safety as a configurable option to > > the existing hash library. That saves code space in the DPDK, and > > reduces application complexity (as the same api is useable for thread > > safe and unsafe hash tables) > > Makes sense, but implementation has changed so much to add it directly into > the existing library. At first, this was designed to be a replacement of > the existing library, but since API is a bit different from the old one, it > was thought to leave it as an alternative, so users are not forced to have > to change their applications if they don't want to use thread safe hash > tables. It makes me smile :) You basically explain that it's more complicated to properly merge two different implementations than just throwing a new one in the big DPDK bucket. My opinion is that it should not be integrated as is because we must try to make DPDK something else than a trash bucket. Thanks for continuing your effort to make DPDK easier and better. -- Thomas