From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 28572A0561; Thu, 18 Mar 2021 23:07:07 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A4530140F31; Thu, 18 Mar 2021 23:07:06 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id B486F40698; Thu, 18 Mar 2021 23:07:04 +0100 (CET) IronPort-SDR: AEdUddDigmIVxfD7LBz4YG13inX6TlWsKg3oQF0BPGIF7YPYyRRpq6kGPaOuR4Bu4GB2wjjyFn AUmAAe1kG2Gw== X-IronPort-AV: E=McAfee;i="6000,8403,9927"; a="189154223" X-IronPort-AV: E=Sophos;i="5.81,259,1610438400"; d="scan'208";a="189154223" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Mar 2021 15:07:03 -0700 IronPort-SDR: ch8gCyscf4jwxOG0IVOpnS0twQ4Zw7PANetFYCHwK/Zqj2PQ2WY2Qp6fLrNPeJTiyfRiEBzJA3 Cdr+TXYvozrw== X-IronPort-AV: E=Sophos;i="5.81,259,1610438400"; d="scan'208";a="523416350" Received: from rmenon-desk.amr.corp.intel.com (HELO [10.166.30.253]) ([10.166.30.253]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Mar 2021 15:07:03 -0700 To: Thomas Monjalon , dev@dpdk.org Cc: dmitry.kozliuk@gmail.com, stable@dpdk.org, Tal Shnaiderman , Narcisa Vasile , Pallavi Kadam , John Alexander References: <20210316231153.724029-1-thomas@monjalon.net> <20210318104807.1882334-1-thomas@monjalon.net> From: Ranjit Menon Message-ID: <12081b05-cf28-7730-320e-d86477bea3d5@intel.com> Date: Thu, 18 Mar 2021 15:07:02 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <20210318104807.1882334-1-thomas@monjalon.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v2] bus/pci: fix Windows kernel driver categories X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/18/2021 3:48 AM, Thomas Monjalon wrote: > In Windows probing, the value RTE_PCI_KDRV_NONE was used > instead of RTE_PCI_KDRV_UNKNOWN. > This value covers the mlx case where the kernel driver is in place, > offering a bifurcated mode to the userspace driver. > When the kernel driver is listed as unknown, > there is no special treatment in DPDK probing, contrary to UIO modes. > > The value RTE_PCI_KDRV_NIC_UIO (FreeBSD) was re-used > instead of having a new RTE_PCI_KDRV_NET_UIO for Windows NetUIO. > While adding the new value RTE_PCI_KDRV_NET_UIO > (at the end for ABI compatibility), > the enum of kernel driver categories is annotated. > > Fixes: b762221ac24f ("bus/pci: support Windows with bifurcated drivers") > Fixes: c76ec01b4591 ("bus/pci: support netuio on Windows") > Cc: stable@dpdk.org > > Signed-off-by: Thomas Monjalon > Acked-by: Dmitry Kozlyuk > --- > v2: improve comments and commit message > --- > drivers/bus/pci/rte_bus_pci.h | 13 +++++++------ > drivers/bus/pci/windows/pci.c | 14 +++++++------- > 2 files changed, 14 insertions(+), 13 deletions(-) > Acked-by: Ranjit Menon