From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id AE25B3B5 for ; Tue, 21 Mar 2017 13:22:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490098935; x=1521634935; h=subject:to:references:from:message-id:date:mime-version: in-reply-to:content-transfer-encoding; bh=YoMuHs+A3AdLgBtc2n1AGFkmZIAQ4ey1Fu7Qa/Crjlw=; b=wS85VBiJjLj48gzrNl1N99UOUScPOkDFTKSI0oIFo0bHgYAloB4lNFGK qunN/2oRE699zXV7EbiCnpAYsk4gNg==; Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Mar 2017 05:22:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,198,1486454400"; d="scan'208";a="836998573" Received: from unknown (HELO [10.252.14.247]) ([10.252.14.247]) by FMSMGA003.fm.intel.com with ESMTP; 21 Mar 2017 05:22:13 -0700 To: Keith Wiles , dev@dpdk.org References: <20170307222757.33759-1-keith.wiles@intel.com> From: Declan Doherty Message-ID: <120d52a9-21e9-9819-070f-9fef2763a02f@intel.com> Date: Tue, 21 Mar 2017 12:22:12 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170307222757.33759-1-keith.wiles@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] net/bonding: reduce slave starvation on rx poll X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Mar 2017 12:22:16 -0000 On 07/03/2017 10:27 PM, Keith Wiles wrote: > When polling the bonded ports for RX packets the old driver would > always start with the first slave in the list. If the requested > number of packets is filled on the first port in a two port config > then the second port could be starved or have larger number of > missed packet errors. > > The code attempts to start with a different slave each time RX poll > is done to help eliminate starvation of slave ports. The effect of > the previous code was much lower performance for two slaves in the > bond then just the one slave. > > The performance drop was detected when the application can not poll > the rings of rx packets fast enough and the packets per second for > two or more ports was at the threshold thoughput of the application. > At this threshold the slaves would see very little or no drops in > the case of one slave. Then enable the second slave you would see > a large drop rate on the two slave bond and reduction in thoughput. > Hey Keith, sorry it took me a while to get around to testing this patch as I had some issues with the switch I'm using to test LACP. > Signed-off-by: Keith Wiles > --- ... > Acked-by: Declan Doherty