From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 00E22A0543; Wed, 12 Oct 2022 17:09:43 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7E07A43027; Wed, 12 Oct 2022 17:09:43 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id DBEE242EF7 for <dev@dpdk.org>; Wed, 12 Oct 2022 17:09:41 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 6DA423200952; Wed, 12 Oct 2022 11:09:39 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 12 Oct 2022 11:09:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1665587379; x= 1665673779; bh=l6GUmIiwPAmkMjcg+746aZwicuvGAuGGyKVl9cbhHbk=; b=y h4sWuu9n4VwgEefKOqMEi5Crl1meu94wgYlT7uVa9Mn7Kb77hFrdhwfa/TMLYbTn 0NxGz1NFGz6cpU+GUpOg1bnkTfPw5245LkYAW1S33DmKrqixb8uJbwfMQy8lfz03 pwr9/7F3wWLeBknWyCWjhP+X5UM+6+C/UJo/+kWG/0IHhnZOh6fXDwyPAr8iozWi 5NNPnM2peGlxbBQlC/+W63iWH0jxD1DhFraLZIb29ntFl9MpsaCcKs0zGtEQTmuW ym4UiCCY56Cq2iUo6ZQztax+xgrIuRwKkUdmAJLN1TaZAp8qSYm3GV19wsbhCYj0 UI1rbTTPKYL+ISMolmcww== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1665587379; x= 1665673779; bh=l6GUmIiwPAmkMjcg+746aZwicuvGAuGGyKVl9cbhHbk=; b=m XWOSZnIzqVXU5ePhd17LE+uDjS/ENM5BJOIyYyBwqTW7AnuPyrC1VXzD2ZK9n97O f3KGY6X4FmPe2dZSg++07JXlf2MWPiVZC0l/mvaEOC+t6yb+nM+lXBjRgEkJbmLG Cgfmr4L4J7Iy9BdMgccOhbMGEM4NgiUBlq460PKFYxadcWl3aVtGCw2/OI2pQy/q 6e02oH7aXHZ81avYQFMkDk6ftG7pvFzDdyErEb2133Lvn2aWPFwzLOmP/7dWBreg veet5S1mxpBhncwkOmvu2EctTFYoSowoVBAZgiBi98QtH0GlioYjP8nf/BAzkwX/ oQydaTaopFGKF6+mf0gJQ== X-ME-Sender: <xms:sthGY3uwRtAuF3I3ffVp_Rw-WdRq9iVyHBajhnwdjCy1smf5gvB_PA> <xme:sthGY4fCAdTOvmajV05rqeY81MX4UWi2JqhZz7bHDFzRLjBycWLtga2f8Y_h5Glsj jwwY8NkawM6HV62iw> X-ME-Received: <xmr:sthGY6x1WTdmp_ixi5xukJlakhP4RwA3Xhzp12QH00Y-kJtAKCz0PPeqa_sS_GgmzdcI0pyT66kCfryOKia236OhQg> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeejkedgkeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: <xmx:sthGY2MOQ9i-VJ5KRJhu5WyDN_XiTVf72FjZUftqwTv4O3eKC2YpMA> <xmx:sthGY3_WAa2oFfj5CQA1EHGa0VqkCm_dmfCh_hvTw4ex9TXSfd7LTA> <xmx:sthGY2UKebB_0QXxnCURr8-UVWsr7Iwb7bi56mr5npl8z0WKOvKpcA> <xmx:s9hGY3wqfTK-wnW8AkazJkiBYXuOnlqyUIOVW0A83J6xGgBMAreDLA> Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 12 Oct 2022 11:09:37 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: "Van Haaren, Harry" <harry.van.haaren@intel.com> Cc: "dev@dpdk.org" <dev@dpdk.org>, "jerinj@marvell.com" <jerinj@marvell.com>, "Li, WeiyuanX" <weiyuanx.li@intel.com>, "ferruh.yigit@amd.com" <ferruh.yigit@amd.com>, "andrew.rybchenko@oktetlabs.ru" <andrew.rybchenko@oktetlabs.ru>, Morten =?ISO-8859-1?Q?Br=F8rup?= <mb@smartsharesystems.com>, david.marchand@redhat.com Subject: Re: [PATCH] event/sw: fix selftest xstats reset API usage Date: Wed, 12 Oct 2022 17:09:36 +0200 Message-ID: <12103968.CDJkKcVGEf@thomas> In-Reply-To: <BN0PR11MB5712B572E92483E18BB046EFD7229@BN0PR11MB5712.namprd11.prod.outlook.com> References: <20221012123419.182631-1-harry.van.haaren@intel.com> <5006490.PYKUYFuaPT@thomas> <BN0PR11MB5712B572E92483E18BB046EFD7229@BN0PR11MB5712.namprd11.prod.outlook.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org 12/10/2022 15:08, Van Haaren, Harry: > From: Thomas Monjalon <thomas@monjalon.net> > > 12/10/2022 14:34, Harry van Haaren: > > > The eventdev xstats reset API takes an ID of "uint32_t", while > > > the rest of the xstats APIs require an "unsigned int". On some > > > platforms these might not be the same bitwidth, however this was > > > assumed in the code. > > > > > > Fix by providing a uint32_t to the xstats_reset() function. > > > > Why adding a comment about the type in the code? > > We are not adding /* using the right type */ in each line of code. > > Correct; but as the SW PMD was the only selftest code that actually > uses xstats_reset() I err-ed on the side of warning devs that there's > some "funky" or inconsistent API requirements here. > > I can respin without if that seems better, but my intention was to > help future readers..? It does not really help. If you want to help, and you think the API is wrong, then please send a patch to propose a change in the API.