Re: [dpdk-dev] [PATCH] config: remove duplicate configuration information

[Thomas Monjalon <thomas.monjalon@6wind.com>]

2016-02-22 07:53, Keith Wiles:
> --- /dev/null
> +++ b/config/common_base
> +CONFIG_RTE_EAL_IGB_UIO=y
> +CONFIG_RTE_EAL_VFIO=y

These options should be disabled in the base file
and enabled in Linux.

> +CONFIG_RTE_LIBRTE_PMD_AF_PACKET=y

Idem, it should be disabled.

> +CONFIG_RTE_LIBRTE_POWER=y

Idem?

> +CONFIG_RTE_LIBRTE_KNI=y

Should be disabled.

> +CONFIG_RTE_LIBRTE_VHOST=y

Should be disabled.

> --- a/config/common_bsdapp
> +++ b/config/common_bsdapp
> +# Compile Environment Abstraction Layer for linux, FreeBSD, OS X, ...
> +CONFIG_RTE_LIBRTE_EAL_BSDAPP=y

Please keep the original comment:
Compile Environment Abstraction Layer for BSD

> +# Compile Environment Abstraction Layer

Why this comment before disabling UIO and VFIO?

> --- a/config/common_linuxapp
> +++ b/config/common_linuxapp
> -##
> -## machine can define specific variables or action for a specific board
> -## RTE_MACHINE values are the directories in mk/machine/
> -##
> -#CONFIG_RTE_MACHINE="native"
> -#
> -##
> -## define the architecture we compile for.
> -## RTE_ARCH values are the directories in mk/arch/
> -##
> -#CONFIG_RTE_ARCH="x86_64"
> -#CONFIG_RTE_ARCH_X86_64=y
> -#CONFIG_RTE_ARCH_X86=y
> -#
> -##
> -## The compiler we use.
> -## RTE_TOOLCHAIN values are the directories in mk/toolchain/
> -##
> -#CONFIG_RTE_TOOLCHAIN="gcc"
> -#CONFIG_RTE_TOOLCHAIN_GCC=y

Maybe we should keep these comments in common_base?
I would remove the values and uncomment CONFIG_RTE_MACHINE, CONFIG_RTE_ARCH
and CONFIG_RTE_TOOLCHAIN.

> --- a/config/defconfig_x86_64-native-bsdapp-clang
> +++ b/config/defconfig_x86_64-native-bsdapp-clang
> @@ -37,6 +37,7 @@ CONFIG_RTE_MACHINE="native"
>  CONFIG_RTE_ARCH="x86_64"
>  CONFIG_RTE_ARCH_X86_64=y
>  CONFIG_RTE_ARCH_X86=y
> +CONFIG_RTE_ARCH_64=y
>  
>  CONFIG_RTE_TOOLCHAIN="clang"
>  CONFIG_RTE_TOOLCHAIN_CLANG=y
> diff --git a/config/defconfig_x86_64-native-bsdapp-gcc b/config/defconfig_x86_64-native-bsdapp-gcc
> index 5a6a4e8..4ea4433 100644
> --- a/config/defconfig_x86_64-native-bsdapp-gcc
> +++ b/config/defconfig_x86_64-native-bsdapp-gcc
> @@ -37,6 +37,7 @@ CONFIG_RTE_MACHINE="native"
>  CONFIG_RTE_ARCH="x86_64"
>  CONFIG_RTE_ARCH_X86_64=y
>  CONFIG_RTE_ARCH_X86=y
> +CONFIG_RTE_ARCH_64=y

It should be a totally separate patch.
And there are other places where it is missing.