From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas.monjalon@6wind.com> Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id EC36D2BB8 for <dev@dpdk.org>; Thu, 3 Mar 2016 19:39:08 +0100 (CET) Received: by mail-wm0-f49.google.com with SMTP id p65so2389115wmp.0 for <dev@dpdk.org>; Thu, 03 Mar 2016 10:39:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=TJ0skos2WgsSTXJ6j9+SW5c0EhW/nGRvFLpPzd/MzRk=; b=t+gKlHcV/or6v0oFpbfAu9BgyLxZxgNeCFEBcXVqC/qZNWJuRk/bYd44dJ5HpS3TNR W1SlETzG1C4fcMfqEzZ+bHX6wsJAIGcHRoKfKw4TrC/nqJhG430c35tVK6rat5p5OUi4 VvaIcaDRbojIIHxilPSrCmh7w9+vOlMGCm+jAJHSYiR6M2Jnr+21wZ+AH/zIV3EqkuQu yjGGcEivW+npM8BHlCnB5XZSDrXFyQZRbQwwEvTTMAtHuQxyKPPopHujFBC9cKbOY8Gg wIJpY6jt8LMBvDwhq29BfBcrt0VMfBECFOkNJpQU4o7kU8qYHWSjaEjqoG4UBpcFVFU5 Rm9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=TJ0skos2WgsSTXJ6j9+SW5c0EhW/nGRvFLpPzd/MzRk=; b=Mu+RDdl2vhJ3TUNoCFu7R0Kfz0Ou3AhsyZuKrzmwZlvLgHLQEwCAbFvBR8Xm9XV/hf wzhd0lzSqzvd96RiCNxZyYoyPPs89Pgv9+lruxZNkTjKsccDzyt1D6CrLbgdFGJY+opE rUTX/e0m1USsCP2PnZQRhUfextEUk5noAFcuHF03f0HIUb4O4GkGAy+qYCzpYkZLBDmA 8PfAzFz9l6a2Dvys6wp0DjypCfO1gr/8wywZPOV2vHcbfGK5+ub4wY4+S3qaMekOcO9p 8gAB9bT5B83fgGayx6xu2w5N7LLhfYkI3Bdo6DqAxfKUZmnBnex72p7cd+XwmmdFEUq8 Pb7A== X-Gm-Message-State: AD7BkJKbllO5OZacyKB8H9ecDgePA5D9c5Y1pQYCO10vgIkUZgFtyxDYY3buqfOQVREkYlU6 X-Received: by 10.28.6.139 with SMTP id 133mr588646wmg.84.1457030348818; Thu, 03 Mar 2016 10:39:08 -0800 (PST) Received: from xps13.localnet (132.20.90.92.rev.sfr.net. [92.90.20.132]) by smtp.gmail.com with ESMTPSA id xx3sm41809458wjc.32.2016.03.03.10.39.07 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 03 Mar 2016 10:39:07 -0800 (PST) From: Thomas Monjalon <thomas.monjalon@6wind.com> To: Keith Wiles <keith.wiles@intel.com> Date: Thu, 03 Mar 2016 19:37:31 +0100 Message-ID: <121442835.2vdhmXQbJs@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1456149217-24833-1-git-send-email-keith.wiles@intel.com> References: <1456149217-24833-1-git-send-email-keith.wiles@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] config: remove duplicate configuration information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 03 Mar 2016 18:39:09 -0000 2016-02-22 07:53, Keith Wiles: > --- /dev/null > +++ b/config/common_base > +CONFIG_RTE_EAL_IGB_UIO=y > +CONFIG_RTE_EAL_VFIO=y These options should be disabled in the base file and enabled in Linux. > +CONFIG_RTE_LIBRTE_PMD_AF_PACKET=y Idem, it should be disabled. > +CONFIG_RTE_LIBRTE_POWER=y Idem? > +CONFIG_RTE_LIBRTE_KNI=y Should be disabled. > +CONFIG_RTE_LIBRTE_VHOST=y Should be disabled. > --- a/config/common_bsdapp > +++ b/config/common_bsdapp > +# Compile Environment Abstraction Layer for linux, FreeBSD, OS X, ... > +CONFIG_RTE_LIBRTE_EAL_BSDAPP=y Please keep the original comment: Compile Environment Abstraction Layer for BSD > +# Compile Environment Abstraction Layer Why this comment before disabling UIO and VFIO? > --- a/config/common_linuxapp > +++ b/config/common_linuxapp > -## > -## machine can define specific variables or action for a specific board > -## RTE_MACHINE values are the directories in mk/machine/ > -## > -#CONFIG_RTE_MACHINE="native" > -# > -## > -## define the architecture we compile for. > -## RTE_ARCH values are the directories in mk/arch/ > -## > -#CONFIG_RTE_ARCH="x86_64" > -#CONFIG_RTE_ARCH_X86_64=y > -#CONFIG_RTE_ARCH_X86=y > -# > -## > -## The compiler we use. > -## RTE_TOOLCHAIN values are the directories in mk/toolchain/ > -## > -#CONFIG_RTE_TOOLCHAIN="gcc" > -#CONFIG_RTE_TOOLCHAIN_GCC=y Maybe we should keep these comments in common_base? I would remove the values and uncomment CONFIG_RTE_MACHINE, CONFIG_RTE_ARCH and CONFIG_RTE_TOOLCHAIN. > --- a/config/defconfig_x86_64-native-bsdapp-clang > +++ b/config/defconfig_x86_64-native-bsdapp-clang > @@ -37,6 +37,7 @@ CONFIG_RTE_MACHINE="native" > CONFIG_RTE_ARCH="x86_64" > CONFIG_RTE_ARCH_X86_64=y > CONFIG_RTE_ARCH_X86=y > +CONFIG_RTE_ARCH_64=y > > CONFIG_RTE_TOOLCHAIN="clang" > CONFIG_RTE_TOOLCHAIN_CLANG=y > diff --git a/config/defconfig_x86_64-native-bsdapp-gcc b/config/defconfig_x86_64-native-bsdapp-gcc > index 5a6a4e8..4ea4433 100644 > --- a/config/defconfig_x86_64-native-bsdapp-gcc > +++ b/config/defconfig_x86_64-native-bsdapp-gcc > @@ -37,6 +37,7 @@ CONFIG_RTE_MACHINE="native" > CONFIG_RTE_ARCH="x86_64" > CONFIG_RTE_ARCH_X86_64=y > CONFIG_RTE_ARCH_X86=y > +CONFIG_RTE_ARCH_64=y It should be a totally separate patch. And there are other places where it is missing.