From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id B4D4258D8 for ; Tue, 24 Nov 2015 11:40:36 +0100 (CET) Received: by wmww144 with SMTP id w144so20208025wmw.0 for ; Tue, 24 Nov 2015 02:40:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=88Hg6Fbd+JCGaSLVbTH0GhcMShSnwPaPzgqYFanKqWQ=; b=C2v+df/IXNxjZjDWSyUrwYdW9CNZce5wUsZZpKAXnJInKXxYVHvoHLdJTNLqzQS1Sq DuGYh4xDc9d0pF+IJDgwWxyf+hBnoArrpBwBwhu1yW7rTdMnuPtosYmW90KIquOB+2VF KcORWYClseWH5+H9fuc94MqPRfWveGf8E5ROMRyXSttplvG1uM6mCxHx1zqNrZLL2Wts WAllNm3ZDF3eMuho16BQ8giVBw/ouxrZ4nPv2ehXzNJ6MEY6M6sRiZ3UQcfuEjTDb/S7 7e4yme+3H/OcLQObJl7zWZ6axRYCaJop2LGQzNY4XF7X7+4itZycs0iImlffVzNEpgMT Kq/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=88Hg6Fbd+JCGaSLVbTH0GhcMShSnwPaPzgqYFanKqWQ=; b=kb9eDdWbfyfOJHJnnPgeQaR+q/XWxQ/GlJQlVIBKrC+YhsyL3T8ZayRWRewNemlhif ARPtL1noRn11JOZytsC86clmD/k3YfD4Nb/251m/d14d8TtxkObBP7GyzFpfnBBjd1u8 K/A0Z07WhCD7fnOdPQfgBwHDbC9BvyaPHrJxzE3ABPkMGK0FfJo1C0/igUFPURyNtgKi 5QqzYosUp78SD+/UQE3N0OPfWkustMGRVkHYEQ/nwpMyed+jMZiPIf1DCT9MQaFHEex1 11ShRc3wZjOdBiZer5Nz5N2+54W8arYmPapPOd3TOK4iPv4d5f0ykG+rtSJqScchdi/a Ptug== X-Gm-Message-State: ALoCoQkXGRmCiDfUQl5IbS2TDBbeFeqRoJdVdNaAcVQGX28gcTGHYlZc6VB3T2NBUFA+YdeqhPij X-Received: by 10.28.6.130 with SMTP id 124mr25498439wmg.7.1448361636517; Tue, 24 Nov 2015 02:40:36 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id c13sm17420255wmd.14.2015.11.24.02.40.35 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 24 Nov 2015 02:40:35 -0800 (PST) From: Thomas Monjalon To: "Chen Jing D(Mark)" Date: Tue, 24 Nov 2015 11:39:19 +0100 Message-ID: <12180988.okvxpfoiHK@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1448334616-14540-1-git-send-email-jing.d.chen@intel.com> References: <1447304251-4145-1-git-send-email-jing.d.chen@intel.com> <1448334616-14540-1-git-send-email-jing.d.chen@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] fm10k: fix a crash bug when quit from testpmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Nov 2015 10:40:36 -0000 2015-11-24 11:10, Chen Jing D: > When the fm10k port is closed, both func tx_queue_clean() and > fm10k_tx_queue_release_mbufs_vec() will try to release buffer in > SW ring. The latter func won't do sanity check on those pointers > and cause crash. > > The fix removed Vector TX buffer release func since it can share > the release functions with regular TX. > > fixes: fb9066e479a6(fm10k: reset and release mbuf) > > Signed-off-by: Chen Jing D(Mark) > Acked-by: Michael Qiu Applied, thanks