From: "Juraj Linkeš" <juraj.linkes@pantheon.tech>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: "thomas@monjalon.net" <thomas@monjalon.net>,
"Ruifeng.Wang@arm.com" <Ruifeng.Wang@arm.com>,
"Honnappa.Nagarahalli@arm.com" <Honnappa.Nagarahalli@arm.com>,
"jerinjacobk@gmail.com" <jerinjacobk@gmail.com>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
"aboyer@pensando.io" <aboyer@pensando.io>,
"dev@dpdk.org" <dev@dpdk.org>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
"bluca@debian.org" <bluca@debian.org>
Subject: Re: [dpdk-dev] [RFC PATCH v4] build: kni cross-compilation support
Date: Mon, 8 Feb 2021 10:17:56 +0000 [thread overview]
Message-ID: <121a529885424ec28c24e51f3e8979ff@pantheon.tech> (raw)
In-Reply-To: <20210205152713.GD1462@bricha3-MOBL.ger.corp.intel.com>
> -----Original Message-----
> From: Bruce Richardson <bruce.richardson@intel.com>
> Sent: Friday, February 5, 2021 4:27 PM
> To: Juraj Linkeš <juraj.linkes@pantheon.tech>
> Cc: thomas@monjalon.net; Ruifeng.Wang@arm.com;
> Honnappa.Nagarahalli@arm.com; jerinjacobk@gmail.com;
> hemant.agrawal@nxp.com; ferruh.yigit@intel.com; aboyer@pensando.io;
> dev@dpdk.org; david.marchand@redhat.com; bluca@debian.org
> Subject: Re: [RFC PATCH v4] build: kni cross-compilation support
>
> On Fri, Feb 05, 2021 at 04:04:32PM +0100, Juraj Linkeš wrote:
> > The kni linux module is using a custom target for building, which
> > doesn't take into account any cross compilation arguments. The
> > arguments in question are ARCH, CROSS_COMPILE (for gcc, clang) and CC,
> > LD (for clang). Get those from the cross file and pass them to the
> > custom target.
> >
> > The user supplied path may not contain the 'build' directory, such as
> > when using cross-compiled headers, so only append that in the default
> > case (when no path is supplied in native builds) and use the
> > unmodified path from the user otherwise. Also modify the install path
> accordingly.
> >
> > Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> > ---
>
> Thanks, this all looks ok to me now, bar one very minor nit below. Doing a native
> build on my system with the running kernel also works fine.
>
> However, the bigger question is one of compatibility for this change. The current
> documentation for the kernel_dir option is:
> option('kernel_dir', type: 'string', value: '',
> description: 'Path to the kernel for building kernel modules. \
> Headers must be in $kernel_dir/build. Modules will be installed \
> in $DEST_DIR/$kernel_dir/extra/dpdk.')
>
> Obviously the description now needs an update to reflect the new use
I'll change the description. The current patch version is always installing the modules into '/lib/modules/' + kernel_version + '/extra/dpdk', though. I don't think we want to change the behavior this way, so I'll make the changes to preserve to original behavior ('/lib/modules/' + kernel_version + '/extra/dpdk' when kernel_dir is not supplied, kernel_dir + '/extra/dpdk' when it is).
> , but I'm
> not sure if changing the behaviour counts as an "ABI" change or not, and
> whether it needs to wait for a new LTS release. Any scripts that were compiling
> using e.g. kernel_dir='/lib/modules/<version>' need to be changed to use
> kernel_dir='/lib/modules/<version>/build' instead.
>
I'm not sure what to do with this. Should I make it backwards compatible by checking the build dir as well (i.e. trying make kernelversion in both $kernel_dir and $kernel_dir/build)?
> /Bruce
>
> > kernel/linux/kni/meson.build | 8 ++--
> > kernel/linux/meson.build | 80 ++++++++++++++++++++++++++++++------
> > 2 files changed, 71 insertions(+), 17 deletions(-)
> >
> > diff --git a/kernel/linux/kni/meson.build
> > b/kernel/linux/kni/meson.build index 07e0c9dae7..46b71c7418 100644
> > --- a/kernel/linux/kni/meson.build
> > +++ b/kernel/linux/kni/meson.build
> > @@ -13,7 +13,7 @@ kni_sources = files( custom_target('rte_kni',
> > input: kni_sources,
> > output: 'rte_kni.ko',
> > - command: ['make', '-j4', '-C', kernel_dir + '/build',
> > + command: ['make', '-j4', '-C', kernel_build_dir,
> > 'M=' + meson.current_build_dir(),
> > 'src=' + meson.current_source_dir(),
> > 'MODULE_CFLAGS=-include ' + meson.source_root() +
> > '/config/rte_config.h' + @@ -21,8 +21,8 @@ custom_target('rte_kni',
> > ' -I' + meson.source_root() + '/lib/librte_kni' +
> > ' -I' + meson.build_root() +
> > ' -I' + meson.current_source_dir(),
> > - 'modules'],
> > + 'modules'] + cross_args,
> > depends: kni_mkfile,
> > - install: true,
> > - install_dir: kernel_dir + '/extra/dpdk',
> > + install: install,
> > + install_dir: kernel_install_dir,
> > build_by_default: get_option('enable_kmods')) diff --git
> > a/kernel/linux/meson.build b/kernel/linux/meson.build index
> > 5c864a4653..7acb52944f 100644
> > --- a/kernel/linux/meson.build
> > +++ b/kernel/linux/meson.build
> > @@ -3,25 +3,79 @@
> >
> > subdirs = ['kni']
> >
> > -# if we are cross-compiling we need kernel_dir specified -if
> > get_option('kernel_dir') == '' and meson.is_cross_build()
> > - error('Need "kernel_dir" option for kmod compilation when cross-
> compiling')
> > -endif
> > +kernel_build_dir = get_option('kernel_dir') install = not
> > +meson.is_cross_build() cross_args = [] kernel_install_dir = ''
>
> Minor nit, I'd have kernel_install_dir immediately after kernel_build_dir in the list
> above.
>
Sure.
next prev parent reply other threads:[~2021-02-08 10:18 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 10:29 [dpdk-dev] [RFC PATCH v1] build: kni gcc " Juraj Linkeš
2021-01-29 11:43 ` Bruce Richardson
2021-01-29 12:33 ` Juraj Linkeš
2021-01-29 13:51 ` Bruce Richardson
2021-01-29 14:36 ` Juraj Linkeš
2021-01-29 14:42 ` Bruce Richardson
2021-01-29 14:47 ` Juraj Linkeš
2021-01-29 15:01 ` Bruce Richardson
2021-01-29 15:17 ` Juraj Linkeš
2021-01-29 15:39 ` Bruce Richardson
2021-02-01 7:48 ` Juraj Linkeš
2021-02-04 9:51 ` [dpdk-dev] [RFC PATCH v2] build: kni " Juraj Linkeš
2021-02-04 17:33 ` Bruce Richardson
2021-02-05 9:26 ` Juraj Linkeš
2021-02-05 9:38 ` Bruce Richardson
2021-02-05 9:44 ` Thomas Monjalon
2021-02-05 9:42 ` Bruce Richardson
2021-02-05 14:46 ` [dpdk-dev] [RFC PATCH v3] " Juraj Linkeš
2021-02-05 14:52 ` Bruce Richardson
2021-02-05 15:02 ` Juraj Linkeš
2021-02-05 15:04 ` [dpdk-dev] [RFC PATCH v4] " Juraj Linkeš
2021-02-05 15:27 ` Bruce Richardson
2021-02-08 10:17 ` Juraj Linkeš [this message]
2021-02-08 10:26 ` Bruce Richardson
2021-02-08 10:56 ` Thomas Monjalon
2021-02-08 11:05 ` Bruce Richardson
2021-02-08 11:21 ` Thomas Monjalon
2021-02-08 11:45 ` Bruce Richardson
2021-02-08 17:23 ` Thomas Monjalon
2021-02-09 8:47 ` [dpdk-dev] [PATCH v5] " Juraj Linkeš
2021-02-09 11:50 ` Bruce Richardson
2021-02-09 12:07 ` Juraj Linkeš
2021-02-09 12:39 ` Bruce Richardson
2021-02-11 12:59 ` [dpdk-dev] [PATCH v6] " Juraj Linkeš
2021-03-09 8:47 ` Juraj Linkeš
2021-03-09 16:26 ` Andrew Boyer
2021-03-15 22:45 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=121a529885424ec28c24e51f3e8979ff@pantheon.tech \
--to=juraj.linkes@pantheon.tech \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=aboyer@pensando.io \
--cc=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=jerinjacobk@gmail.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).