From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A9BF242DAF; Mon, 3 Jul 2023 13:50:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 336ED40EF0; Mon, 3 Jul 2023 13:50:02 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id DE0E740ED5 for ; Mon, 3 Jul 2023 13:50:00 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 48DC95C00E9; Mon, 3 Jul 2023 07:50:00 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 03 Jul 2023 07:50:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1688385000; x=1688471400; bh=mJ/Lp+tOcM0uR90cqf8wGE5PdOPjGgR9LU6 XEgivh5A=; b=Z1t2lwuhm4pQkHuVw6tv+ZPnqvbepo7oGYtvTv2zldexwG1azdc OhbIQM+E8lmFNiBTlhmhZY6Xh3XHavOsoWY8YRbjoBYeWGkwwbJFoSFVww6jcqW9 h92UuHehLt+R61uHc83UzCHzdnYnuMRrqfU2uemnVVwCsuphImP4KK2BHCdbv9eS 1ukVyq6A3gkXKXuSNxqMBLB/O4Edvbja4RfOm5CQkTj+cVYgWvmjPNBWVeiznYJR cQstlImD+n1x8KWr560vpelPSjTeEs8p48UFCVHDjVYvTMVrdQyQrPWHbeZjkmL9 KNYUEgb7sMpI6yzFShzvcti4zLq75czBjfg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1688385000; x=1688471400; bh=mJ/Lp+tOcM0uR90cqf8wGE5PdOPjGgR9LU6 XEgivh5A=; b=IPXlQH/tOvALT1SAcEBt3pyKMh6/8kgN+BXCddMswbkQrsNsoVq 960ZIR6jX3UqPvnS4d42B2OwvQxPnWbIy0g8BAqCMAUgh6WTDfxXShtFlhQ012A5 RWGukWU8bHpQHfMAfvT+OCczCwoogYK5219TjZFuXywuaWf+2qAqpWz5x5OEPM1v sa72Ukpz1F9kfOtIfkCcpLmFP4r3TvhcdWr+CtW27IrKW/9jgF0QSNMxUDpNtZOw R3pnJw+fsW+rgvL6Ti+w13/Eq03Em4oU6r1XXC3bAxOHShmpF59USBPqFW9nd8iz lUvtiowVq7sJmrqW37754Te2/ErMWijJa+w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedruddvgdeggecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepgedttdeljeejgeffkeekkedtjeevtdehvedtkeeivdeuuedviedu vdelveejueejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 3 Jul 2023 07:49:56 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: dev@dpdk.org, Timothy McDaniel , Shepard Siegel , Ed Czeck , John Miller , Rosen Xu , Matan Azrad , Viacheslav Ovsiienko , Ori Kam , Suanming Mou , Andrew Rybchenko , Tianfei Zhang , Xiao Wang , Maxime Coquelin , Chenbo Xia , Anatoly Burakov , Bruce Richardson , Harman Kalra , Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , Naga Harish K S V , Jerin Jacob , Ciara Power Subject: Re: [PATCH] set namespace prefix to threads Date: Mon, 03 Jul 2023 13:49:55 +0200 Message-ID: <12236357.O9o76ZdvQC@thomas> In-Reply-To: References: <20230703112359.5067-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 03/07/2023 13:38, David Marchand: > On Mon, Jul 3, 2023 at 1:24=E2=80=AFPM Thomas Monjalon wrote: > > > > When looking at threads in a system, it can be confusing > > to find some unknown threads without a clue it is started by DPDK. > > > > Let's start all thread names with "dpdk-" > > and the driver name if it comes from a driver. > > > > One more constraint: the thread names are generally limited > > to 16 characters, including NUL character. >=20 > Yes, and no way to discover this limit. >=20 >=20 > > > > Signed-off-by: Thomas Monjalon > > --- > > Please review carefully, I may have missed things. > > > > Note: we should use rte_ctrl_thread_create() as much as possible. > > >=20 > As for this comment, we should advertise rte_thread_create_control() > instead, as it is thread library agnostic. > Which leads me to suggest looking at rte_thread_create_control() calls to= o. You're right, I'll do a second pass. > > diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c > > index 7008303e11..e201acd1c2 100644 > > --- a/lib/eal/freebsd/eal.c > > +++ b/lib/eal/freebsd/eal.c > > @@ -843,7 +843,7 @@ rte_eal_init(int argc, char **argv) > > > > /* Set thread_name for aid in debugging. */ > > snprintf(thread_name, sizeof(thread_name), > > - "rte-worker-%d", i); > > + "dpdk-worker-%d", i); > > rte_thread_set_name(lcore_config[i].thread_id, thread_n= ame); > > > > ret =3D rte_thread_set_affinity_by_id(lcore_config[i].t= hread_id, >=20 > We changed this not so long ago with 8ae946970ed3 ("eal: fix thread > name for high order lcores") which offered up to 4 digits for lcores. > With your proposal, we are back to only 3 digits, which is probably > enough, but I preferred to raise it. In general no need of hyphen before a number. I will change to dpdk-worker%d.