[dpdk-dev] [DPDK] /driver/bus/ifpga: users do not have to input afu_bts in cmdline

[dpdk-dev] [DPDK] /driver/bus/ifpga: users do not have to input afu_bts in cmdline

[AndyPei]

Original driver requires users to input "afu_bts" args.
After apply this patch, driver can also work without a
"afu_bts" args explicitly in the cmdline.

fixes: 05fa3d4a6539
cc: rosen.xu@intel.com
cc: tianfei.zhang@intel.com
cc: andy.pei@intel.com

Signed-off-by: AndyPei <andy.pei@intel.com>
---
 drivers/bus/ifpga/ifpga_bus.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/bus/ifpga/ifpga_bus.c b/drivers/bus/ifpga/ifpga_bus.c
index 5f23ed8..e4b7b6f 100644
--- a/drivers/bus/ifpga/ifpga_bus.c
+++ b/drivers/bus/ifpga/ifpga_bus.c
@@ -125,15 +125,13 @@ void rte_ifpga_driver_unregister(struct rte_afu_driver *driver)
 				     IFPGA_AFU_BTS);
 			goto end;
 		}
+		afu_pr_conf.pr_enable = 1;
 	} else {
-		IFPGA_BUS_ERR("arg %s is mandatory for ifpga bus",
-			  IFPGA_AFU_BTS);
-		goto end;
+		afu_pr_conf.pr_enable = 0;
 	}
 
 	afu_pr_conf.afu_id.uuid.uuid_low = 0;
 	afu_pr_conf.afu_id.uuid.uuid_high = 0;
-	afu_pr_conf.pr_enable = path?1:0;
 
 	if (ifpga_find_afu_dev(rawdev, &afu_pr_conf.afu_id))
 		goto end;
-- 
1.8.3.1

Re: [dpdk-dev] [DPDK] /driver/bus/ifpga: users do not have to input afu_bts in cmdline

[Xu, Rosen]

> -----Original Message-----
> From: Pei, Andy
> Sent: Monday, January 14, 2019 9:41
> To: dev@dpdk.org
> Cc: Xu, Rosen <rosen.xu@intel.com>; Zhang, Tianfei
> <tianfei.zhang@intel.com>; Pei, Andy <andy.pei@intel.com>
> Subject: [DPDK] /driver/bus/ifpga: users do not have to input afu_bts in
> cmdline
> 
> Original driver requires users to input "afu_bts" args.
> After apply this patch, driver can also work without a "afu_bts" args explicitly
> in the cmdline.
> 
> fixes: 05fa3d4a6539
> cc: rosen.xu@intel.com
> cc: tianfei.zhang@intel.com
> cc: andy.pei@intel.com
> 
> Signed-off-by: AndyPei <andy.pei@intel.com>
> ---
>  drivers/bus/ifpga/ifpga_bus.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/bus/ifpga/ifpga_bus.c b/drivers/bus/ifpga/ifpga_bus.c
> index 5f23ed8..e4b7b6f 100644
> --- a/drivers/bus/ifpga/ifpga_bus.c
> +++ b/drivers/bus/ifpga/ifpga_bus.c
> @@ -125,15 +125,13 @@ void rte_ifpga_driver_unregister(struct
> rte_afu_driver *driver)
>  				     IFPGA_AFU_BTS);
>  			goto end;
>  		}
> +		afu_pr_conf.pr_enable = 1;
>  	} else {
> -		IFPGA_BUS_ERR("arg %s is mandatory for ifpga bus",
> -			  IFPGA_AFU_BTS);
> -		goto end;
> +		afu_pr_conf.pr_enable = 0;
>  	}
> 
>  	afu_pr_conf.afu_id.uuid.uuid_low = 0;
>  	afu_pr_conf.afu_id.uuid.uuid_high = 0;
> -	afu_pr_conf.pr_enable = path?1:0;
> 
>  	if (ifpga_find_afu_dev(rawdev, &afu_pr_conf.afu_id))
>  		goto end;
> --
> 1.8.3.1

Acked-by: Rosen Xu <rosen.xu@intel.com>

[dpdk-dev] [PATCH v2] bus/ifpga: fix forcing optional devargs

[Ferruh Yigit]

From: Andy Pei <andy.pei@intel.com>

Original driver requires users to input "afu_bts" args.
But driver can also work without an explicit "afu_bts" args.

Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")
Cc: stable@dpdk.org

Signed-off-by: Andy Pei <andy.pei@intel.com>
Acked-by: Rosen Xu <rosen.xu@intel.com>
---
Cc: rosen.xu@intel.com
Cc: tianfei.zhang@intel.com
---
 drivers/bus/ifpga/ifpga_bus.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/bus/ifpga/ifpga_bus.c b/drivers/bus/ifpga/ifpga_bus.c
index 5f23ed8b4..e4b7b6f50 100644
--- a/drivers/bus/ifpga/ifpga_bus.c
+++ b/drivers/bus/ifpga/ifpga_bus.c
@@ -125,15 +125,13 @@ ifpga_scan_one(struct rte_rawdev *rawdev,
 				     IFPGA_AFU_BTS);
 			goto end;
 		}
+		afu_pr_conf.pr_enable = 1;
 	} else {
-		IFPGA_BUS_ERR("arg %s is mandatory for ifpga bus",
-			  IFPGA_AFU_BTS);
-		goto end;
+		afu_pr_conf.pr_enable = 0;
 	}
 
 	afu_pr_conf.afu_id.uuid.uuid_low = 0;
 	afu_pr_conf.afu_id.uuid.uuid_high = 0;
-	afu_pr_conf.pr_enable = path?1:0;
 
 	if (ifpga_find_afu_dev(rawdev, &afu_pr_conf.afu_id))
 		goto end;
-- 
2.17.2

Re: [dpdk-dev] [PATCH v2] bus/ifpga: fix forcing optional devargs

[Thomas Monjalon]

18/01/2019 12:07, Ferruh Yigit:
> From: Andy Pei <andy.pei@intel.com>
> 
> Original driver requires users to input "afu_bts" args.
> But driver can also work without an explicit "afu_bts" args.
> 
> Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Andy Pei <andy.pei@intel.com>
> Acked-by: Rosen Xu <rosen.xu@intel.com>

Applied, thanks