From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 3EA1558FE for ; Mon, 15 Oct 2018 23:47:29 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A19A0220EF; Mon, 15 Oct 2018 17:47:28 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 15 Oct 2018 17:47:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=DBWYkJdvYvwctJxq4+VnfviJMPlicEbk63V4zVO2ySk=; b=Dx5dkWF7cc03 EGCuWlGSi2QcIASITvamG9QzorsqOgUfBHhcvIBOywWyhpEhksExjA/5+CY6pVdW 5j4CSqxRZ89LEW8/irQaRD5PjWjqc1lv17mw8WhSRCVNL87ORsEnGTRR4QzkmBTy /e5uHpoIsb/P5mtVsX5E+8ZfTXSH7wU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=DBWYkJdvYvwctJxq4+VnfviJMPlicEbk63V4zVO2y Sk=; b=A8s8YcMZy+BxnaN+uuw6EM2p8ifqETnVgYyGUizAO5F6IcxH5UtJFiEDM rWwtGjiyWi5Xx+ZmzNSrkTdb4UKD8Y0CVnbtnWcC2TysbewYCEmv66nGXSODYtHj hzreZRkNdDHwTAQyiPZqJGDNbds4PXitgyIB2FWeoCbgTz6rpBJ5RWGama/TaSPY q2VK7zXzpewq3koDKAarhxZMIWh3qaLjHgss2e/Mp3zgwWeHPsBXW6ddMrS2BRea 0qN8ibTXcRIi4jCq/7XDshDkm18JQW67GJZBVJytTrGQs8SI7UF+1bMxiF7Q7H+x Vow+7EtnG6hK0tDwjk5YCqgvOPDKA== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id F25D1E4074; Mon, 15 Oct 2018 17:47:24 -0400 (EDT) From: Thomas Monjalon To: Jeff Guo Cc: dev@dpdk.org, "Burakov, Anatoly" , stephen@networkplumber.org, bruce.richardson@intel.com, ferruh.yigit@intel.com, konstantin.ananyev@intel.com, gaetan.rivet@6wind.com, jingjing.wu@intel.com, motih@mellanox.com, matan@mellanox.com, harry.van.haaren@intel.com, qi.z.zhang@intel.com, shaopeng.he@intel.com, bernard.iremonger@intel.com, arybchenko@solarflare.com, jblunck@infradead.org, shreyansh.jain@nxp.com, helin.zhang@intel.com, jerin.jacob@caviumnetworks.com Date: Mon, 15 Oct 2018 23:47:26 +0200 Message-ID: <12330354.ROdScU4qL8@xps> In-Reply-To: <8e44ad47-133f-8e20-6600-df0df3ac8682@intel.com> References: <1534503091-31910-1-git-send-email-jia.guo@intel.com> <1538635483-92222-1-git-send-email-jia.guo@intel.com> <8e44ad47-133f-8e20-6600-df0df3ac8682@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 0/4] Enable hotplug in vfio X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2018 21:47:29 -0000 04/10/2018 11:11, Burakov, Anatoly: > On 04-Oct-18 7:44 AM, Jeff Guo wrote: > > As we may know that the process of hotplug is different between igb_uio > > and vfio. For igb_uio, it could use uevent notification and memory > > failure handle mechanism for hot-unplug. But for vfio, when device is be > > hot-unplugged, the uevent can not be detected immediately, because of the > > vfio kernel module will use a special mechanism to guaranty the pci > > device would not be deleted until the user space release the resources, > > so it will use another req notifier event at first to notify user space > > to release resources for hotplug. > > > > This patch will add a new interrupt type of req notifier in eal interrupt, > > and add the new interrupt handler in pci device to handle the req device > > event. When the req notifier be detected, it can trigger the device event > > callback process to process for hot-unplug. With this mechanism, hotplug > > could be enable in vfio. > > LGTM > > Acked-by: Anatoly Burakov Applied, thanks