From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 0B6083784 for ; Tue, 8 Dec 2015 21:31:21 +0100 (CET) Received: by wmec201 with SMTP id c201so45280859wme.1 for ; Tue, 08 Dec 2015 12:31:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=VCwsV8V5d0hzOdOae2d86I0PWV7kAdOgA1npyiTGSOc=; b=o412p3YiUlarUeGcDI2vCz5IDt/Uyvp7ipNtNuv0ZsjShhE46H7fnYl51q32RdreVo mFM7k63FEdC1N/FCDBNXK6vHDeR58ehfknvYMmyPuK0+MRf3Nu1A/RVsO3ZcLaABzfOe kzRtR+GGv4y1eg70t85j/WPjuug1fjUG0iIiI4YMmM4TCA1qBwl7flKkmkGKtQzPR1Vc lD8YRjJt9TwAjQXsZ+LZqqAkRIuYHbkPWmtfThLKsW0eOpwAoG+y3IrNXFlouxk6aHZ9 tJGqH7bjPktibexcpwvezctxm4ZnAj3RQEpCdbK8up5zmcr8TaMPceaqpfkSZHFuK3P3 +nFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=VCwsV8V5d0hzOdOae2d86I0PWV7kAdOgA1npyiTGSOc=; b=YhjZ8We0DTmg5b31G4pB6FJk32J/B4byOk5oKVdz/eDG8JJf15dkWnbZUapAZvtDU8 v6/lqRQ+3gorZGjaLtfK+jOGqo0kz5CR0hXsdqWt2jgldx2e4RvYSVaNtrQiK7dTc+YB RsQJaIeL9mi2mcrqVRZdsosZnJs2t6FUlVHSkz3eQrtiT65qBlmE2qsg0gdsf+Oi9ki6 d6MUfZgRl+zNGLLM2/3sMFMR2A0aI02D4DSS3GkAsyT7ZeLxE4G7WyStMjSip+dp9RDK KhtE4uMR3QOk+CRsWH3bkmVfXavrGMe10PuMhJcG7VrhjzYqLFssJD0iV+5lLIMwxbDE ++2g== X-Gm-Message-State: ALoCoQmikQ2IoasylDSzNrkA34YY+b9VdoGKseeoOxKEvZU8a7KdrwyQJXn/ptaHK1nWNItHIJ1eqLxZ0c07aNyJFEywo05E0g== X-Received: by 10.28.3.133 with SMTP id 127mr31567519wmd.101.1449606679842; Tue, 08 Dec 2015 12:31:19 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id uz5sm4492105wjc.8.2015.12.08.12.31.18 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 08 Dec 2015 12:31:18 -0800 (PST) From: Thomas Monjalon To: Jan Viktorin Date: Tue, 08 Dec 2015 21:30:03 +0100 Message-ID: <12400151.dpjLSRpzoz@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1449602993-6047-1-git-send-email-viktorin@rehivetech.com> References: <1449602993-6047-1-git-send-email-viktorin@rehivetech.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [[RFC PATCH]] lib/ether: fix 16-bit unaligned access X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Dec 2015 20:31:21 -0000 2015-12-08 20:29, Jan Viktorin: > (I considered to not add the cover-letter as this is just a single small patch. > I hope it does not matter a lot. Is there any convention how to do this?) The main interest of splitting patches or adding a cover letter it to have a place to explain the changes. When you have several changes, they deserve several patches to provide an accurate explanation. In such case, you may need a cover letter to describe the global idea of the series. A cover letter is also helpful for mail threading and acking all the series. When you have only one change, one email is enough. John, should we add this explanation in the contributing guide?