From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E268145A5F; Sun, 29 Sep 2024 20:55:40 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6FEB640273; Sun, 29 Sep 2024 20:55:40 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2081.outbound.protection.outlook.com [40.107.96.81]) by mails.dpdk.org (Postfix) with ESMTP id 2CADB400D5 for ; Sun, 29 Sep 2024 20:55:38 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=u/pbex9plAijUciWWdy2SiDCIM9j83fnzs2yOdM4P9XMQOmVKD3pbiLL1ajTbr9gPJ5WLCH0brBaLRYVGkcUoTeqtYtj6aXLCZ/ekcx3oagQQJxvhOE1dXrVa8pbUX1h0rogO+vFvUVyy9iqEL+2NDaze6PNSNNaCGqi1gBW5f/ol2dBe6e3F2RNTA6duDSebEo7//duAIrbIWrd2/Fcd28+ttPlk7MOG5oC2cPOQFLKGk2N5q71LIXfr5ayGR5q7APsL2E4x++ManO8EtMlB+2cCqeCcdZ1t3IXGUo/yyUpXVsmvswAlOvajHOcko+0fJ4fbl42nrRRkfUs4seNBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8viG87Q3M6bWVlQcckNL7uR6A4TULJ6YzutCMxBTVp0=; b=cWU8ntFgwL4edzyjmHn4mkEuZhbPcpeH0V0gxT95rZkEN3mgpSgbDI3+kckw1a4+hKX7VWizFnbmwWU+iHvDOzsfo9bDsF0/DM+PoKD9aka0uFJPtebsi15s4gORZt7M0u42sXRE65TK/hh//lm7ADMqzCOarpUQDRJ96QK7taKtMZq9qmw76FglkKWh3xMlUEq6IcdieBPXAUAyp7krVOex9099EabV3dadaQDCYba/O20Bxqfv7AyYYAY8apkuTrq5/+57qMC5AwY/0g4UGV5Dlyd611haqwx5cXFrJKsGjpkLl6EzKqAPLO1mEg4+wv7hvFoXICy9mWO7yrbklA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8viG87Q3M6bWVlQcckNL7uR6A4TULJ6YzutCMxBTVp0=; b=Y3TF3SzbetbSQD/2HgyfYNZRRo/U+ye6kIG3KpfiiILU4ePQBjNqtJlTiyvOGqkAQYs22TegJ0Hz/AWwJ6zxKqtfT8KmoTLx3+kHgt96fIdZWqZCbBVuw/BFslJtUXkS/iCtnj8E3TJBry/b87Qc7G67AdKfH2zEXUFcaG0XhcI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) by PH7PR12MB5596.namprd12.prod.outlook.com (2603:10b6:510:136::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8005.26; Sun, 29 Sep 2024 18:55:34 +0000 Received: from SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055]) by SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055%4]) with mapi id 15.20.8005.024; Sun, 29 Sep 2024 18:55:34 +0000 Message-ID: <1240fd64-ba5d-4dcc-b825-851da25b8efb@amd.com> Date: Sun, 29 Sep 2024 19:55:28 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [RFC] ethdev: introduce PTP device capability To: "lihuisong (C)" Cc: dev@dpdk.org, Thomas Monjalon , Andrew Rybchenko References: <20240130035820.29713-1-lihuisong@huawei.com> <0f4dd7ef-2dd1-0565-c5f3-520581422eb5@huawei.com> <789124c2-e7a8-4409-97d7-958d6a750561@amd.com> <72cc97a9-9b8c-4593-cd57-abbdf9156d46@huawei.com> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <72cc97a9-9b8c-4593-cd57-abbdf9156d46@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0376.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18e::21) To SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR12MB8830:EE_|PH7PR12MB5596:EE_ X-MS-Office365-Filtering-Correlation-Id: 6075d52a-4fab-45b2-9f31-08dce0b84c70 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?QmZjbGdDYjhSSW9Ecy9ObnpOaGFnOVRVTmM5R2JEdktudmhDcDNRNkVEOGxO?= =?utf-8?B?MFI2VDZQSjVwUUVVUVlvcE1NUHZMcFRPZ1puMjJvcDVlREo0NFVZTDg4NUhx?= =?utf-8?B?VDZYK1ZuTnluWllhVmx3S2lEeUQ4STZjdHA2dnMzYWdPc0RRQm01R252RWhk?= =?utf-8?B?Z3VDdDRNbmx0VUFESEpvRS9OWjM3Vm9aMVpiSHlUK1lVUFArOGwwdWdqeUN2?= =?utf-8?B?dkFxVlp1cFV0dXpvUjRkb3lxTGpvMmxFNi9BODIxZnpDa2N0Q2xjYlY0d0Fo?= =?utf-8?B?R2RrUUFEaXhVZHFoUnc3YXlYSlBONHJ5dnZ3UWYyK0llektBQUFhelplMFZk?= =?utf-8?B?ZkVNbzFpQzdudTJnUlhyU0ROODBLeDA3VTZaSmp1bWVIUWtzVm1keklyRzQv?= =?utf-8?B?ZThSWWRlSWFVVnVENnVSTFhKNTJUYU41TlFMOWZ5WVFBS0xRbkFJZTRkV0x0?= =?utf-8?B?eWx1T0lVeUxUYU5GTm5MSWprVXlvT3JHTWNWc29iSm5Bd3o1ZXhvbEdXcVVv?= =?utf-8?B?VlAvMDJqMVhGNjZQZDdVK1k3aE1TMWI5SlYyL3UxU3poR1dVS3Q4a3VpYWVz?= =?utf-8?B?K3dLQk92bWVXN093UDdTM0JOVU5DcXRLRDUzTERZbi84aXVFaFI3dUdobld3?= =?utf-8?B?RGpSVDAzMG53SXlqUTJKaGk0eUtkQXJKZHZrRG5OMEI3T1N1aUg3UUNCQ3Z2?= =?utf-8?B?SlNQaHpPcVQwQ001bndqNEhwaEtnOFdDUnFKQlhpUnNGNlBMZkJYWmFGTm5T?= =?utf-8?B?eVpHVWpINldXS0EyK01tNGk4elJnV1hUeWYrTHRCekVNSDB1K2ZickYzdEwr?= =?utf-8?B?cGp1a0poREpYeGg3VFVYa2hScWhGNU44SlhjQUF2YjF6ZXhiS1h2dXE3TkZV?= =?utf-8?B?V1AxZ2x4a1luTkViZG4vcWtWVnBaNndTU2VxbU93Qm4rL3VvVWRhMGNYa1lu?= =?utf-8?B?Q2kxUXdJVkdYYmlvYkZVSjJyYlFEdTBTVjZZdWtmbVlxZHl2bTc3dWxGU3hi?= =?utf-8?B?cThoaDNDaytvWUNsWVVQbm9QN2tQNzM0MGNQcFVUTG1RS2R1cGZqUU9pMGEv?= =?utf-8?B?elhjRnBKdDNQU2dSaWNCU0ZUcEpyei92Qy9KUlhSTlpMd3p3TlpsL2UxKzdJ?= =?utf-8?B?MFNTUy9VYytxQ2ZyNnRMbHpJdFpOWUh1MWVBUWxNRUdISmpJRUxwRXI0UFhi?= =?utf-8?B?M0Y0TEZycDRTU0QzWHFiZWp3N1drQmxDSUY4NU9wbnFKM0NrSHRGc1RYRDR3?= =?utf-8?B?R1lGQXdWMUt2RjBhOWRZQWJqZ2ZSQ0dZNVMyWWFiVk1PWU1OT2wwQVNyajYy?= =?utf-8?B?YWtWWC8xYnBXNHdLQ1dWMTdUOG85Ynk4UCs3SVl5Wkllbk0rR0d1T3ZMV3Yv?= =?utf-8?B?OTN4Zm1YWWNIZXJ4dTNIUzJSa04zNnQ3V1NvbnQrR2hNSmFPdko3K1hlNlQz?= =?utf-8?B?djU0dm03VElyZVU3SlhhWVFubDB0TVVCd2JXTHA3NFBTOW5raGppV1R2cUdE?= =?utf-8?B?QXg0OFFMMHpzVHhDN1piMDdCU1p4MVpEVXBWT2hyb29xSU5OcmJZZGF3TEdS?= =?utf-8?B?L2R2V1g2dG9KOHFtR3JDQ2N0cTgrL0tRM0x0VTZ3Q005QlU1REduc2gyWENS?= =?utf-8?B?Q28yT3ZrNEtEVDVUZXR6Z0xrczZuVHQreG9uMERxUWs2SWc2aFRUV3JVazBR?= =?utf-8?B?Z0JCVXRLVlQyVTZRdnl4WE5qYndUR0V4NTNNaHFEYlhzZFJEUDQwa2RaSFFz?= =?utf-8?Q?dfj+19XmPcWNZ2CSEI=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ2PR12MB8830.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z0tRKzRwT3k3NlZub0NQL0ZKUVJRNFY5TGhRdWpXaHZJZjFiN25PSXVuL0Vi?= =?utf-8?B?SUlSYlRkZTJRUlJ6ZEhtWGJENkhQQ2NSUlFhYUw0L2x5THpYNFFIeGZ6Vk1O?= =?utf-8?B?RjlPU05kZkJsWWozQkk2MFg2WXJaWXZIRTUweTRrbytySXNGbHZnN1F2a1ZQ?= =?utf-8?B?R3RadnR2SzZISDVvU2l2d0RkQUhlS3J2bTA3ci9wUlBQY3Awa1ZJQ25oWnNv?= =?utf-8?B?MEY4U2ZPYy9lRDNkTlRvL0Z3S2k4OG1DbWhvajE2Vk5LU0lRZXBBclJCVUIr?= =?utf-8?B?RlhUK1dVcGkvM1VRT3JTamtRNFYyWkNEcm9IdFNvbGYxblhtSmFidVR6TVk3?= =?utf-8?B?WWsvQlFNQmRWeVZQYko0amRmdWhHVXBWb1V2bmpaZ0ZxYkJhNXREdGc3Y2Fz?= =?utf-8?B?QWdQZm4rTHJPd3Q0c3NzYjQ4SUlNTUQvQ2syL2h0SmtZcXNFTDNhQ2h6dWtw?= =?utf-8?B?Y3VEQkdyVmJkUk4zSlZ2UG1HT3daQVIwaDN1UTdDTEpSY29sWEdvOEhhV0RC?= =?utf-8?B?K0NKQlJNbDYwcytkaTJNbk9YQi9rc1M1bllNSFFuejYwaUdmZW9nSm9vYnl6?= =?utf-8?B?Q01IK0kybnZQNFlrNTB3MjV5Y1JaNWNUUENUU09oRDdOV3p6U0FCaHJKa3hT?= =?utf-8?B?ZXZQL2sycm53RVdMUDVBeXlxV2hINEl2SDRmbXcwb1NFdi9JdmUxM1JFNmx2?= =?utf-8?B?TnN2dzJ6ODlOd0M2Rml2T2Rtcms3SmJsdVVkTmNHYUdleWhKWExNRTFVS0Jw?= =?utf-8?B?aWM0MTlnSHpLUGpYWEZTMXNKT3ovUG45SUZiL2duQjQ0U0x6UnNxam5RTjdN?= =?utf-8?B?dDhFZlp2Y2dmR3lOMGthaURoalB4T2ZRaG55K3JtcUE0T2hPMVRLaTQwZXVx?= =?utf-8?B?Q0U4b3BoSVd3eFZBRndnODF6enNWNVdUN0tjSmkwemlOOHkyeVE3eWtsdldE?= =?utf-8?B?aGZpTTBURFVHM3U4LzhjaFpyblp4SDFTNGwraEdDM3drMWZNTGhOYzRyZjJu?= =?utf-8?B?M3lsL2I1cnkxZURCSkFlV2RHNDVUSzVZZjhwUWpLaytSM3dPa0ZES3huUDQ1?= =?utf-8?B?Sk9xT2FDNlZNdGtmSFVGcG92MDBFblg0dnNnWlhDUFpReXpuZnZ3ek1FSFhq?= =?utf-8?B?aWtzQ0dmamVBUi9RSUVPMkRuOWxDWEFqdFFwMjRTZnlZbFl0aGxzT01ja2Yv?= =?utf-8?B?NXBRZnJ6UXVTdndCTXJTTlV1YWV0MWE1SVhJUlRsdThDajVwSGhlWGhLZGRQ?= =?utf-8?B?TUE4cWloaXdzeUtGNkZJc1J6SWExL1NITGsxNVJBNnNscmNSdlBBNE9NdTFt?= =?utf-8?B?cjFQK1hBVitpL2hKK3Z0OG9wZTBzdzUxTXVkcmZRbVBQTndTUHhyOVpJTU4r?= =?utf-8?B?NzdXOUxqRG9yQnRVRElpMUZDUEN2UlMyQklpd21zOWxzUlZhYjhRc0s0dFdF?= =?utf-8?B?cFRNQlY4T1htYUhWRDhJeDZvS2Y1NWZqNGpIVGpEZ3BUdnhkbmtQbFJubDlX?= =?utf-8?B?WGY4eFFzRDl1S3JlTlJ3Y2M2dS9uTFlHc1VzZEhDZkE3bTBmN2dLSFFkWENE?= =?utf-8?B?SmQ2NHJHZVN5ZkRXcXhpQ0toWitmK0RJc09FN3EzTkE5b1l0Q3NPRDNaR0tZ?= =?utf-8?B?eHYxYk1CVGhzR0RENDJ0YzdzaFBEY0tRQU1hbmRZZW03d1drVFdSeE02c291?= =?utf-8?B?U2RUNGorTjk3THdodS9GZVV2UWIybmFUUG5yMUk1UXNLUW1NSmIzcUg1dzRE?= =?utf-8?B?ZFVsUkJnWWF3bDhQWGpUdE1KMXJTbExPRTVsSTNFNlJsbzZCT21WbHZqU0k4?= =?utf-8?B?ZzlmM25mSktSTGlNY0NzeVVKTll1b3duQUUybDZ5UGhYdkNvbExmWHBPRG9h?= =?utf-8?B?RDZwN2ZQV3BWZXlkdVpQY2QzQXNHY3lyV3pKUWpER3I2QlVYQnhOOU9qQ0Ru?= =?utf-8?B?SXdxVkNXQ09DT3lhRGkvbXpjMG1kVTk5MDdYU1hwYmMwUFNSci9Qa1NJM2Uz?= =?utf-8?B?ajdSdm9UUWdGTXFWR21SQ1RmcXZFZm5CeUFXMktSNThKRDVSK2hEMTZKNDI2?= =?utf-8?B?YTA0Tkc1M2xheFNubW1oVFhMVHFQYW5IK3l5ZW4vaEVGMjg5eFNqbVpFZGJK?= =?utf-8?Q?NNkYVSqpD5uOWHR9Wd5ZaI+u6?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6075d52a-4fab-45b2-9f31-08dce0b84c70 X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8830.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2024 18:55:34.3150 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LfDnrUWSamnMz9wPtmrMyZWzuKHT0MNvgc3nMEbmQRqxvx7sSgfGNpkq7l2HQUYv X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5596 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/29/2024 2:31 AM, lihuisong (C) wrote: > > 在 2024/9/26 4:42, Ferruh Yigit 写道: >> On 9/24/2024 8:24 AM, lihuisong (C) wrote: >>> Hi Ferruh, >>> >>> >>> 在 2024/9/23 6:23, Ferruh Yigit 写道: >>>> On 1/30/2024 3:58 AM, Huisong Li wrote: >>>>> Currently, the PTP feature is a little messy and has some issue. >>>>> 1> There is different implementation for PTP. This feature of some >>>>>      hardware depends on the Rx HW timestamp offload, and use this >>>>>      offload to detect if enable PTP feature. Others can enable PTP >>>>>      feature with only ethdev ops. >>>>> 2> For some drivers, enabling PTP feature also depends on the macro >>>>>      RTE_LIBRTE_IEEE1588. Actually, whether device support, enable >>>>>      or disable this feature should not be determined at compilation >>>>>      time. This has been discussed in thread [1]. >>>>> 3> The user haven't a good way to distinguish which port supports >>>>>      the PTP feature in the case that a couple of device belong to the >>>>>      same driver. And PTP related API in ethdev layer doesn't do check >>>>>      for PTP capability. This has been mentioned and discussed in >>>>>      thread [2]. >>>>> >>>>> In the thread [1], there is a conclusion that remove the compiling >>>>> macro RTE_LIBRTE_IEEE1588. And in the thread [2], there is a common >>>>> opinion that the RTE_ETH_RX_OFFLOAD_TIMESTAMP cannot be used as the >>>>> PTP capability. >>>>> >>>>> For the above issuse, this patch introduces a PTP capability in >>>>> rte_eth_dev_info.dev_capa to report PTP capability. >>>>> >>>>> Welcome to jumping into discussion. >>>>> >>>>> [1] https://patchwork.dpdk.org/project/dpdk/ >>>>> patch/20230203132810.14187-1-thomas@monjalon.net/ >>>>> [2] https://inbox.dpdk.org/dev/20230817084226.55327-1- >>>>> lihuisong@huawei.com/ >>>>> >>>>> Signed-off-by: Huisong Li >>>>> --- >>>>>    lib/ethdev/rte_ethdev.h | 6 ++++++ >>>>>    1 file changed, 6 insertions(+) >>>>> >>>>> diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h >>>>> index efa4f12b2a..4c8bd691bd 100644 >>>>> --- a/lib/ethdev/rte_ethdev.h >>>>> +++ b/lib/ethdev/rte_ethdev.h >>>>> @@ -1613,6 +1613,12 @@ struct rte_eth_conf { >>>>>    #define RTE_ETH_DEV_CAPA_FLOW_RULE_KEEP         RTE_BIT64(3) >>>>>    /** Device supports keeping shared flow objects across restart. */ >>>>>    #define RTE_ETH_DEV_CAPA_FLOW_SHARED_OBJECT_KEEP RTE_BIT64(4) >>>>> +/** >>>>> + * Device supports PTP feature. >>>>> + * For some hardware, this feature also need to set the offload >>>>> + * RTE_ETH_RX_OFFLOAD_TIMESTAMP, please check >>>>> rte_eth_dev_info.rx_offload_capa. >>>>> + */ >>>>> +#define RTE_ETH_DEV_CAPA_PTP                     RTE_BIT64(5) >>>>>    /**@}*/ >>>>>      /* >>>> Hi Huisong, >>>> >>>> Thanks for the effort, as you mentioned PTP feature can be improved and >>>> there is a target to remove RTE_LIBRTE_IEEE1588 build time macro. >>>> >>>> As far as I remember, one of the main reasons of the >>>> RTE_LIBRTE_IEEE1588 >>>> macro is some HW has resource restrictions, when RTE_LIBRTE_IEEE1588 is >>>> enabled some other features, like vector datapath, are not usable, that >>>> is why this is a build time selection. >>> I think the main reason that driver don't support PTP feature in vector >>> datapath is for performance. >>> This can be controled by releated dev_ops API or TIMESTAMP offload and >>> no need to use RTE_LIBRTE_IEEE1588 macro, like hns3. >>>> And related to the PTP capability, can you please give some more >>>> information, what does device having PTP capability exactly means. >>> Just the device having PTP capability can be used to enable PTP feature. >>> >> Hi Huisong, >> >> I am asking for your support but not able to get detailed information is >> not helping to progress the patch. >> >> If application implements PTP protocol, we already have APIs for >> application to read time from NIC, or to adjust NIC clock, etc..: >> 'rte_eth_timesync_read_time()' >> 'rte_eth_timesync_adjust_time()' >> ... >> >> Application can check if these APIs are supported by the device to >> deduce if PTP can be supported by device or not, why this is not >> sufficient? > > I'm going to look at these rte_eth_timesync_xx API again. Driver will > return -ENOTSUP if the deivce doesn't support PTP feature. > And the rte_eth_timesync_enable is called first, application know if the > device support this feature when receive this error code. > That is to say, application has to try to call these API first for this > PTP capability of a certain device. > All is ok to me even though it seems like not friendly to application. > Yes, please look at them, we can discuss later if something is missed, or an API like 'rte_eth_timesync_enable()' can be sufficient to detect PTP support. Agree that checking if an API failed is not most friendly way to application, but I think we have this an many other dev_ops, as we don't have a capability flag per each dev_ops. >> >> If application PTP implementation requires HW timestamp offload, >> availability of this offload also can be checked. > Yes >> >> I think for most of the cases, with combination of above two, >> application can decide if it can support PTP with given device or not. > > If driver also requires HW timestamp offload for PTP, this can be tell > to user in driver. > We don't need a specific flag for PTP for this, if HW requires timestamp offload support for PTP, it can check timestamp offlaod to decide to use PTP of not. Perhaps this usage was confusing us that drivers checking timestamp offload for PTP support. >> >> What else is missing so that application needs this additional >> capability flag from NIC? > Previously, I thought that a driver supports multiple devices on a > platform, but only one device support PTP. > In this case, application can't know which device support PTP. > But from now on, each device know if they support PTP feature and driver > can return -ENOTSUP when this device doesn't support this feature. > From this point, I think the additional capability flag is not necessary. > > But I still agree that remove the macro RTE_LIBRTE_IEEE1588. 😁 > Agree, Let me bring this topic in release status meeting, if we can remove the flag in this release, and still give enough time to drivers to fix their drivers before end of the release. >> >>>> PTP is protocol and it is implemented in userspace daemon. I guess even >>>> NIC does not support timestamp offloading, by using time information >>>> from SW it can still implement PTP, right? >>> AFAIS, PTP feature implement requires the collaboration of HW and SW, as >>> describted by the releated dev_ops API. >>> >>>> Is PTP offload means, offloading some part of the protocol >>>> communication >>>> withing the device? >>> Normally, a feature offload means this feature is done in hardware and >>> the software doesn't need to something for this. >>> I reviewed our discussion in [1], we all think it's unreasonable to name >>> it "PTP offload". >>> >>>> Btw, the relevant RTE_ETH_RX_OFFLOAD_TIMESTAMP offload is, a little >>>> more >>>> generic HW capability that HW can add timestamp to Rx/Tx packets, which >>>> can be used for custom diagnostics. HW supporting this offload means >>>> that HW has some specific clock HW in it. >>> Yes. >>>> Both having RTE_ETH_RX_OFFLOAD_TIMESTAMP and RTE_ETH_DEV_CAPA_PTP >>>> capability can be confusing, lets clarify it more. >>> Let me try to clearify them: >>> 1) RTE_ETH_DEV_CAPA_PTP just means the ethdev support PTP capability >>> because of application no way to know if the device support PTP feature. >>> 2) As you said above, setting RTE_ETH_RX_OFFLOAD_TIMESTAMP offload is >>> not necessary for PTP feature, but also may be for custom diagnostics. >>>     Some NICs enable PTP feature using only the rte_eth_timesync_xxx >>> API, >>>     and many NICs also need this offload to fill timestamp in mbuf to >>> cooperate with the implementation of PTP feature. >>> >>> [1] https://inbox.dpdk.org/dev/20230817084226.55327-1- >>> lihuisong@huawei.com/ >>>> >>>> . >> .