DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Walsh, Conor" <conor.walsh@intel.com>
Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"techboard@dpdk.org" <techboard@dpdk.org>,
	Stephen Hemminger <stephen@networkplumber.org>,
	"Richardson, Bruce" <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH 3/6] usertools/setup: remove running built applications
Date: Thu, 26 Nov 2020 15:04:47 +0100
Message-ID: <12453683.mZJSUfSEK2@thomas> (raw)
In-Reply-To: <DM5PR1101MB21212215C2CF7206A87C635FFFF90@DM5PR1101MB2121.namprd11.prod.outlook.com>

26/11/2020 15:02, Walsh, Conor:
> Hi Ferruh,
> 
> Patch tested.
> 
> Thanks,
> Conor.
> 
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Ferruh Yigit
> > Sent: Wednesday 25 November 2020 19:19
> > To: Thomas Monjalon <thomas@monjalon.net>
> > Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; dev@dpdk.org;
> > techboard@dpdk.org; Stephen Hemminger
> > <stephen@networkplumber.org>; Richardson, Bruce
> > <bruce.richardson@intel.com>
> > Subject: [dpdk-dev] [PATCH 3/6] usertools/setup: remove running built
> > applications
> > 
> > Running application relies on make based build variable 'RTE_TARGET' to
> > find the location of the applications, which is not valid anymore.
> > 
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Tested-by: Conor Walsh <conor.walsh@intel.com>

Hi Conor,
If no comment on code below, you can remove the below lines from your reply.
Thanks


> 
> > ---
> >  usertools/dpdk-setup.sh | 52 ++---------------------------------------
> >  1 file changed, 2 insertions(+), 50 deletions(-)
> > 
> > diff --git a/usertools/dpdk-setup.sh b/usertools/dpdk-setup.sh
> > index bcf0c843678f..759f6c096536 100755
> > --- a/usertools/dpdk-setup.sh
> > +++ b/usertools/dpdk-setup.sh
> > @@ -17,11 +17,6 @@ echo "-----------------------------------------------------------
> > ---------------
> > 
> >  HUGEPGSZ=`cat /proc/meminfo  | grep Hugepagesize | cut -d : -f 2 | tr -d ' '`
> > 
> > -#
> > -# Application EAL parameters for setting memory options
> > (amount/channels/ranks).
> > -#
> > -EAL_PARAMS='-n 4'
> > -
> >  #
> >  # Sets QUIT variable so script will finish.
> >  #
> > @@ -252,34 +247,6 @@ set_numa_pages()
> >  	create_mnt_huge
> >  }
> > 
> > -#
> > -# Run unit test application.
> > -#
> > -run_test_app()
> > -{
> > -	echo ""
> > -	echo "  Enter hex bitmask of cores to execute test app on"
> > -	echo "  Example: to execute app on cores 0 to 7, enter 0xff"
> > -	echo -n "bitmask: "
> > -	read Bitmask
> > -	echo "Launching app"
> > -	sudo ${RTE_TARGET}/app/test -c $Bitmask $EAL_PARAMS
> > -}
> > -
> > -#
> > -# Run unit testpmd application.
> > -#
> > -run_testpmd_app()
> > -{
> > -	echo ""
> > -	echo "  Enter hex bitmask of cores to execute testpmd app on"
> > -	echo "  Example: to execute app on cores 0 to 7, enter 0xff"
> > -	echo -n "bitmask: "
> > -	read Bitmask
> > -	echo "Launching app"
> > -	sudo ${RTE_TARGET}/app/testpmd -c $Bitmask $EAL_PARAMS -- -i
> > -}
> > -
> >  #
> >  # Print hugepage information.
> >  #
> > @@ -381,24 +348,10 @@ step1_func()
> >  	FUNC[7]="set_vfio_permissions"
> >  }
> > 
> > -#
> > -# Options for running applications.
> > -#
> > -step2_func()
> > -{
> > -	TITLE="Run test application for linux environment"
> > -
> > -	TEXT[1]="Run test application (\$RTE_TARGET/app/test)"
> > -	FUNC[1]="run_test_app"
> > -
> > -	TEXT[2]="Run testpmd application in interactive mode
> > (\$RTE_TARGET/app/testpmd)"
> > -	FUNC[2]="run_testpmd_app"
> > -}
> > -
> >  #
> >  # Other options
> >  #
> > -step3_func()
> > +step2_func()
> >  {
> >  	TITLE="Other tools"
> > 
> > @@ -410,7 +363,7 @@ step3_func()
> >  #
> >  # Options for cleaning up the system
> >  #
> > -step4_func()
> > +step3_func()
> >  {
> >  	TITLE="Uninstall and system cleanup"
> > 
> > @@ -433,7 +386,6 @@ step4_func()
> >  STEPS[1]="step1_func"
> >  STEPS[2]="step2_func"
> >  STEPS[3]="step3_func"
> > -STEPS[4]="step4_func"
> > 
> >  QUIT=0
> > 
> > --
> > 2.26.2
> 
> 






  reply	other threads:[~2020-11-26 14:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-25 19:19 [dpdk-dev] [PATCH 0/6] update dpdk-setup.sh Ferruh Yigit
2020-11-25 19:19 ` [dpdk-dev] [PATCH 1/6] usertools/setup: remove make based build Ferruh Yigit
2020-11-26 13:56   ` Walsh, Conor
2020-11-25 19:19 ` [dpdk-dev] [PATCH 2/6] usertools/setup: remove inserting custom kernel modules Ferruh Yigit
2020-11-26 14:00   ` Walsh, Conor
2020-11-25 19:19 ` [dpdk-dev] [PATCH 3/6] usertools/setup: remove running built applications Ferruh Yigit
2020-11-26 14:02   ` Walsh, Conor
2020-11-26 14:04     ` Thomas Monjalon [this message]
2020-11-25 19:19 ` [dpdk-dev] [PATCH 4/6] usertools/setup: remove hugepage functions Ferruh Yigit
2020-11-26 14:10   ` Walsh, Conor
2020-11-25 19:19 ` [dpdk-dev] [PATCH 5/6] usertools/setup: fix loading vfio module Ferruh Yigit
2020-11-25 19:19 ` [dpdk-dev] [PATCH 6/6] usertools/setup: move removal target to 21.11 Ferruh Yigit
2020-11-27 13:57 ` [dpdk-dev] [PATCH 0/6] update dpdk-setup.sh Burakov, Anatoly
2020-11-27 14:12   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12453683.mZJSUfSEK2@thomas \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=conor.walsh@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=stephen@networkplumber.org \
    --cc=techboard@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git