From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9485EA0525; Fri, 21 Feb 2020 09:49:58 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2E14A1BFB3; Fri, 21 Feb 2020 09:49:57 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id A8E9F1BFAE; Fri, 21 Feb 2020 09:49:55 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E2C4921E5B; Fri, 21 Feb 2020 03:49:54 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 21 Feb 2020 03:49:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=FbnO5zuX6g0bVzD55befoUvEifeY5LRnc1YA4S50Wmk=; b=KfMiuTXtq9uJ h6Zg5iFp+J5G3lO27vF+PMsznbge5EGrcuFWpVy8m1ta79qHVyijXjfwqMSaV9W8 rX3E1QiXMhDVtW2d2gPS6jHJQylxMhNDeXLpSueQiNfR+Pze9CPGbNI6eQI3yxHZ yJI0629hiBnqBTy6h+4j96sKfPG+1Rw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=FbnO5zuX6g0bVzD55befoUvEifeY5LRnc1YA4S50W mk=; b=L9IxEqu99nV3UgSpN1UaOePXhQMLiaejd7uHJMWlxBnupGbSCGfNyIzF7 8Oq2cMv2MWeH/QgCfZ12o/B/04mA0qjn+O9ITKdnNH6uUVRPQzQ3SXZ6xYEUKUOI nh2HxMYwWHzhWw1HXfH5hSrxayXk2dZeJ+7i1AIYrxYqkZzDay5jB5sAHm2k4kqf 4Szyzjh3eMVWoryPF6BeJQwzD6cbjD3U8NUDKOab0qILi14CF8VLTQHoi7EXvMEj VrqDwEI9snNkYHn2u1LkTfGa3nEZjE8MVZghAJFX/klvQ+J/oD/SJFh0tzuaTK8t lyCVPZSEUM6tLkrGauqbvG3pQkRSA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrkeefgdduvdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgr rhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 67FAA3060BE4; Fri, 21 Feb 2020 03:49:53 -0500 (EST) From: Thomas Monjalon To: "Zhu, TaoX" Cc: "dev@dpdk.org" , "Ananyev, Konstantin" , "Lu, Wenzhuo" , "stable@dpdk.org" , "Ye, Xiaolong" , "Yigit, Ferruh" Date: Fri, 21 Feb 2020 09:49:52 +0100 Message-ID: <12459934.uLZWGnKmhe@xps> In-Reply-To: <60652C6914E08D41B9AA1580751B3CA9015DB0D6@SHSMSX103.ccr.corp.intel.com> References: <1577328342-216505-1-git-send-email-taox.zhu@intel.com> <5029938.usfYGdeWWP@xps> <60652C6914E08D41B9AA1580751B3CA9015DB0D6@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix blocking system events X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 21/02/2020 09:19, Zhu, TaoX: > Hi Thomas > > Thank you for your correction spelling error of 'cancel'. > > Indeed it is not the best solution by creating a thread. I refer to the same solution with Linux kernel driver. Linux kernel driver manages link status by using a thread. Maybe we can figure out another better solution to fix this problem but it may take much more time. At this time, 20.02 formal release is coming and this problem affect some basic library. > Tks for your understanding. I understand, that's why I already accepted this patch in mainline (while fixing typo). Please it would be really appreciated to work on a better solution. > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > Sent: Thursday, February 20, 2020 11:37 PM > > To: Ye, Xiaolong ; Zhu, TaoX ; > > Yigit, Ferruh > > Cc: dev@dpdk.org; Ananyev, Konstantin ; > > Lu, Wenzhuo ; stable@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix blocking system events > > > > 17/02/2020 14:01, Ferruh Yigit: > > > On 2/15/2020 3:41 PM, Ye Xiaolong wrote: > > > > On 01/15, taox.zhu@intel.com wrote: > > > >> From: Zhu Tao > > > >> > > > >> IXGBE link status task use rte alarm thread in old implementation. > > > > > > > > s/use/uses > > > > > > > >> Sometime ixgbe link status task takes up to 9 seconds. This will > > > >> severely affect the rte-alarm-thread-dependent a task in the > > > >> system, like interrupt or hotplug event. So replace with a > > > > > > > > s/a/an > > > > > > > >> independent thread which has the same thread affinity settings as > > > >> rte interrupt. > > > >> > > > >> Fixes: 0408f47b ("net/ixgbe: fix busy polling while fiber link > > > >> update") > > > > > > > > Should be: > > > > > > > > Fixes: 0408f47ba4d6 ("net/ixgbe: fix busy polling while fiber link > > > > update") > > > > > > > >> Cc: stable@dpdk.org > > > >> > > > > > > > > Applied to dpdk-next-net-intel with Konstantin's ack, Thanks. > > > > > > > > > > Shared build is failing because of missing pthread library, fixing > > > while merging to next-net: > > > > One more thing looks strange in this patch: > > ixgbe_dev_cannel_link_thread > > Should it be > > ixgbe_dev_cancel_link_thread > > ? > > > > Note: I looked at it because I am not sure multiplying the interrupt threads is > > a good idea. > > Basically the link status management is too long in this driver. > > Instead of fixing the root cause, you move the annoying workload > > somewhere else. But it is still there... > > > > Please could you work on a long term fix? > > > >