DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>,
	dev@dpdk.org
Cc: anatoly.burakov@intel.com, bluca@debian.org, thomas@monjalon.net,
	david.marchand@redhat.com
Subject: Re: [dpdk-dev] [PATCH DPDK_KMODS v7 1/2] linux/igb_uio: remove DPDK dependency for building igb_uio
Date: Fri, 30 Oct 2020 10:04:49 +0000
Message-ID: <124ce125-7207-247b-475b-cab1650337ca@intel.com> (raw)
In-Reply-To: <1604013442-44841-1-git-send-email-hariprasad.govindharajan@intel.com>

On 10/29/2020 11:17 PM, Hariprasad Govindharajan wrote:
> The igb_uio source code requires interrupt modes defined as
> MACROS and enums in the header file rte_pci_dev_features.h.
> Now, the definitions are moved to the igb_uio.c file so that
> this module can be built without building DPDK
> 
> Signed-off-by: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>
> ---
>   linux/igb_uio/igb_uio.c | 22 ++++++++++++++++++----
>   1 file changed, 18 insertions(+), 4 deletions(-)
> 
> diff --git a/linux/igb_uio/igb_uio.c b/linux/igb_uio/igb_uio.c
> index 3cf394b..7ef8170 100644
> --- a/linux/igb_uio/igb_uio.c
> +++ b/linux/igb_uio/igb_uio.c
> @@ -15,7 +15,21 @@
>   #include <linux/version.h>
>   #include <linux/slab.h>
>   
> -#include <rte_pci_dev_features.h>
> +/**
> + * This enums and macro definitions are copied from the
> + * file rte_pci_dev_features.h
> + */
> +enum rte_intr_mode {
> +	RTE_INTR_MODE_NONE = 0,
> +	RTE_INTR_MODE_LEGACY,
> +	RTE_INTR_MODE_MSI,
> +	RTE_INTR_MODE_MSIX
> +};
> +#define RTE_INTR_MODE_NONE_NAME "none"
> +#define RTE_INTR_MODE_LEGACY_NAME "legacy"
> +#define RTE_INTR_MODE_MSI_NAME "msi"
> +#define RTE_INTR_MODE_MSIX_NAME "msix"
> +
>   
>   #include "compat.h"
>   
> @@ -236,7 +250,7 @@ igbuio_pci_enable_interrupts(struct rte_uio_pci_dev *udev)
>   		}
>   #endif
>   
> -	/* fall back to MSI */
> +	/* falls through - to MSI */

Patch looks good, but above change is unrelated, let's not mix them, can you 
make a new version without these corrections?

  parent reply	other threads:[~2020-10-30 10:05 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-05 14:47 [dpdk-dev] [PATCH] linux/igb_uio: add Makefile to build the kernel module Hariprasad Govindharajan
2020-10-05 15:12 ` Ferruh Yigit
2020-10-05 16:18 ` [dpdk-dev] [PATCH v2] " Hariprasad Govindharajan
2020-10-05 16:26   ` Ferruh Yigit
2020-10-05 18:27   ` Stephen Hemminger
2020-10-05 17:55 ` [dpdk-dev] [DPDK_KMODS v3] " Hariprasad Govindharajan
2020-10-05 17:57 ` Hariprasad Govindharajan
2020-10-06  9:02   ` Ferruh Yigit
2020-10-07 12:50   ` Burakov, Anatoly
2020-10-08  9:40 ` [dpdk-dev] [DPDK_KMODS v4] " Hariprasad Govindharajan
2020-10-08  9:43   ` Burakov, Anatoly
2020-10-19 18:07     ` Ajit Khaparde
2020-10-21 11:37       ` Kalesh Anakkur Purayil
2020-10-10  1:30   ` Ma, LihongX
2020-10-28 21:09   ` Narcisa Ana Maria Vasile
2020-10-29 10:16   ` Luca Boccassi
2020-10-29 18:42     ` Govindharajan, Hariprasad
2020-10-29 19:16 ` [dpdk-dev] [DPDK_KMODS v5] " Hariprasad Govindharajan
2020-10-29 19:31   ` Ferruh Yigit
2020-10-29 21:11   ` Thomas Monjalon
2020-10-29 20:10 ` [dpdk-dev] [prefix=DPDK_KMODS v6 1/2] linux/igb_uio: remove DPDK dependency for building igb_uio Hariprasad Govindharajan
2020-10-29 20:10   ` [dpdk-dev] [prefix=DPDK_KMODS v6 2/2] linux/igb_uio: add Makefile to build the igb_uio module Hariprasad Govindharajan
2020-10-29 20:17     ` Ferruh Yigit
2020-10-29 21:16     ` Thomas Monjalon
2020-10-29 20:17   ` [dpdk-dev] [prefix=DPDK_KMODS v6 1/2] linux/igb_uio: remove DPDK dependency for building igb_uio Ferruh Yigit
2020-10-29 21:14   ` Thomas Monjalon
2020-10-30 10:10     ` Thomas Monjalon
2020-10-29 21:28   ` David Marchand
2020-10-29 21:42     ` Thomas Monjalon
2020-10-29 23:17 ` [dpdk-dev] [PATCH DPDK_KMODS v7 " Hariprasad Govindharajan
2020-10-29 23:17   ` [dpdk-dev] [PATCH DPDK_KMODS v7 2/2] linux/igb_uio: add Makefile to build the igb_uio module Hariprasad Govindharajan
2020-10-30 10:04   ` Ferruh Yigit [this message]
2020-10-30 10:52 ` [dpdk-dev] [PATCH dpdk-kmods v8 1/2] linux/igb_uio: remove DPDK dependency for building igb_uio Hariprasad Govindharajan
2020-10-30 10:52   ` [dpdk-dev] [PATCH dpdk-kmods v8 2/2] linux/igb_uio: add Makefile to build the igb_uio module Hariprasad Govindharajan
2020-10-30 11:03   ` [dpdk-dev] [PATCH dpdk-kmods v8 1/2] linux/igb_uio: remove DPDK dependency for building igb_uio Ferruh Yigit
2020-10-30 11:28     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=124ce125-7207-247b-475b-cab1650337ca@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=bluca@debian.org \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=hariprasad.govindharajan@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git