From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 649A6A04DF;
Fri, 30 Oct 2020 11:05:01 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id BAE93C85E;
Fri, 30 Oct 2020 11:04:58 +0100 (CET)
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
by dpdk.org (Postfix) with ESMTP id A11E9C826
for <dev@dpdk.org>; Fri, 30 Oct 2020 11:04:56 +0100 (CET)
IronPort-SDR: cM9xCZBLzLqOE7UH9vTiEDIJA1zEuJ3H2++TRyfHyGR4cnyV7JZHSak2S4KlZMi9Xl8pSE6EBF
FyluBldSgDGg==
X-IronPort-AV: E=McAfee;i="6000,8403,9789"; a="232765052"
X-IronPort-AV: E=Sophos;i="5.77,432,1596524400"; d="scan'208";a="232765052"
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga005.jf.intel.com ([10.7.209.41])
by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
30 Oct 2020 03:04:54 -0700
IronPort-SDR: JUk7wMVKCOF1UMv50WqE2O393RCCFlBzi9dOy3eBh+tMqwDakJIUubAAsnh30GuLYVcs79XBct
3W8gQ9J+NQKA==
X-IronPort-AV: E=Sophos;i="5.77,432,1596524400"; d="scan'208";a="537014304"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.23.197])
([10.252.23.197])
by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
30 Oct 2020 03:04:52 -0700
To: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>, dev@dpdk.org
Cc: anatoly.burakov@intel.com, bluca@debian.org, thomas@monjalon.net,
david.marchand@redhat.com
References: <1601909255-26251-1-git-send-email-hariprasad.govindharajan@intel.com>
<1604013442-44841-1-git-send-email-hariprasad.govindharajan@intel.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <124ce125-7207-247b-475b-cab1650337ca@intel.com>
Date: Fri, 30 Oct 2020 10:04:49 +0000
MIME-Version: 1.0
In-Reply-To: <1604013442-44841-1-git-send-email-hariprasad.govindharajan@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH DPDK_KMODS v7 1/2] linux/igb_uio: remove DPDK
dependency for building igb_uio
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On 10/29/2020 11:17 PM, Hariprasad Govindharajan wrote:
> The igb_uio source code requires interrupt modes defined as
> MACROS and enums in the header file rte_pci_dev_features.h.
> Now, the definitions are moved to the igb_uio.c file so that
> this module can be built without building DPDK
>
> Signed-off-by: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>
> ---
> linux/igb_uio/igb_uio.c | 22 ++++++++++++++++++----
> 1 file changed, 18 insertions(+), 4 deletions(-)
>
> diff --git a/linux/igb_uio/igb_uio.c b/linux/igb_uio/igb_uio.c
> index 3cf394b..7ef8170 100644
> --- a/linux/igb_uio/igb_uio.c
> +++ b/linux/igb_uio/igb_uio.c
> @@ -15,7 +15,21 @@
> #include <linux/version.h>
> #include <linux/slab.h>
>
> -#include <rte_pci_dev_features.h>
> +/**
> + * This enums and macro definitions are copied from the
> + * file rte_pci_dev_features.h
> + */
> +enum rte_intr_mode {
> + RTE_INTR_MODE_NONE = 0,
> + RTE_INTR_MODE_LEGACY,
> + RTE_INTR_MODE_MSI,
> + RTE_INTR_MODE_MSIX
> +};
> +#define RTE_INTR_MODE_NONE_NAME "none"
> +#define RTE_INTR_MODE_LEGACY_NAME "legacy"
> +#define RTE_INTR_MODE_MSI_NAME "msi"
> +#define RTE_INTR_MODE_MSIX_NAME "msix"
> +
>
> #include "compat.h"
>
> @@ -236,7 +250,7 @@ igbuio_pci_enable_interrupts(struct rte_uio_pci_dev *udev)
> }
> #endif
>
> - /* fall back to MSI */
> + /* falls through - to MSI */
Patch looks good, but above change is unrelated, let's not mix them, can you
make a new version without these corrections?