From: Thomas Monjalon <thomas@monjalon.net>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: dev@dpdk.org, david.hunt@intel.com, mb@smartsharesystems.com,
"Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3] eal, power: use UINT64_MAX and UINT32_MAX
Date: Mon, 19 Apr 2021 11:43:41 +0200 [thread overview]
Message-ID: <12551751.tWxWN4dHVb@thomas> (raw)
In-Reply-To: <eda88d53-d50d-e215-4181-758b74a6ff40@intel.com>
01/04/2021 13:22, Burakov, Anatoly:
> On 16-Mar-21 12:13 AM, Tyler Retzlaff wrote:
> > Use UINT64_MAX and UINT32_MAX instead of -1 or ~0 literal variations
> > of different explicit widths when creating masks and sentinel values.
> >
> > some compilers generate a warning when applying a '-' to an unsigned
> > literal so avoid this by initializing with unsigned preprocessor
> > definitions where appropriate.
> >
> > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
>
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
Split in 2 patches (EAL and power) and applied, thanks.
There are other occurences to remove:
git grep -l -- '-1U'
app/test-eventdev/test_perf_common.c
app/test-eventdev/test_pipeline_common.c
drivers/net/bnxt/tf_ulp/ulp_flow_db.c
drivers/net/bnxt/tf_ulp/ulp_rte_parser.h
drivers/net/mlx5/mlx5_rxtx_vec_neon.h
I think we should add a checkpatch test
to avoid inserting more occurences in future.
Tyler, please could you work on it?
prev parent reply other threads:[~2021-04-19 9:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 23:44 [dpdk-dev] [PATCH] eal, power: don't use '-' sign with unsigned literals Tyler Retzlaff
2021-03-12 12:51 ` Burakov, Anatoly
2021-03-12 17:05 ` Tyler Retzlaff
2021-03-12 17:37 ` Bruce Richardson
2021-03-12 18:36 ` Tyler Retzlaff
2021-03-12 18:40 ` Tyler Retzlaff
2021-03-13 9:05 ` Morten Brørup
2021-03-15 15:36 ` [dpdk-dev] [PATCH v2] eal, power: use UINT64_MAX instead of -1ULL Tyler Retzlaff
2021-03-16 0:13 ` [dpdk-dev] [PATCH v3] eal, power: use UINT64_MAX and UINT32_MAX Tyler Retzlaff
2021-03-16 11:06 ` Morten Brørup
2021-04-01 11:22 ` Burakov, Anatoly
2021-04-19 9:43 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12551751.tWxWN4dHVb@thomas \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=mb@smartsharesystems.com \
--cc=roretzla@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).