From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A0478A0524; Mon, 19 Apr 2021 11:43:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1D30B40683; Mon, 19 Apr 2021 11:43:47 +0200 (CEST) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id 5C48F40040 for ; Mon, 19 Apr 2021 11:43:46 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id EAE221738; Mon, 19 Apr 2021 05:43:44 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 19 Apr 2021 05:43:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 0afG4dpgX92RQFO7gwDCCmRjlYs+nZY7sUfL4A7vlyQ=; b=MoGQWvlm/bs2vGZU Eg1FB2dvaCRm7DiNH4b0heJEu5vmHB4lVJ21fC1QohPr0wgG9BBlGokjAdqaC6B7 nxk3cp+SlgoN8YbzLc1WnPQcMsYSMcqN+qfQ2VEAPL9PTZtdHEnFFM0D/Rd8IuBH cR9dCIerQ7mr0yhjPqlBOH5d0D1AlPBku3YLZsFLT5gOThMxtU333FOkwBSst+yh ePCOVlovm0fd28yc9qGxRX7hKki6SyMtM8uniOzS+cllvZjVtw++e1XxnLknT9XP 5pHLw9ZYWhgMIi+17GSbNwlSFZrkJTWSudIXEVJUrIN9ePXSohjOXGp9T2sE0E+H fJM1XA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=0afG4dpgX92RQFO7gwDCCmRjlYs+nZY7sUfL4A7vl yQ=; b=rhn8wGPDirkJw+iBjn3qAHoQ/r9PGdN2+CM5zvxNxL6N5rQ0r9OAix07o z6KqHhiOylSrkXlZr3HpnMI3H4bdN3jzkY+wU1h+u0RyWHEnYTRSA5jswn/J256j uMZOkwqa5Z6XZ++MQG1Ni9yOMhHSaCKS8PRSWEMEgiVsvybV1OMRKQviTRpIrqUG MgNMNhVlAaVCjqWor61tIVFDiGYuuOvipYu0Ugu8CEIK9vj/MkWCXrGCC4wnLnRP eQ6mrmnKpNR73aPP4uAu8JWMgXxA8DW35aWWFHlv2sr+sGvIA7KdWhJQYLoyCvkI ZCMXZSV9ha2lRTX0WQbw7i584dQcg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddtgedgudelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D5472108005B; Mon, 19 Apr 2021 05:43:42 -0400 (EDT) From: Thomas Monjalon To: Tyler Retzlaff Cc: dev@dpdk.org, david.hunt@intel.com, mb@smartsharesystems.com, "Burakov, Anatoly" Date: Mon, 19 Apr 2021 11:43:41 +0200 Message-ID: <12551751.tWxWN4dHVb@thomas> In-Reply-To: References: <1615333490-15243-1-git-send-email-roretzla@linux.microsoft.com> <1615853611-7253-1-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] eal, power: use UINT64_MAX and UINT32_MAX X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 01/04/2021 13:22, Burakov, Anatoly: > On 16-Mar-21 12:13 AM, Tyler Retzlaff wrote: > > Use UINT64_MAX and UINT32_MAX instead of -1 or ~0 literal variations > > of different explicit widths when creating masks and sentinel values. > > > > some compilers generate a warning when applying a '-' to an unsigned > > literal so avoid this by initializing with unsigned preprocessor > > definitions where appropriate. > > > > Signed-off-by: Tyler Retzlaff > > Acked-by: Anatoly Burakov Split in 2 patches (EAL and power) and applied, thanks. There are other occurences to remove: git grep -l -- '-1U' app/test-eventdev/test_perf_common.c app/test-eventdev/test_pipeline_common.c drivers/net/bnxt/tf_ulp/ulp_flow_db.c drivers/net/bnxt/tf_ulp/ulp_rte_parser.h drivers/net/mlx5/mlx5_rxtx_vec_neon.h I think we should add a checkpatch test to avoid inserting more occurences in future. Tyler, please could you work on it?