From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 2B3AC1B756 for ; Fri, 13 Oct 2017 23:11:56 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id AC26121196; Fri, 13 Oct 2017 17:11:55 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Fri, 13 Oct 2017 17:11:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=0xLXKhFgc0R/SFYB3LZaTSgQRw ddv8v6h87NvJEHjXQ=; b=Y132Brd/VKRd8n4l23djHkNXcmvLg7yXbArevJK1C9 KDvsco9K3bZeVhhbZkKX1j90wVozMkyaqEr6IUrw5LOsjfEXLCuQIA2tf1XkOifZ a3mOwQz8lMO4dQBj5ZCwCFmpuwVupdke/ZcJK1t2PEDwV+eiagY7UqykagGlMHME U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=0xLXKh Fgc0R/SFYB3LZaTSgQRwddv8v6h87NvJEHjXQ=; b=I99leho/gaOsbCoPL1jtiA A+Sa+WHVanJi3EurNWWq9C75V82zQicpIZ9HrBgQp36X2+uwN2VIV0IL/lzhqvzP BSvQ/0P9QM8x99AlNt5XHkFuxaXEp5B15TjG6ufhZjS20mVHghDQjyxph5EG8I9m +ZITRii0byZgEj9vzNs55lYHi2B68qMGofowKi++HmN0+Ew9wfIw8vjr0tpEzn4P Anl3j1AXQGFRF4/4hQ0OJZS2cHQg9Qqp7mXo4RC7lLm1gWLhAiETJX/xnpkmkAqh cSlFkzugeB/91TpKa0BNgDyGQqkwo6uEV2weHam7H2sIFNXS8kZQ6UVN3BunXJsA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5485D7E954; Fri, 13 Oct 2017 17:11:55 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, shijith.thotton@caviumnetworks.com, qiming.yang@intel.com, jingjing.wu@intel.com, luca.boccassi@att.com, gregory@weka.io, helin.zhang@intel.com, xuekun.hu@intel.com, harish.patil@cavium.com Date: Fri, 13 Oct 2017 23:11:54 +0200 Message-ID: <12571807.rgXucML5gE@xps> In-Reply-To: <11d7e3d2-a30c-cdc1-7609-c70aafde5aed@intel.com> References: <20171013145104.17596-1-thomas@monjalon.net> <11d7e3d2-a30c-cdc1-7609-c70aafde5aed@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] igb_uio: revert open and release operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Oct 2017 21:11:56 -0000 13/10/2017 23:05, Ferruh Yigit: > On 10/13/2017 3:51 PM, Thomas Monjalon wrote: > > Some VF drivers cannot work with igb_uio because of the > > reset done in these functions. > > > > First bug report: > > http://dpdk.org/ml/archives/dev/2017-September/075236.html > > > > A partial reset was tried: > > http://dpdk.org/patch/28940 > > > > Second bug report after a partial revert trial: > > http://dpdk.org/ml/archives/dev/2017-September/076998.html > > > > The patch author agreed to revert his patch: > > http://dpdk.org/ml/archives/dev/2017-October/077158.html > > > > There are also some patches available to fix issues with i40e: > > http://dpdk.org/patch/30021 > > http://dpdk.org/patch/30022 > > > > This patch takes the simple option of reverting the initial patch > > and gives more time to properly improve igb_uio and PMDs. > > > > Fixes: b58eedfc7dd5 ("igb_uio: issue FLR during open and release of device file") > > > > Reported-by: Qiming Yang > > Reported-by: Jingjing Wu > > Signed-off-by: Thomas Monjalon > > Hi Thomas, > > I put already some comment into other fix patch [1]. > > Mainly taking into account of current time for release, this patch make > sense, but I suggest giving a chance to the fix mentioned above. > > Because the original patch is for safer igb_uio, and fixing a few times > reported issue. > > Since this is rc1, we have time for testing, and many parties will be > doing tests. Lets get the fix for rc1, and if we find any issue revert > the patch? OK, please check it works for every VF drivers. There was an issue reported with bnxt.