From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) by dpdk.org (Postfix) with ESMTP id B2F63593A for ; Thu, 22 May 2014 17:20:44 +0200 (CEST) Received: by mail-wi0-f179.google.com with SMTP id bs8so4513341wib.0 for ; Thu, 22 May 2014 08:20:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=DpL2Iw+1QuXEFR+RY9WxRPEEPwqVfA5Zav92a20PYYA=; b=WcLjs+PXvD8gnRekrbVWl7Rent8itA8+J6504pr6PsEQ1SrsVCIgtUKJRTlddSGr8s vRpwgtnfVGzrzlqp7psmHn2kdGa+UmTmko80FrujJ2+QwpYcPvtf2WFGHoJFI+RbaAfU zn3fAxgbNNk6ofw26MdxM3tYylquAdu02Pkh9bVd/ElFh89Tg1/Gc+93NU84g1wCuU9l m1A8UGnoRVS2IzkMhKmyDVzTRHmLhiLIAvuNi2K497HbO8ETLqIRrmHLtlqZcJy/0Fsl gTk9Z2SO4JmV4B7mYehRvibLelwcrrj7zc02WIy08/CDvpg7tumOZyMYdWjXo1OP0Jx5 Vrbw== X-Gm-Message-State: ALoCoQlnfH3dtMNlwl+0p/HfBda6hbfIotvrfdv+sKDjyJuo2xQGxs4xd55zOS+cvWtKzMuIAfzP X-Received: by 10.194.188.68 with SMTP id fy4mr50481674wjc.30.1400772054274; Thu, 22 May 2014 08:20:54 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id dh1sm148292wjc.25.2014.05.22.08.20.52 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 May 2014 08:20:53 -0700 (PDT) From: Thomas Monjalon To: Jijiang Liu Date: Thu, 22 May 2014 17:20:49 +0200 Message-ID: <12620475.JcSW442DzY@xps13> Organization: 6WIND User-Agent: KMail/4.13 (Linux/3.14.4-1-ARCH; KDE/4.13.0; x86_64; ; ) In-Reply-To: <1400569085-22244-1-git-send-email-jijiang.liu@intel.com> References: <1400569085-22244-1-git-send-email-jijiang.liu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH][Dom0 driver]Change the way of reserving memory in Dom0 driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 May 2014 15:20:45 -0000 Hi Jijiang, Some cosmetic comments: Referring to previous patch about Xen Dom0, prefix "xen:" should be used in commit title. So it should be something like that: xen: reserve memory at init Maybe it could need to be splitted in 2 patches. So the other one would be: xen: reduce number of memory segments After running checkpatch.pl on this patch, it reports many errors. Please, could you run it and do the required fix? see http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/scripts/checkpatch.pl Thanks -- Thomas