From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f49.google.com (mail-wg0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id E226E5A70 for ; Tue, 20 Jan 2015 09:02:03 +0100 (CET) Received: by mail-wg0-f49.google.com with SMTP id l18so10071514wgh.8 for ; Tue, 20 Jan 2015 00:02:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=zaI/fmqO6Ab05LVjoqIb8b7lam5vh9LaEOPBnIyDZ0o=; b=Xz3r2erGrodfRa6sVbECsuHMwzUFV399HJpBDO4yTffAPWZ4mAtyrFA/veGhuhMAA9 jcE3IEvIkxAAR+KWhn0hs0Tj+g0Lch7lgoi3FwMqlKPk4T7gBFuZZvdKpflZNY+8d7pC PPQ9OTo7QrEBmCssBWqChp97DnEYTuGC0Q2vpfie7dRS1pLk4cQjP+43MiFLXG0iNujo 3jW/o/JmFtQMxBsJobchp5/o/ZZzeovReCrA1eHdJb+ZKh4/LfZm/KbSdLPWJdRh1jk/ hE9yUmkgrOOiXN2hwlkpSZCIPEd79um/lTnzJGtuFmgbnMBEXlvOuUT7fRDeoUNwamAU Lbig== X-Gm-Message-State: ALoCoQn440bfb2yMiLAJWbnYloKn7mHBfjKyEPnTreXvq7v5ktF/SMWLdkFnVAlgBIYeK7PKnkza X-Received: by 10.180.103.6 with SMTP id fs6mr43162628wib.11.1421740923823; Tue, 20 Jan 2015 00:02:03 -0800 (PST) Received: from xps13.localnet (111.26.90.92.rev.sfr.net. [92.90.26.111]) by mx.google.com with ESMTPSA id u13sm20187140wjr.26.2015.01.20.00.02.01 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Jan 2015 00:02:03 -0800 (PST) From: Thomas Monjalon To: Pawel Wodkowski Date: Tue, 20 Jan 2015 07:52:53 +0100 Message-ID: <12809037.rKu6KU9Ov5@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.6-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <1421672551-11652-4-git-send-email-pawelx.wodkowski@intel.com> References: <1421077843-8492-1-git-send-email-michalx.k.jastrzebski@intel.com> <1421672551-11652-1-git-send-email-pawelx.wodkowski@intel.com> <1421672551-11652-4-git-send-email-pawelx.wodkowski@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 3/4] pmd: add support for DCB in SRIOV mode for ixgbe driver. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jan 2015 08:02:04 -0000 2015-01-19 14:02, Pawel Wodkowski: > Add support for DCB in SRIOV mode. When no PFC is enabled this feature > might be used as multiple queues for VF (up to 8 queues if VFs num is > less or equal 16 or 4 if FVs num is less or equal 32). > > The PF must initializes RX in ETH_MQ_RX_VMDQ_DCB and TX in > ETH_MQ_TX_VMDQ_DCB. > VF should initialize Rx in ETH_MQ_RX_DCB and Tx in ETH_MQ_TX_DCB to use > multiple queues and/or DCB. > > Signed-off-by: Pawel Wodkowski [...] > --- a/lib/librte_pmd_ixgbe/ixgbe_pf.c > +++ b/lib/librte_pmd_ixgbe/ixgbe_pf.c > @@ -231,19 +231,19 @@ int ixgbe_pf_host_configure(struct rte_eth_dev *eth_dev) > } > > IXGBE_WRITE_REG(hw, IXGBE_GCR_EXT, gcr_ext); > - IXGBE_WRITE_REG(hw, IXGBE_GPIE, gpie); > + IXGBE_WRITE_REG(hw, IXGBE_GPIE, gpie); > > - /* > + /* > * enable vlan filtering and allow all vlan tags through > */ > - vlanctrl = IXGBE_READ_REG(hw, IXGBE_VLNCTRL); > - vlanctrl |= IXGBE_VLNCTRL_VFE ; /* enable vlan filters */ > - IXGBE_WRITE_REG(hw, IXGBE_VLNCTRL, vlanctrl); > + vlanctrl = IXGBE_READ_REG(hw, IXGBE_VLNCTRL); > + vlanctrl |= IXGBE_VLNCTRL_VFE ; /* enable vlan filters */ > + IXGBE_WRITE_REG(hw, IXGBE_VLNCTRL, vlanctrl); > > - /* VFTA - enable all vlan filters */ > - for (i = 0; i < IXGBE_MAX_VFTA; i++) { > - IXGBE_WRITE_REG(hw, IXGBE_VFTA(i), 0xFFFFFFFF); > - } > + /* VFTA - enable all vlan filters */ > + for (i = 0; i < IXGBE_MAX_VFTA; i++) { > + IXGBE_WRITE_REG(hw, IXGBE_VFTA(i), 0xFFFFFFFF); > + } Please do not mix indent formatting with "real changes". When looking for history of these lines, it would be difficult to understand that this patch don't make real change. Having a dedicated cleanup commit is better. Thanks -- Thomas