DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Bernard Iremonger <bernard.iremonger@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v8 03/11] vdev: copy device info to eth_dev data
Date: Tue, 03 Nov 2015 18:17:32 +0100	[thread overview]
Message-ID: <12812838.dX1On1osOA@xps13> (raw)
In-Reply-To: <1446555725-19540-4-git-send-email-bernard.iremonger@intel.com>

Below, a lot of pci values are removed and break the build.
Will move in later patches.

2015-11-03 13:01, Bernard Iremonger:
> @@ -674,7 +674,11 @@ rte_pmd_init_internals(const char *name,
>  
>  	(*eth_dev)->data = data;
>  	(*eth_dev)->dev_ops = &ops;
> -	(*eth_dev)->pci_dev = pci_dev;
> +	(*eth_dev)->driver = NULL;
> +	(*eth_dev)->data->dev_flags = 0;
> +	(*eth_dev)->data->drv_name = drivername;
> +	(*eth_dev)->data->kdrv = RTE_KDRV_NONE;
> +	(*eth_dev)->data->numa_node = numa_node;

> @@ -571,10 +571,15 @@ eth_dev_null_create(const char *name,
>  
>  	eth_dev->data = data;
>  	eth_dev->dev_ops = &ops;
> -	eth_dev->pci_dev = pci_dev;
> -	eth_dev->driver = &rte_null_pmd;
> +
>  	TAILQ_INIT(&eth_dev->link_intr_cbs);

> @@ -874,8 +874,11 @@ rte_pmd_init_internals(const char *name, const unsigned nb_rx_queues,
>  
>  	(*eth_dev)->data = data;
>  	(*eth_dev)->dev_ops = &ops;
> -	(*eth_dev)->pci_dev = pci_dev;
> -	(*eth_dev)->driver = &rte_pcap_pmd;
> +	(*eth_dev)->data->dev_flags = RTE_ETH_DEV_DETACHABLE;
> +	(*eth_dev)->driver = NULL;
> +	(*eth_dev)->data->kdrv = RTE_KDRV_NONE;
> +	(*eth_dev)->data->drv_name = drivername;
> +	(*eth_dev)->data->numa_node = numa_node;
>  
>  	return 0;

> @@ -338,9 +337,13 @@ rte_eth_from_rings(const char *name, struct rte_ring *const rx_queues[],
>  	data->mac_addrs = &internals->address;
>  
>  	eth_dev->data = data;
> -	eth_dev->driver = &rte_ring_pmd;
> +	eth_dev->driver = NULL;
>  	eth_dev->dev_ops = &ops;
> -	eth_dev->pci_dev = pci_dev;
> +	eth_dev->data->dev_flags = RTE_ETH_DEV_DETACHABLE;
> +	eth_dev->data->kdrv = RTE_KDRV_NONE;
> +	eth_dev->data->drv_name = drivername;
> +	eth_dev->data->numa_node = numa_node;
> +
>  	TAILQ_INIT(&(eth_dev->link_intr_cbs));
>  

> @@ -688,8 +688,12 @@ eth_dev_xenvirt_create(const char *name, const char *params,
>  
>  	eth_dev->data = data;
>  	eth_dev->dev_ops = &ops;
> +
>  	eth_dev->data->dev_flags = RTE_PCI_DRV_DETACHABLE;
> -	eth_dev->pci_dev = pci_dev;
> +	eth_dev->data->kdrv = RTE_KDRV_NONE;
> +	eth_dev->data->drv_name = drivername;
> +	eth_dev->driver = NULL;
> +	eth_dev->data->numa_node = numa_node;
>  
>  	eth_dev->rx_pkt_burst = eth_xenvirt_rx;
>  	eth_dev->tx_pkt_burst = eth_xenvirt_tx;
> 

  reply	other threads:[~2015-11-03 17:18 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <PATCH v8>
2015-11-03 13:01 ` [dpdk-dev] [PATCH v8 00/11] remove pci driver from vdevs Bernard Iremonger
2015-11-03 13:01   ` [dpdk-dev] [PATCH v8 01/11] librte_ether: add fields from rte_pci_driver to rte_eth_dev_data Bernard Iremonger
2015-11-03 16:31     ` Thomas Monjalon
2015-11-03 13:01   ` [dpdk-dev] [PATCH v8 02/11] pdev: copy pci device info to eth_dev data Bernard Iremonger
2015-11-03 13:01   ` [dpdk-dev] [PATCH v8 03/11] vdev: copy " Bernard Iremonger
2015-11-03 17:17     ` Thomas Monjalon [this message]
2015-11-03 13:01   ` [dpdk-dev] [PATCH v8 04/11] librte_ether: remove branches on pci_dev Bernard Iremonger
2015-11-03 13:01   ` [dpdk-dev] [PATCH v8 05/11] null: remove pci device Bernard Iremonger
2015-11-03 13:02   ` [dpdk-dev] [PATCH v8 06/11] ring: " Bernard Iremonger
2015-11-03 13:02   ` [dpdk-dev] [PATCH v8 07/11] pcap: " Bernard Iremonger
2015-11-03 13:02   ` [dpdk-dev] [PATCH v8 08/11] af_packet: " Bernard Iremonger
2015-11-03 13:02   ` [dpdk-dev] [PATCH v8 09/11] xenvirt: " Bernard Iremonger
2015-11-03 13:02   ` [dpdk-dev] [PATCH v8 10/11] mpipe: " Bernard Iremonger
2015-11-03 13:02   ` [dpdk-dev] [PATCH v8 11/11] bonding: " Bernard Iremonger
2015-11-03 17:50   ` [dpdk-dev] [PATCH v8 00/11] remove pci driver from vdevs Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12812838.dX1On1osOA@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=bernard.iremonger@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).