From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com [209.85.212.170]) by dpdk.org (Postfix) with ESMTP id 0559A8E88 for ; Tue, 3 Nov 2015 18:18:45 +0100 (CET) Received: by wicll6 with SMTP id ll6so74191280wic.0 for ; Tue, 03 Nov 2015 09:18:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind_com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=CgvLTw41/S9alrFJa5e4TqN4QGsGmEj2CechZAbY+DU=; b=QtEgYnMneYRZOccjb8b3ZtXpGvSF2a7g9fZXgs4GIiE2eGCVPddLn85mhmsehx6HHT Hgqaeo8I3KkZIwAVXOcNvRnugjqop+q324Srb/8Wv96YInPPCnTL/+qbZ/qntgAFQCfA 5H42KLMPoIB/0IaU9J5QvyCKi133P/0nwamTipZbzSKmqo0H1G/ZKpM/D2z1OLB9okP8 XOWrED2z3FNYMSMcyVlc1GSfb4ql43o58RGC651JE49KQ2S5pHIYRt50NGXYPmGcL8LW 7WxGAPOpZWKHX+xK9ygQ2EyAKTTMq0MBMoOyLlQ00Pfil9OyUosls6szpc686k11FhA7 kSdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=CgvLTw41/S9alrFJa5e4TqN4QGsGmEj2CechZAbY+DU=; b=UJdcKgkq+NNz6srbnxtn+U86oMyx4zmbkswoaz2VHRtQxJrzcqjuKSI5y6WcAV5D+y 5M0AMv1h4SalICko9eJj6KkPBgDwjPZRzMctXrAhf6OEk2yWCw4Gvu6CG8jF+zIUBYwo xoqo+f1/KJFYRKrI0WYnRrz56vs5aDrkzct9TJOxUDQLNL2yqM7/2qcZrU0YSfgwsvpy iWnXppCN2ZNdHBXWy04pJ3objGsvRdjWiv9IRukkusuNhaqMSRL0XA/16AhvcQFglO8d xrnXLmcOFT3jpxjY1cDrXPWH4jR0n8j0dLe0dFyknHBN8FsXM+l89NPbPymDvU4IeYAr emEg== X-Gm-Message-State: ALoCoQnUgC8Ay21EVZY1l9mC9N23a2qyoUFE3Q2JpmYx291Gdfo9AGCUmuXhGExHtJgqCpQWBu1P X-Received: by 10.194.19.134 with SMTP id f6mr30621253wje.133.1446571124844; Tue, 03 Nov 2015 09:18:44 -0800 (PST) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id u126sm24379201wmd.3.2015.11.03.09.18.43 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Nov 2015 09:18:44 -0800 (PST) From: Thomas Monjalon To: Bernard Iremonger Date: Tue, 03 Nov 2015 18:17:32 +0100 Message-ID: <12812838.dX1On1osOA@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1446555725-19540-4-git-send-email-bernard.iremonger@intel.com> References: <1446555725-19540-4-git-send-email-bernard.iremonger@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v8 03/11] vdev: copy device info to eth_dev data X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Nov 2015 17:18:45 -0000 Below, a lot of pci values are removed and break the build. Will move in later patches. 2015-11-03 13:01, Bernard Iremonger: > @@ -674,7 +674,11 @@ rte_pmd_init_internals(const char *name, > > (*eth_dev)->data = data; > (*eth_dev)->dev_ops = &ops; > - (*eth_dev)->pci_dev = pci_dev; > + (*eth_dev)->driver = NULL; > + (*eth_dev)->data->dev_flags = 0; > + (*eth_dev)->data->drv_name = drivername; > + (*eth_dev)->data->kdrv = RTE_KDRV_NONE; > + (*eth_dev)->data->numa_node = numa_node; > @@ -571,10 +571,15 @@ eth_dev_null_create(const char *name, > > eth_dev->data = data; > eth_dev->dev_ops = &ops; > - eth_dev->pci_dev = pci_dev; > - eth_dev->driver = &rte_null_pmd; > + > TAILQ_INIT(ð_dev->link_intr_cbs); > @@ -874,8 +874,11 @@ rte_pmd_init_internals(const char *name, const unsigned nb_rx_queues, > > (*eth_dev)->data = data; > (*eth_dev)->dev_ops = &ops; > - (*eth_dev)->pci_dev = pci_dev; > - (*eth_dev)->driver = &rte_pcap_pmd; > + (*eth_dev)->data->dev_flags = RTE_ETH_DEV_DETACHABLE; > + (*eth_dev)->driver = NULL; > + (*eth_dev)->data->kdrv = RTE_KDRV_NONE; > + (*eth_dev)->data->drv_name = drivername; > + (*eth_dev)->data->numa_node = numa_node; > > return 0; > @@ -338,9 +337,13 @@ rte_eth_from_rings(const char *name, struct rte_ring *const rx_queues[], > data->mac_addrs = &internals->address; > > eth_dev->data = data; > - eth_dev->driver = &rte_ring_pmd; > + eth_dev->driver = NULL; > eth_dev->dev_ops = &ops; > - eth_dev->pci_dev = pci_dev; > + eth_dev->data->dev_flags = RTE_ETH_DEV_DETACHABLE; > + eth_dev->data->kdrv = RTE_KDRV_NONE; > + eth_dev->data->drv_name = drivername; > + eth_dev->data->numa_node = numa_node; > + > TAILQ_INIT(&(eth_dev->link_intr_cbs)); > > @@ -688,8 +688,12 @@ eth_dev_xenvirt_create(const char *name, const char *params, > > eth_dev->data = data; > eth_dev->dev_ops = &ops; > + > eth_dev->data->dev_flags = RTE_PCI_DRV_DETACHABLE; > - eth_dev->pci_dev = pci_dev; > + eth_dev->data->kdrv = RTE_KDRV_NONE; > + eth_dev->data->drv_name = drivername; > + eth_dev->driver = NULL; > + eth_dev->data->numa_node = numa_node; > > eth_dev->rx_pkt_burst = eth_xenvirt_rx; > eth_dev->tx_pkt_burst = eth_xenvirt_tx; >