From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A8916A0537; Wed, 5 Feb 2020 01:41:29 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E7AEF1C1E0; Wed, 5 Feb 2020 01:41:28 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 0F4B81C0AB for ; Wed, 5 Feb 2020 01:41:27 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 70C7021AD2; Tue, 4 Feb 2020 19:41:26 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 04 Feb 2020 19:41:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=oX9benI0qUtj+p/CL1kXgDE2i1trYq5FGtIvlHtm+Ko=; b=QHR8j+xGBZPA cco7OQ/F/rwLEW+PfT3nodsCjZ/hifgTsrPkw2GjS53N/GtK04VwCg+dkoo4bLeh 4Dzk6P8N0qtv9jbtrlGRA/F1ISCIbpooZs3swzG+FHBUQOl6Ey5BrOAIorWQ5cTH 0stJsPflmpW0CX7gHb+YPAWd62vwKBg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=oX9benI0qUtj+p/CL1kXgDE2i1trYq5FGtIvlHtm+ Ko=; b=wdQO34GbkBiSKhJf+F5mGrWv4cYnZ4cUxRMSJQEkvx4USJ6aIFJ2KTRQv yZlRfT6JqwD23IICk9K0qowdIqRuFrter3sCP3D0OYnuybtoXbOmTCVsMdudnbmD 5KoPHc3gR/+FrfPwdxwzx5xLCf1qwONLzgbdSMDiyS1POpT49RAEHZQHmXx6bPZ/ +BhmFplY9TJoOXaby0m809h0j8xuijGKaPl/nD8IVEfkMPnQROdW+B/FVWnSACjZ 74/vvLjUP3HQF1WzfLqHz959W9GZuvzfUooWLUjeMp80jtvfI9SDrP1tFA/J7PVV oJKZd35UU3Hz5hZ2mcoKUtWj6ITpQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrhedtgddvhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh hmrghinhepmhhitghrohhsohhfthdrtghomhenucfkphepjeejrddufeegrddvtdefrddu keegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepth hhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 75E603280059; Tue, 4 Feb 2020 19:41:25 -0500 (EST) From: Thomas Monjalon To: Dmitry Kozlyuk Cc: dev@dpdk.org, Bruce Richardson , harini.ramakrishnan@microsoft.com Date: Wed, 05 Feb 2020 01:41:24 +0100 Message-ID: <12853507.RDIVbhacDa@xps> In-Reply-To: <20200205022138.68c6b854@Sovereign> References: <20200131030744.19596-1-dmitry.kozliuk@gmail.com> <2199644.NG923GbCHz@xps> <20200205022138.68c6b854@Sovereign> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 4/6] build: MinGW-w64 support for Meson X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 05/02/2020 00:21, Dmitry Kozlyuk: > > I really like this patch. > > So both GCC (with MinGW) and native clang are supported? > > Thanks. Yes, I tested both toolchains. > > > [...] > > > +# MS linker requires special treatment. > > > +# FIXME: use cc.get_linker_id() after upgrading to Meson >=0.53. > > > > What does it mean? It won't work with meson 0.53? > > It will work for any Meson version, I meant that Meson 0.54 will introduce a > better way to determine linker ID. Can you suggest a better wording? FIXME: use cc.get_linker_id() with Meson >= 0.54 > > > +is_ms_linker = is_windows and (cc.get_id() == 'clang') > > [...] > > > +if is_windows > > > + # Require platform SDK for Windows 7 and above. > > > + add_project_arguments('-D_WIN32_WINNT=0x0601', language: 'c') > > > > Please explain. Why Windows 7 is needed? What this define is doing? > > Yes, Windows 7 and above is need for already existing code in eal_lcore.c, > specifically for GetLogicalProcessorInformation() call. > > When including , one must define minimum API version the > application is compiled against [0]. MSVC and Clang default to the version of > platform SDK (that is, maximum supported). MinGW defaults to Windows XP, so > this definition must be either in before #include or > here. Because other files may include , I'd prefer to have a > global definition via compiler command-line. > > [0]: > https://docs.microsoft.com/en-us/windows/win32/WinProg/using-the-windows-headers OK, thanks. Please reword the comment with something like "Minimum supported API is Windows 7."