From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 9FF1AADBF for ; Tue, 14 Jun 2016 21:59:57 +0200 (CEST) Received: by mail-wm0-f46.google.com with SMTP id k204so6078776wmk.0 for ; Tue, 14 Jun 2016 12:59:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=GUHpUcF6OyL9RnGc5Vgie3VN399Aw2y4MsXROfByOPo=; b=wEZQaeEMzHwa5J3MbTg9QAIgzaQJOboosO80mF4jEQI9WZta+fxaVVuralJNMOSs7u 3m0v4uwVRVSUgh8lUofuMYChXSGT2pKrEirDjyqFq/fSgX68HiapuTcGQAfJokXOIyDY 5n88jjSoTJlc6cl/7uXyI3PnUxsSDjMqOql05n54Od0wcTDcqZNSzRSkiO6pp3NyPd2U 2pdXuqrWqzUrWPJmv3GXbnZ4L5gQexf/Zet3/nsJOeUBTbBTifyC4x+a7U0xEEJcvtCA 1obB0qil63fAU/Srav9ZMaW3k0h6cQW3zVJGyFjUAHA3HrfgzDrvX/prynhpXhxyEr48 ShwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=GUHpUcF6OyL9RnGc5Vgie3VN399Aw2y4MsXROfByOPo=; b=fZ+xld5tjMbqF6lZLEqkwJd7O8cz1bMD9o0x1g3pUEndlXvzLTwIzgGtXSCKoGn7VF PxQosKtALjNObHIllhYErngcPKwFqRvA+GEWyGBL3hpo6L92tRUL1dJNh+b1LSQed4Ou G4ZC2Onr9rS3YLW3hKytxtRnx9MUHVRaoRMj/ba9N6MbinZahIzelrF/gYMWVvvN0U0A 5Vf84GZnkArJz3NI6SYUz2+6gj9Bl5M1X7MT0lmdbwKL1pLb7xf4j6WnA2uwk7vO7y2T rs87qDPHzaYa/IekPizsAUitH+c0rpMiJCmw1mIF57ymEj09CShUmPAfWE4Ck225YL7+ z8og== X-Gm-Message-State: ALyK8tKXR7F67giNM47qal99NF4EJwI9iHv8WoxipBcRaehufuuNE9vuDrzbmtsecBntpDkh X-Received: by 10.28.156.201 with SMTP id f192mr6125184wme.86.1465934397238; Tue, 14 Jun 2016 12:59:57 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id c9sm34595916wjh.49.2016.06.14.12.59.55 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 14 Jun 2016 12:59:56 -0700 (PDT) From: Thomas Monjalon To: Reshma Pattan Cc: dev@dpdk.org Date: Tue, 14 Jun 2016 21:59:55 +0200 Message-ID: <12886124.K2biJ8F8kE@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1465897108-26548-2-git-send-email-reshma.pattan@intel.com> References: <1465575534-23605-1-git-send-email-reshma.pattan@intel.com> <1465897108-26548-1-git-send-email-reshma.pattan@intel.com> <1465897108-26548-2-git-send-email-reshma.pattan@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v9 1/8] ethdev: use locks to protect Rx/Tx callback lists X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jun 2016 19:59:57 -0000 2016-06-14 10:38, Reshma Pattan: > Added spinlocks around add/remove logic of Rx and Tx callbacks > to avoid corruption of callback lists in multithreaded context. > > Signed-off-by: Reshma Pattan Why cb->next is not locked in burst functions? Just protecting add/remove but not its usage seems useless.