From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com
 [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id D85DE68CD
 for <dev@dpdk.org>; Fri,  5 Dec 2014 17:38:18 +0100 (CET)
Received: by mail-wi0-f177.google.com with SMTP id l15so1959869wiw.16
 for <dev@dpdk.org>; Fri, 05 Dec 2014 08:38:18 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=wv05AkhgvRuCPZAepyd/5YFapYx42l27g0RNhaR5ZM0=;
 b=U47BTAbiE2maFTfAAanmwTzHzqipb4EXG/rfHt3wkADzDT4bpNFtS3J8/2y/1yfCtS
 4iicD4qqgQ+ri/zCV9483MY6uSJvk+KMPDyaNt+/KUPWjo+0/v8jEX9MPn9BcZUKtili
 wSuVaB+NX4/Z8tX1g5pky+DuakqWDyE6BR6R6szSUEg6uDMVACRG3RZ14X+8jJWpfFIc
 r/FCeZvYpykAou0Mpqln+qv4pxKuVOTocjAaIBSRG+u1pFpkckWFpntnlitWq4NbScBE
 P9ePko9+HVzWXVK5RCUOFw6lFQRjscm93ZGVk2JSMobDv8vD3qrXX4zBKIQf1bivErTy
 Gv/A==
X-Gm-Message-State: ALoCoQlgJ/lBbVXppffGXhfkjSsg8TqSqCrdopyJIWvSlxQV8h6Bfj9CnSxklayqORVF8Dw/Ctfl
X-Received: by 10.180.88.33 with SMTP id bd1mr5426706wib.10.1417797498719;
 Fri, 05 Dec 2014 08:38:18 -0800 (PST)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id wz5sm45532858wjc.29.2014.12.05.08.38.17
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 05 Dec 2014 08:38:18 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "John W. Linville" <linville@tuxdriver.com>
Date: Fri, 05 Dec 2014 17:37:53 +0100
Message-ID: <128892442.7P4I1l0Tzy@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; )
In-Reply-To: <20141205162453.GB28319@tuxdriver.com>
References: <1417729325-9410-1-git-send-email-linville@tuxdriver.com>
 <8974312.4KPnm9h9PX@xps13> <20141205162453.GB28319@tuxdriver.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] librte_pmd_af_packet: add compile-time
	checks for kernel-specific options
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Dec 2014 16:38:19 -0000

2014-12-05 11:24, John W. Linville:
> On Fri, Dec 05, 2014 at 10:30:53AM +0100, Thomas Monjalon wrote:
> > Hi John,
> > 
> > 2014-12-04 16:42, John W. Linville:
> > > This allows the PMD to compile with kernels that don't support the
> > > options in question.  The "#if defined(...)" lines are a bit ugly,
> > > but I don't know of any better way to accomplish the task.
> > > 
> > > Signed-off-by: John W. Linville <linville@tuxdriver.com>
> > > ---
> > >  lib/librte_pmd_af_packet/rte_eth_af_packet.c | 16 ++++++++++++----
> > >  1 file changed, 12 insertions(+), 4 deletions(-)
> > 
> > Is it possible to enable compilation of this PMD in default configuration?
> > I guess it shouldn't fail anymore with this patch?
> 
> Yes, I believe so.  I checked the kernel git history for when each
> definition was included.  Everything else was older than the 2.6.32
> kernel.
> 
> I think you can reenable this PMD in the common_linuxapp config file
> if you like.  I'll send a patch if you prefer for me to do so.

OK, I'm going do it.

Thanks
-- 
Thomas