From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B038A0032; Wed, 13 Jul 2022 16:08:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D427442B7A; Wed, 13 Jul 2022 16:08:01 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id A79094280D for ; Wed, 13 Jul 2022 16:08:00 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id A06F25C01D9; Wed, 13 Jul 2022 10:07:57 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 13 Jul 2022 10:07:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1657721277; x= 1657807677; bh=UW7zNwFyrt0n3PWG1Ug3tz+P01K4InrSUg1yen+oBE4=; b=V Slz5RKMa0XztpKjMCuJDIGG87+hCK9XSvl8U3DfqCRvEVq7X/i5zAr8fZXL4ucCN ZBTKw8gmVEOA51YBuZsJYx1YKXz2Nu12j3ZrdFbmx+nXgV/EvyiECjCXRpuyEnVZ TqKTMPIUJKPCorHgg3Knx4NgxT843fu+cJ6x0UF0lkeOW2N3eBRHEwc2hDGnSNID NPcDPul8P4O9R4KkKQzIYHMyXbVBno2AUHclhPf5ZOK3vutaqIPR9rDhrNipxF81 VyXdJNVrXuxmYlAenDRSuQwySvYFUgLdtRc43H1iV559d2Ai0yWTqMowWQuhfRfZ TPz/WTVvw4tfCuDeycuXw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1657721277; x= 1657807677; bh=UW7zNwFyrt0n3PWG1Ug3tz+P01K4InrSUg1yen+oBE4=; b=E n5+QhZHCKoLbtrGveQfNvFm4oPnJlzCVlB1CzxCK7hafJleHhZrbhejduV706b4d RwL2t4Okdyg+1erq3jGtKei/Q5u7qkzQ++TQZG0v6WCf32Qbi89ekbjaWuhWP4nC oSGhnf/rdqPG8lu6htz5NA7Hlb6x8DVZUlITO9gTCOCFFWTyy4VdweUp8yX2VPCs ytIgiH5eeBi9dGFRJVXCJjrHqOhZ+PBNLNvwBMuflkz8ypsP3P+9ZWz7iHLbutdG mpBIeX26OvbSLo5zPL6SYF8o5hu8mVz+1KCWryIHlLXjb+ingD891n+9eYld5loH vXQ7UiRr+cr9Eh43pePNw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudejjedgjedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 13 Jul 2022 10:07:54 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: dev , Andrew Rybchenko , Maxime Coquelin , "Xia, Chenbo" , Ray Kinsella , Xiao Wang , Matan Azrad , Vijay Kumar Srivastava , Ferruh Yigit Subject: Re: [PATCH v2] doc: announce transition to vDPA device name function Date: Wed, 13 Jul 2022 16:07:52 +0200 Message-ID: <12899595.6ASCnIXroE@thomas> In-Reply-To: References: <20210518073441.2749096-1-thomas@monjalon.net> <20220712133610.4175033-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 13/07/2022 15:26, David Marchand: > On Tue, Jul 12, 2022 at 3:36 PM Thomas Monjalon wrote: > > > > There is a layer violation in the vDPA API for getting the device name. > > Instead of providing the name at vDPA level, > > a function returns the low-level device object. > > Exposing a rte_device (as an opaque pointer) in upper device classes > seems a good thing to me. > With the API rework I proposed, we will have accessors to get this > object characteristics (like here, a name identifying it). > Having the vDPA API returns a pointer to a rte_device object makes it > possible to reuse those accessors, nothing more needed. > > If the rte_device object is extended in any (unforeseen at the moment) > way in the future, it would still be a matter of using the relevant > accessor. > No update needed in the vDPA API at this point in the future. > > > On the other hand, what you propose here seems to go the other way. > With each device classes needing to expose, through its own means / > API, the underlying rte_device characteristics. I realize we don't have a guideline about this API aspect: should we expose underlying handles? I understand your point and I think it is valid. I suggest cancelling this deprecation for now. Once we have a guideline agreed in doc/guides/contributing/design.rst we can revisit some API. For instance, I've avoided to expose rte_device in gpudev, and the NUMA socket is directly reported in gpudev infos. Another approach would be to expose the pointer to rte_device.