From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EF584438E9; Wed, 17 Jan 2024 10:40:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D01E7402B0; Wed, 17 Jan 2024 10:40:28 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by mails.dpdk.org (Postfix) with ESMTP id B814F402A6 for ; Wed, 17 Jan 2024 10:40:26 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lebF9CWypiIBJ7D3jJ5Te1sTBZsR7Qw/GIesR5oRPu827bnHNP/s+W8eYZehlSmsWGhGmtw4Z4DVxQceBUKNLbB8QE2Yy5rz3gShB/C39Tq6HoMjudgs86FSZCOwXGd99vtpg6LgQi3MgnSoy9fDN3im1w/WmvpfcBbxKTiS8OGxdoHXyWQNn6tBjI+4pMzpPJUcYbSJ+HzHl2Roafyb31hU/nW0wLkNrKxhcjPqR4myAFqaRTVkmVMgZRHZ8OJo7C7sVHXbLa4gfoGmWsZiMwB7YQ5oANP/QdPlWmJwAAv9o2S6rWZeGBy6q/yvbW6cK1SGQPvUruiZ4oboo7SR8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NRgPTJw4Y8H2iOhyTEDjnje907VuOdAU8WTRj2EPiPQ=; b=Z4dmvPxs1AHkeWndKAMLlpC9KOF3rIyBhWUX5SUwQnwfa+J0GtuCUsn6udeqOIsUt9udj+3nPablgi+m9AUKkHXKOQsZDBTAGeOhvq5k9PAuSb297zgEMoXzDEkXxT8aQo02FLAKdbYo8lXGnUsN87Yaqpaay9huknWbak6KOA+1+QVy+BzvL8nm5GoUZgEg7SGISHmNEa9thaoUs7A335UFLzXpPr4wDAcS+omhaffXX4CkMcHbQ00ohIIaGfvj060uV9wR7+bQTSFxhPdcwb0C2fmdKKL4v9EoCZnXvPSawL2NfQO9DhQNVSBg8zxCnWz3cztUIvoQYoqvYGts+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NRgPTJw4Y8H2iOhyTEDjnje907VuOdAU8WTRj2EPiPQ=; b=iAIduyT5Zmx4IW9Eq9vPgwPPsU8hp/qBxNwZS9ctpZrFXvj8V6IeywjZFyyUOn/hEqa3uksgop+LZo0Gy8O0hJs43Zdsjv73tk2euLDfQ71d3ljffvKjgEA3KXhwtyZWyxS0Ul9Mx5Eox87cCsz0SV4sqWetBraTuURmgaY0Eq0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by MW4PR12MB6730.namprd12.prod.outlook.com (2603:10b6:303:1ec::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.23; Wed, 17 Jan 2024 09:40:23 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f%4]) with mapi id 15.20.7181.022; Wed, 17 Jan 2024 09:40:23 +0000 Message-ID: <1289a4f1-cdde-41f3-a034-2e325680a5d4@amd.com> Date: Wed, 17 Jan 2024 09:40:17 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net/gve: Enable stats reporting for GQ format To: Rushil Gupta Cc: junfeng.guo@intel.com, jeroendb@google.com, joshwash@google.com, dev@dpdk.org References: <20231222153953.1266615-1-rushilg@google.com> <9a9e3d4c-f0f1-4192-bd92-1b4a7a2c9c20@amd.com> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0120.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::18) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|MW4PR12MB6730:EE_ X-MS-Office365-Filtering-Correlation-Id: 2bf5f617-2729-47dc-ab43-08dc174053f5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NzpRs5IGDHQkNHIN9RQfu9DAuC3B8RkTro/9F+oswjCXkByWkNNk2oDhO+zihdNEVrjd2nuCI5RtwL8M8Bauaq7SrwoiaLIbKywcDuMYxIC8zXfpX68GBGMZM40dRBjsNhgK/nnUMAFRS1/9owIPerzo/91jvZ1ZpJUXMEi3dJQ8zdqxkOWJgu3LdvtWGHVAHsZGzGq8ES64kOl+NadcsAAk31yhVqoiUP7baWFe4Bn6tZd9up/0vqQXZoZ5AQENVHH9OCdlFqPiqFlludkbdaLDC0BI19XZyYndsq9vPM9kCgn+IEr07++NpJypsaGr37tUxPkNIAtD8bUz68766oSNF7CxpLWQSoGTgP3C41BKBXJlotYRYwA90/WZECpyLBDeIisgR72IW/G6PBvPm+IlarSf+Qiwojkpe8Nm6if6dT1a6rgbTb3I2YScHNwk5DxJ9bOTJWw9B9OCA2y4F11xdU1kGqVtILOc3YDYDwHZfvyoUq6ynyUOw8LBmk7sZtV8SD5Vc1P9pXs+3VE46zV9lgxHWlbZ+O7pECuJpiVdV1AFKrUKjH2ju4R2y4Z5GA9U0hqGSz/v6hQwh5gDHafqeB131EL/IP5vDbM4nTezCauBM/RsjauAX7BzQ9snxnDGAk2nT9dHDzFgL1wh0UUPGDY1+G7D7nOVhYc4OBh6VMM9UlI0QHmN+YYha/6r X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(39860400002)(136003)(396003)(346002)(376002)(230922051799003)(230273577357003)(230173577357003)(451199024)(1800799012)(186009)(64100799003)(83380400001)(26005)(2616005)(53546011)(38100700002)(4326008)(8676002)(8936002)(5660300002)(44832011)(41300700001)(2906002)(478600001)(6486002)(6506007)(6512007)(6666004)(66476007)(66556008)(66946007)(316002)(6916009)(36756003)(86362001)(31696002)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RWRmcjZydklZMVA5ZjVrbnJHM3RZZXIxVmtQSGRnTnphQ0RRVjVDZTh3b3Bk?= =?utf-8?B?VUtlWlFMUTlCRkgwQ2g3c3NjTHV3cXVEU3ZBYjNxSklkYi83cndiZldIRC9F?= =?utf-8?B?Nmd3Q0ZjMXlYdDdLeHRBTWl0Nzc3NFJaaCs4bVViaXlFQi9Rc2lHQlZubUNo?= =?utf-8?B?N25Ma0s5K3RhSk1paEowY1dhcmVtSkJQZS90MVVNaVhYYXJWdGNSWDVYMUNl?= =?utf-8?B?d2pSam9OeHppTUFKTDVJT2IvLzJ5ZW9OcU1GcEhpRERqQ0FEUTdIUWl6NjNy?= =?utf-8?B?VWF0VVE5U1hBdEtlMm13Sm5MVS9LNDk1N2pIYU02VDdZMXV6VGNxSHlvSDI0?= =?utf-8?B?MTRLbU16V2pTSXQ5TVNyVlBjekthUTlSTk8yM0taM1pyNlB2Y0dnSllkQndk?= =?utf-8?B?Mk1vdUZKWVFWdFdHSGlhUlc0bU1oVzIzdFQ5WUFNQ01mdXZPRDJvNE9zVHBu?= =?utf-8?B?K1RCTEc3R3hEWlE0SHlQVzNXQSt0c3pkUjFrVThRUlZ1YUJJTythVENrQ3pS?= =?utf-8?B?c1NQSEUvU24vTkNOMWRRak5rWHBqamFmaGlUZUhSVTdkTmdzODZpNVFFbXdx?= =?utf-8?B?Q2U1QnVxUlIyUmhkaUxCTnl0Y2hrWVNxdjJuSnQyVE9XcHc0TEFXSjEzOEZG?= =?utf-8?B?aXF2ZTl2U3dNWWJHWVVDM0tzMEFoS09Pb0pkVG5qR1BIQUV5ak9IZXBDUWtB?= =?utf-8?B?QUFzLzh2QkRuTEtUVHNYSkljUVlFenhqb3VlUnl3WFJzamdHdlZKVVZJU1JU?= =?utf-8?B?NlFoZjBLc0pSSjNLTmlOTFRZTXkrRnMvaGh4VUJWYlN1OXUySVNndm5zdGFv?= =?utf-8?B?QjY4ZDhQV09DeUZSWDdVUmJPOGZDdnVydDl2OHJlQkpRd2lFYlJEVlRYVHpz?= =?utf-8?B?N253MWZDVGFCOGluWFNUU0paWUl6N1lUanpNT0djQkdnQVM5MmFIUjZrVXF0?= =?utf-8?B?V2Z0WGQ4cTZKb25mWWdvSm1HY1BTUWx6WEVTU2N2V24wN2g4WjU0YmEzOGkw?= =?utf-8?B?N2dNeWJtSzU0T2xTMWZaK2x3dVp4Vng2SGppMnJGdTJ4RjQrUENZT3F5ekJa?= =?utf-8?B?OTNKcDlOWDFHK3JVQUkzU0hUMkR4bWJ5TTF6clptM1NYWHBFWENkNGU1SThJ?= =?utf-8?B?QnBBb2JPMGx5bXpwZC9vZllkbHArVGdIL2p4TU4rN0NHcDNpYnJxenJTUXJG?= =?utf-8?B?UlVNMTF0bmhYQ2xvdDNlNFpjOGhPd1V1K2UvS0J3QUpJZmJuN1lFdytEVm9o?= =?utf-8?B?MS9vT1greWQwYkd4UU1qNWp0KzZtRHRHU04yM3V2aXJaMW51enVkdDJ1VmVT?= =?utf-8?B?L0hINkplUk9VdzFOQ1VYSk14SGJDd29Pc2hmQkZ3VlYzdm9seWVucHZaWFAz?= =?utf-8?B?NWR4a2dVY0NNZXJUUzFhQWdHYlpmSldpc2ZudHJYeXhDdW5MTHlYbEFqN0FI?= =?utf-8?B?K0Z3ODhGOVhsZkZqTTNvOXFwdlA2d2FtYmpsazZmbEVhVUtLd01FL1BwWW41?= =?utf-8?B?K20veGthUlFlUWc2NENJb0l5dXRZb1VtRW85cXdFVGRRQUdweTlUMURZRzlQ?= =?utf-8?B?bzVIdGdPMXZjNVNkcm9JTjRjd3RPRDZwUFFrTWJ5ZUc0NlZtUmdCRXRFNGJ5?= =?utf-8?B?R2YySkdsbFllOUJ0Z2J3SGV6bFFzZG9SaHRvdFpHWGsyMVR2SGZFQ0lqbzBD?= =?utf-8?B?L3MyVlAzNWwycG5OeGorSDNMQWRmR0dveWNoY2c3Wk91TWJiRmNMcDQzdkps?= =?utf-8?B?cmhhVzMySWpvK3FmaExaWHZmVFNxOWtVb1JPS1pCdEtWakpDRXNZTmZBd01E?= =?utf-8?B?TG5HamFCTTFJYnlOY296N2VsYS9nNitvTmRmVWM5OHF2VjRLaUpxcGRqbHo1?= =?utf-8?B?WWxpTVFmR3k2YkNsRVlvS1dBaUhqUitXSmVhUG5zRDRrajk2ZkRpMHZ6cE5W?= =?utf-8?B?WWxDMzdrYUd6MVVjemY4WmJVbUNMcjlGUWttRWNZOU9IeDFwd1dmMzNmQmov?= =?utf-8?B?K2dVem13bGM4OFY0SU1GMjdTSVduN1RmSitPMFptR1pFMllscXRrcWtwMXZl?= =?utf-8?B?K0JHU1VhU1RhTEFCbk5BL2Q0UTU0QitGWlRkdUlaL0w3QzFQTlAybStneG50?= =?utf-8?Q?jgxP0G6y0S2vC0SBAiEBJAeKD?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2bf5f617-2729-47dc-ab43-08dc174053f5 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2024 09:40:23.6034 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jw377NX23KAcX2YD7vXF3wssDo/E4SI0rzrzmBsWJSi/sAedn4iP3NO6VrZLQocy X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6730 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/16/2024 6:18 AM, Rushil Gupta wrote: > > > On Fri, Jan 12, 2024 at 8:36 PM Ferruh Yigit > wrote: > > On 12/22/2023 3:39 PM, Rushil Gupta wrote: > > Read from shared region to retrieve imissed statistics for GQ from > device. > > Tested using `show port xstats ` in interactive mode. > > This metric can be triggered by using queues > cores. > > > > Looks good but please check following comments: > > Checkpatch gives warning on the patch title, and this patch adds > 'imissed' support so it can be added to the patch title, something like: > "net/gve: enable imissed stats for GQ format" > > <...> > > > +static int gve_alloc_stats_report(struct gve_priv *priv, > > +             uint16_t nb_tx_queues, uint16_t nb_rx_queues) > > +{ > > +     char z_name[RTE_MEMZONE_NAMESIZE]; > > +     int tx_stats_cnt; > > +     int rx_stats_cnt; > > + > > +     tx_stats_cnt = (GVE_TX_STATS_REPORT_NUM + > NIC_TX_STATS_REPORT_NUM) * > > +             nb_tx_queues; > > +     rx_stats_cnt = (GVE_RX_STATS_REPORT_NUM + > NIC_RX_STATS_REPORT_NUM) * > > +             nb_rx_queues; > > +     priv->stats_report_len = sizeof(struct gve_stats_report) + > > +             sizeof(struct stats) * (tx_stats_cnt + rx_stats_cnt); > > + > > +     snprintf(z_name, sizeof(z_name), "stats_report_%s", > priv->pci_dev->device.name ); > > > > Can you please add 'gve_' prefix to the memzone name, to prevent any > possible collision. > > Done.  > > > <...> > > > +static void gve_free_stats_report(struct rte_eth_dev *dev) > > +{ > > +     struct gve_priv *priv = dev->data->dev_private; > > +     rte_memzone_free(priv->stats_report_mem); > > > > What will happen if user asks stats/xstats after port stopped? > > Good catch. I have added a null check so that the driver doesn't try to > read stats from memory region that doesn't exist.  > > > <...> > > >  gve_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats > *stats) > >  { > >       uint16_t i; > > +     if (gve_is_gqi(dev->data->dev_private)) > > +             gve_get_imissed_from_nic(dev); > >  > > This updates imissed in RxQ struct for all queues for basic stats, but > what if user only calls xstats, I guess in that case stat won't be > updated. > >   > Yes; that is expected. Since imissed is a member of rte_eth_stats; > calling gve_dev_stats_get is the right way to get this stat. > I don't think it is expected. xstats contains the basic stats too, if users calls xstats API, expectation is to get correct values.