Re: [dpdk-dev] [PATCH v2 2/3] eal: add new rte color definition

["Mattias Rönnblom" <mattias.ronnblom@ericsson.com>]

On 2018-12-15 00:35, Ananyev, Konstantin wrote:
> Hi Reshma,
> 
>> diff --git a/lib/librte_eal/common/include/rte_color.h b/lib/librte_eal/common/include/rte_color.h
>> new file mode 100644
>> index 000000000..f4387071b
>> --- /dev/null
>> +++ b/lib/librte_eal/common/include/rte_color.h
>> @@ -0,0 +1,18 @@
>> +/* SPDX-License-Identifier: BSD-3-Clause
>> + * Copyright(c) 2018 Intel Corporation
>> + */
>> +
>> +#ifndef _RTE_COLOR_H_
>> +#define _RTE_COLOR_H_
>> +
>> +/**
>> + * Color
>> + */
>> +enum rte_color {
>> +	RTE_COLOR_GREEN = 0, /**< Green */
>> +	RTE_COLOR_YELLOW, /**< Yellow */
>> +	RTE_COLOR_RED, /**< Red */
>> +	RTE_COLORS /**< Number of colors */
>> +};
> 
> Does it really belong to EAL?
> Konstantin
> 

If this is supposed to be a generic type, we definitely need 
RTE_COLOR_BLACK as well, or RTE_COLOR_VERY_VERY_DARK_GREY.

/Batman