From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3]) by dpdk.org (Postfix) with ESMTP id 24BF01B92D for ; Sat, 15 Dec 2018 15:15:45 +0100 (CET) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 7AD7C40030 for ; Sat, 15 Dec 2018 15:15:44 +0100 (CET) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id 677F24002F; Sat, 15 Dec 2018 15:15:44 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on bernadotte.lysator.liu.se X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=ALL_TRUSTED,AWL autolearn=disabled version=3.4.1 X-Spam-Score: -0.9 Received: from [192.168.1.59] (host-90-232-140-56.mobileonline.telia.com [90.232.140.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id 248524000F; Sat, 15 Dec 2018 15:15:42 +0100 (CET) To: "Ananyev, Konstantin" , "Pattan, Reshma" , "dev@dpdk.org" , "Dumitrescu, Cristian" , "jerin.jacob@caviumnetworks.com" , "Singh, Jasvinder" References: <20181123165423.134922-1-jasvinder.singh@intel.com> <1544193116-7058-2-git-send-email-reshma.pattan@intel.com> <2601191342CEEE43887BDE71AB977258010D8BA5F8@IRSMSX106.ger.corp.intel.com> From: =?UTF-8?Q?Mattias_R=c3=b6nnblom?= Message-ID: <128d5503-af19-c9bb-d59c-43b71471f9c4@ericsson.com> Date: Sat, 15 Dec 2018 15:15:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <2601191342CEEE43887BDE71AB977258010D8BA5F8@IRSMSX106.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP Subject: Re: [dpdk-dev] [PATCH v2 2/3] eal: add new rte color definition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Dec 2018 14:15:45 -0000 On 2018-12-15 00:35, Ananyev, Konstantin wrote: > Hi Reshma, > >> diff --git a/lib/librte_eal/common/include/rte_color.h b/lib/librte_eal/common/include/rte_color.h >> new file mode 100644 >> index 000000000..f4387071b >> --- /dev/null >> +++ b/lib/librte_eal/common/include/rte_color.h >> @@ -0,0 +1,18 @@ >> +/* SPDX-License-Identifier: BSD-3-Clause >> + * Copyright(c) 2018 Intel Corporation >> + */ >> + >> +#ifndef _RTE_COLOR_H_ >> +#define _RTE_COLOR_H_ >> + >> +/** >> + * Color >> + */ >> +enum rte_color { >> + RTE_COLOR_GREEN = 0, /**< Green */ >> + RTE_COLOR_YELLOW, /**< Yellow */ >> + RTE_COLOR_RED, /**< Red */ >> + RTE_COLORS /**< Number of colors */ >> +}; > > Does it really belong to EAL? > Konstantin > If this is supposed to be a generic type, we definitely need RTE_COLOR_BLACK as well, or RTE_COLOR_VERY_VERY_DARK_GREY. /Batman