From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A844AA00E6 for ; Mon, 8 Jul 2019 18:35:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4E208325F; Mon, 8 Jul 2019 18:35:32 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by dpdk.org (Postfix) with ESMTP id E9DA43256 for ; Mon, 8 Jul 2019 18:35:30 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id BC7556B8; Mon, 8 Jul 2019 12:35:28 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 08 Jul 2019 12:35:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=rFaQBA5yIIJGej++4y8QnANUvCketZfSP1WrvnwFdKQ=; b=kIW18Bj14qUu bX9KLDzMgYnOZQ8qqrCDvsnDYAAbew79A3hXHq7uYJ+cnrgRsHfzR4Q2O8KP5qn+ Hf+cjP6nJiScwbgc7LX55vD7zNmQTSieJfZJnc6onfKJey1D5nhBC/tRR3jEcQYo ApTyqO28VrQ317f5B4qbYyfbtbwm7Mc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=rFaQBA5yIIJGej++4y8QnANUvCketZfSP1WrvnwFd KQ=; b=0kMkPkUAnKeved5f+ryqeTW+u+3c7a2ykYgaaqluzVmSqkU2X68+Q9Ll3 N3/2KBmaHUdWbKANFOcfKltbtW+fTv8SKGOHla2hb8HxPH4KtbI1ItKcmztC6Ak6 XCr3UZmF3tkT6AmWXwFP30EiDe044SKHWHy2QrRo64xLSb37/Wzt3sffwXmvanNH hqlzfoLx2O70oL/5sgbjYrwAW5qd7FKSiktEyrjxiMSj0ThFLZAIGjpz3/6Z/ver +OogtUDwoyD/e2X8IiLX9rjOSooWHtLbhdUxPElbKbMKsdkiLZlQUyglQ7Y1NvaE 1uFjdktjRMh7SgO8x2sB8tYZWi98A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrgedtgddutdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E2A7A380079; Mon, 8 Jul 2019 12:35:26 -0400 (EDT) From: Thomas Monjalon To: Olivier Matz Cc: dev@dpdk.org, David Marchand , Bruce Richardson Date: Mon, 08 Jul 2019 18:35:25 +0200 Message-ID: <12936694.jvCGMiB3o0@xps> In-Reply-To: <20190705135822.1797-1-olivier.matz@6wind.com> References: <20190523074318.29044-1-olivier.matz@6wind.com> <20190705135822.1797-1-olivier.matz@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] devtools: better freebsd support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 05/07/2019 15:58, Olivier Matz: > - As "readlink -e" and "readlink -m" do not exist on freebsd, > use "readlink -f", it should not have any impact in these cases. > - "sed -ri" is invalid on freebsd and should be replaced by > "sed -ri=''" > - Use gmake instead of make. > > This fixes the following command: > SYSDIR=/usr/src/sys ./devtools/test-build.sh \ > -j4 x86_64-native-freebsd-gcc > > Signed-off-by: Olivier Matz > --- > --- a/devtools/test-build.sh > +++ b/devtools/test-build.sh > +[ -z $MAKE ] && command -v gmake > /dev/null && MAKE=gmake > +[ -z $MAKE ] && command -v make > /dev/null && MAKE=make > +[ -z $MAKE ] && echo "Cannot find make or gmake" && exit 1 I'm surprised it works, given the -e in this script. I would be more confortable with "if/elif" constructs.