DPDK patches and discussions
 help / color / mirror / Atom feed
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: "Ferruh Yigit" <ferruh.yigit@xilinx.com>,
	"Morten Brørup" <mb@smartsharesystems.com>,
	thomas@monjalon.net
Cc: dev@dpdk.org
Subject: Re: [PATCH] ethdev: rte_eth_rx_queue_count is a dataplane function
Date: Mon, 12 Sep 2022 17:47:21 +0300	[thread overview]
Message-ID: <12a94c58-0905-5df3-5bec-65ea9292f22d@oktetlabs.ru> (raw)
In-Reply-To: <f4d6fbd0-4c30-15cb-ace5-27212a435f7b@xilinx.com>

On 8/18/22 15:23, Ferruh Yigit wrote:
> On 8/18/2022 10:37 AM, Morten Brørup wrote:
>> Applications may use rte_eth_rx_queue_count() in the RX stage of the
>> dataplane, so only check the function parameters if built with
>> RTE_ETHDEV_DEBUG_RX.
>>
>> Signed-off-by: Morten Brørup <mb@smartsharesystems.com>
> 
> I don't remember if those checks done by default intentionally, but I 
> don't think so,
> 
> And since other relevant functions do the same thing:
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@xilinx.com>
> 

The patch itself looks good to me.
Summary should be fixed to be not a statement and should not
mention function name. Other than that:

Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>

  reply	other threads:[~2022-09-12 14:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-18  9:37 Morten Brørup
2022-08-18 12:23 ` Ferruh Yigit
2022-09-12 14:47   ` Andrew Rybchenko [this message]
2022-09-22 13:46     ` Morten Brørup
2022-09-28  7:57       ` Andrew Rybchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12a94c58-0905-5df3-5bec-65ea9292f22d@oktetlabs.ru \
    --to=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@xilinx.com \
    --cc=mb@smartsharesystems.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).