DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Wang, Haiyue" <haiyue.wang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Yang, Qiming" <qiming.yang@intel.com>,
	"Fu, Qi" <qi.fu@intel.com>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3] net/ice: drain out DCF AdminQ command queue
Date: Fri, 22 Jan 2021 02:38:23 +0000	[thread overview]
Message-ID: <12bf10fee3074d44be24451a2baedea7@intel.com> (raw)
In-Reply-To: <20210121173137.108599-1-haiyue.wang@intel.com>



> -----Original Message-----
> From: Wang, Haiyue <haiyue.wang@intel.com>
> Sent: Friday, January 22, 2021 1:32 AM
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Fu, Qi <qi.fu@intel.com>; Wang, Haiyue
> <haiyue.wang@intel.com>; stable@dpdk.org
> Subject: [PATCH v3] net/ice: drain out DCF AdminQ command queue
> 
> The virtchnl message is handled one by one by checking opcode to match the
> response for the request.
> 
> The DCF AdminQ command with buffer needs two virtchnl commands, one is to
> handle the AdminQ descriptor, the other is to the handle AdminQ buffer. If both
> of them are sent to PF successfully, it needs to wait two responses from PF,
> even if the AdminQ descriptor command gets the failure response. Since PF will
> handle them one by one, and send back the response for each.
> 
> If not wait for the buffer message response until timeout to drain out the
> virtchnl command queue, it will cause the next AdminQ command with buffer to
> get the stall buffer response from previous.
> 
> Fixes: daa714d55c72 ("net/ice: handle AdminQ command by DCF")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi

      reply	other threads:[~2021-01-22  2:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <220210121141804.83855-1-haiyue.wang@intel.com>
2021-01-21 14:23 ` [dpdk-dev] [PATCH v2] " Haiyue Wang
2021-01-21 17:31 ` [dpdk-dev] [PATCH v3] " Haiyue Wang
2021-01-22  2:38   ` Zhang, Qi Z [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12bf10fee3074d44be24451a2baedea7@intel.com \
    --to=qi.z.zhang@intel.com \
    --cc=dev@dpdk.org \
    --cc=haiyue.wang@intel.com \
    --cc=qi.fu@intel.com \
    --cc=qiming.yang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).