From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 242E2A0A0C; Wed, 28 Jul 2021 17:32:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ABBAB40E64; Wed, 28 Jul 2021 17:32:07 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 083DB40142 for ; Wed, 28 Jul 2021 17:32:05 +0200 (CEST) Received: from [192.168.100.116] (unknown [37.139.99.76]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 1EE767F510; Wed, 28 Jul 2021 18:32:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 1EE767F510 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1627486325; bh=TcfEeeDFOcI2p4oYm/7EWNgoN1zyE3uxyT3mmfJXgAM=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=iuMdH0UJLz7IiA33IPNCcvnaI8VvZvJVSThkJEVU/U+qLgouO3T26GJhD+O33IwrL IND3xYWY5RqlnUPY1+Vwan6RgHXGun/TFuSDoibA0PfWk+4VNvrLobF8NO8zedNINu 1FcxIlPs8uX6aEWIBAV++6kGPVHXu2o6ptSBA1fA= To: Bruce Richardson , "Xia, Chenbo" Cc: "Yigit, Ferruh" , "dev@dpdk.org" , "thomas@monjalon.net" , "mdr@ashroe.eu" , "nhorman@tuxdriver.com" , "david.marchand@redhat.com" References: <20210601084131.4277-1-chenbo.xia@intel.com> From: Andrew Rybchenko Message-ID: <12d1edf2-d429-2ab9-9a35-4b44f5116599@oktetlabs.ru> Date: Wed, 28 Jul 2021 18:32:04 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] doc: announce removal of ABIs in PCI bus driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 7/27/21 11:44 AM, Bruce Richardson wrote: > On Mon, Jul 26, 2021 at 05:56:17AM +0000, Xia, Chenbo wrote: >> Hi, Ferruh >> >>> -----Original Message----- >>> From: Yigit, Ferruh >>> Sent: Friday, July 23, 2021 8:47 PM >>> To: Xia, Chenbo ; dev@dpdk.org; thomas@monjalon.net >>> Cc: mdr@ashroe.eu; nhorman@tuxdriver.com; david.marchand@redhat.com >>> Subject: Re: [dpdk-dev] [PATCH] doc: announce removal of ABIs in PCI bus >>> driver >>> >>> On 7/23/2021 8:39 AM, Xia, Chenbo wrote: >>>> Hi, >>>> >>>> A gentle ping for comments.. >>>> >>>>> -----Original Message----- >>>>> From: dev On Behalf Of Chenbo Xia >>>>> Sent: Tuesday, June 1, 2021 4:42 PM >>>>> To: dev@dpdk.org; thomas@monjalon.net >>>>> Cc: mdr@ashroe.eu; nhorman@tuxdriver.com >>>>> Subject: [dpdk-dev] [PATCH] doc: announce removal of ABIs in PCI bus >>> driver >>>>> >>>>> All ABIs in PCI bus driver, which are defined in rte_buc_pci.h, >>>>> will be removed and the header will be made internal. >>>>> >>>>> Signed-off-by: Chenbo Xia >>>>> --- >>>>> doc/guides/rel_notes/deprecation.rst | 5 +++++ >>>>> 1 file changed, 5 insertions(+) >>>>> >>>>> diff --git a/doc/guides/rel_notes/deprecation.rst >>>>> b/doc/guides/rel_notes/deprecation.rst >>>>> index 9584d6bfd7..b01f46c62e 100644 >>>>> --- a/doc/guides/rel_notes/deprecation.rst >>>>> +++ b/doc/guides/rel_notes/deprecation.rst >>>>> @@ -147,3 +147,8 @@ Deprecation Notices >>>>> * cmdline: ``cmdline`` structure will be made opaque to hide platform- >>>>> specific >>>>> content. On Linux and FreeBSD, supported prior to DPDK 20.11, >>>>> original structure will be kept until DPDK 21.11. >>>>> + >>>>> +* pci: To reduce unnecessary ABIs exposed by DPDK bus driver, >>> "rte_bus_pci.h" >>>>> + will be made internal in 21.11 and macros/data structures/functions >>> defined >>>>> + in the header will not be considered as ABI anymore. This change is >>>>> inspired >>>>> + by the RFC >>> https://patchwork.dpdk.org/project/dpdk/list/?series=17176. >>>> >>>> I see there's some ABI improvement work on-going and I think it could be >>> part of >>>> the work. If it makes sense to you, I'd like some ACKs. >>>> >>> >>> Acked-by: Ferruh Yigit >>> >>> I am for reducing the public ABI as much as possible. How big will the >>> change >>> be? Is the 'rte_bus_pci.h' used other than './drivers/bus/pci/'? >> >> I don't see big change here. And I am not sure if I understand your second >> question. The rte_bus_pci.h will still be used by drivers (maybe remove the >> rte prefix and change the file name). >> > The file itself will still be exported in some cases, where the end-user > has their own drivers which need to be compiled, so I'd recommend keeping > the rte_ prefix. However, I think making all bus APIs internal-only to DPDK > is a good idea. > > Acked-by: Bruce Richardson > Acked-by: Andrew Rybchenko