From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0074.outbound.protection.outlook.com [104.47.42.74]) by dpdk.org (Postfix) with ESMTP id AEA1F1B1DF for ; Wed, 10 Jan 2018 15:21:42 +0100 (CET) Received: from DM5PR03CA0039.namprd03.prod.outlook.com (2603:10b6:4:3b::28) by SN2PR03MB2366.namprd03.prod.outlook.com (2603:10b6:804:e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.386.5; Wed, 10 Jan 2018 14:21:40 +0000 Received: from BN1AFFO11FD025.protection.gbl (2a01:111:f400:7c10::176) by DM5PR03CA0039.outlook.office365.com (2603:10b6:4:3b::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.386.5 via Frontend Transport; Wed, 10 Jan 2018 14:21:40 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1AFFO11FD025.mail.protection.outlook.com (10.58.52.85) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.345.12 via Frontend Transport; Wed, 10 Jan 2018 14:21:08 +0000 Received: from [10.232.134.49] ([10.232.134.49]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id w0AELa2f020871; Wed, 10 Jan 2018 07:21:37 -0700 To: "De Lara Guarch, Pablo" , "dev@dpdk.org" CC: "hemant.agrawal@nxp.com" , "Gonzalez Monroy, Sergio" , "Nicolau, Radu" References: <20171214065202.9128-1-akhil.goyal@nxp.com> From: Akhil Goyal Message-ID: <12ddac44-3c50-d4ad-e179-1e4e8b8a33e5@nxp.com> Date: Wed, 10 Jan 2018 19:51:36 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131600676687036947; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(39380400002)(346002)(39860400002)(396003)(376002)(2980300002)(1110001)(1109001)(3190300001)(339900001)(13464003)(199004)(24454002)(189003)(65806001)(81166006)(106466001)(85426001)(47776003)(53936002)(36756003)(498600001)(31686004)(305945005)(105606002)(356003)(81156014)(8676002)(110136005)(8936002)(104016004)(65956001)(54906003)(6246003)(86362001)(58126008)(316002)(2950100002)(83506002)(65826007)(68736007)(5660300001)(230700001)(50466002)(59450400001)(4326008)(229853002)(31696002)(76176011)(97736004)(2906002)(64126003)(53546011)(23676004)(2486003)(8656006)(2501003)(77096006)(67846002); DIR:OUT; SFP:1101; SCL:1; SRVR:SN2PR03MB2366; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD025; 1:m7YPOwIfd2SpmKhsAl5vaeBpDWtEOB/n1W7ckHgd7Df5oVeGnSQNiooCuIMHuw3VRbQyr+nK1FKrtb19jBYy9AE+fbWn0lDOGXhzR41eg/QP+wkCnfxHbg0GQmK8M4FX X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 91c48c83-e6be-488a-c213-08d558356498 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4628075)(201703131517081)(5600026)(4604075)(2017052603307); SRVR:SN2PR03MB2366; X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2366; 3:dzzvyiFSyL2kNs153T3VTcmLUjhxbWxmLMvms0bW/iJeNxO9yWomBUaMjbejRQtLtnnw+9GuQ0dUsMWmPtebP2fBFeOxWjIfX7ynRUdobT/ZqM07+mNnBz2bMknHcxFr8za2ny2o6PtO76RIAmo3l2GpwkFGNFECqGu6zRRli69fTCpurOmXRmlUmmPeSBB0wBwEQzIZJo2fUhHiiWZyLH2Y+Ad+al2DUkwDkX7rtSMxpiDYV4hafk21ojo5pSvzEryCZdITUZrruJBW+3EQefQXGb5GeyfEklfs4NX+MmFjf4xwuUk1i1PNP9+nZ6JJqQJTEhUO0mKajB9CbQh0P6fjuX77pCp83TZS9MF+RHw=; 25:YqLseML9Ca7jSb81Bd4PRF82eNRF+W3R+ncBZBzp8OprpYhIBrOMXwljGTfnkN/7ClLdwoiiLCBplquTaWtniKDYlxjqTX4VnUc7/2wNDAPqy20+Jp4sCKC6XPX8/qdCG5ZF2NucK0VxKYWE8I40uCrFzisglK/jsOgqqOro/9CVyRam8W+eXUXvGIz8aPTrRf06l+VEnwb4WjDRi55nfoUVHxqfUIiaxf6qzEV7u3/th2uagEUuZJ1HdCeZMNBlErIaSZRZy9HHBLFQQzIeZ/Rk2RUGRPkrJRV69LugvyOoLyo68ZeSSn20FcmwF+KsSwVK3KBgyW4W0lWErexn4g== X-MS-TrafficTypeDiagnostic: SN2PR03MB2366: X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2366; 31:7m4Ur/mB+U3Rhq/Z6peSVsaDRYvFurBrS62raxGXJa5M1ZGyNNv0rR5dbSv0QF+dJ0hud0UruSZ0zIEbcL5QobI+YK+kO/qVeIBIgAeyspi107Nt13rL4jA5SB1gOWpEXoiP2OpxEiqQZfaKu5DO04c4/uDKb3ZNiowHuNw8vycb5W4aIkt41GSOOZ8CKF4zEYH/pvyi8zCz2ialSfcD0rC98AOr5GOYm5EGFJVCMp4=; 4:K6h1ugsvR9k692aAb3ixVbjkADha0dvZBZa1D5c4iJFFJ58ORd48AHQoB8h6KkdOjDaXOUzg0F1UrMWUQdPQVKiiBKE/i5Tj/CtNILaJFZVLyJwF+VB8IVBJEMNoaaOoVmS3P8hBA6+a4ZX/bnqroxOlpgWPEgMLg6YPLhLdZP4kolhxQm3Qxx0aZL0TO5vAYYZbrgrRT+3LM4VLV7DwdTTc87jBy4XlKvsN2ndc58m3aByFLFYY3saTzTJxXXStwXwsC90YIfsX5QDJ1azUlscO3OAdG5pJicDT7b9vEJ7k6H1sKK66Q0BhH4cvwik9xIPMQrX4vSjTVXoCjVBpdgFVRE9l+0yBb3bQYE9Swjo= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095135)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3231023)(944510075)(944921075)(946801075)(946901075)(3002001)(6055026)(6096035)(20161123559100)(20161123563025)(20161123565025)(20161123561025)(20161123556025)(201703131430075)(201703131448075)(201703131433075)(201703161259150)(201703151042153)(201708071742011); SRVR:SN2PR03MB2366; BCL:0; PCL:0; RULEID:(100000803101)(100110400095)(400006); SRVR:SN2PR03MB2366; X-Forefront-PRVS: 0548586081 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjJQUjAzTUIyMzY2OzIzOnJaT2JaUEhqZFRWNWl3VkdSaVNBb3BUM3FP?= =?utf-8?B?Y2p2cEcrT1ZVTWlodytwb1R3SlQzWFJ4bkRJREkwN00yTHU1a1UxTEU1T1RQ?= =?utf-8?B?eXltQlNpcWVvU3ZOWjcydENFRU9mcSsvd0lMeWJSYWtnZDJMRTU2ZER4WC9i?= =?utf-8?B?d0p3NUpyazBCY0tZT3N2T0FtdHFQQzZ4V3F6NTBmd0plSTVDdU9vUVY5aGdu?= =?utf-8?B?VFREWWFUc1B4bG1lN2t2MTV5SlBTN2NQUXl3c1hLVkRyQ2NmKzEvSHVBZ0Ra?= =?utf-8?B?S3VxT2dlRnJ0QkdpbU82TjVlZVpuMW9YOXNNU0ZEajdtYnA5R3FMWVZ1MjBo?= =?utf-8?B?L0tDZWxFTzluT3dIVm5yZ2xOaGszNlZRSzU1Vi9HUFQvQjFFQTNFcUtFNHYr?= =?utf-8?B?SkRxVUIxVHh0MWU5ckIzTkt6dG4weSszcmJxV0I0aThXSGZMTFoxVFFVZ29C?= =?utf-8?B?UlhmajZvNjVXZHR3MnYzNlFyN0NTVTdlNkxEbkFXYzNrWFVsUVF5M3IwVVdm?= =?utf-8?B?dUM5U3RYNCs4R2ZtbFBBaTBWNGwvS1NMYkprZmpKZ21yMldGb2VUeVptUSt6?= =?utf-8?B?eis1QklES01DVTFyNTBzMTRkRlhmWUhqOGJuQWJHcUptOENnVkJqb3NqM0Z0?= =?utf-8?B?QUJROVFQNU1DaElkLzZ0SmlJbmJmUFpNTGsvWDdKNStSaFRWaU4rdm1RTCtN?= =?utf-8?B?UGQ4bXp5RjkrU3VZSlcvazI2aTJTbzJRYkZVbjMrWEVVT2crMy9oOUNpZWE5?= =?utf-8?B?OExYNUZNM2JCRkZWbm9WK0I1UFV4YzdlYXdtbFZUbkx0YzR4UEN0UE1PYkFx?= =?utf-8?B?VVBKcklEMHZTY1hvMHVrRVgzcEwvWTFwTFJJTWNvQ1JQZkpuUHpiUG9DTUZ3?= =?utf-8?B?QjlXZGhoYzNJOVVJS25sWlQxby8xZXJVVkpKTmMvekVGTittdGJraVFVVTJO?= =?utf-8?B?eW9MajhiOHdmYXVmQVFJazhlRmUrbERXZVo5bndDWCtoQW5jbUJYNUJCbjV5?= =?utf-8?B?LzdlZW4rYUhXdXl6UWJRbzNsczU0cS8rRTJmY2ZJWGNyUzVUcVNaN2xTbENT?= =?utf-8?B?YTh5VkQ1ZHYxemxiTU96RFBFVTRQVFJlVGtjemJxQTZuN0Y4OVV3V2RodllE?= =?utf-8?B?SUhSQnhoK0YyZHorWFZVNlhKdHlFbDdpa1RHZkViQzQ2cTJmRnlpSzMxcjh1?= =?utf-8?B?QldqTG1rY1c0NXVpNHNiSG1sOG8rVzNTK0xoNURRaUFGK1FCaEgySkRqNTRC?= =?utf-8?B?bTRtblJzeEp2WXhvVFliYW9CZmJCMHNOZkFQajdtQ21NenVjT1Y2SFc3M0FQ?= =?utf-8?B?bDV3eThKbnJ2bTlDcEZrNGY2bUV0citKQjliUGQvRWRmMzJBa1AxQ1BZOU85?= =?utf-8?B?ZU4xMjBsL0hRVDFacU9Qc25HVTdzaEZ3TDNYSkx0enRtSWQ3bDl4K1ptSnZD?= =?utf-8?B?MyttTXpxTWhvK3BMdExjUG4xVFNZY2RpU0x0QkFHQlp4L3lYUFRrR2lMRU1J?= =?utf-8?B?RDlQRnE5dndTckNrdEhuNFFnbGt0U2pWaXozTlVObW1TWXNTd1oxekRKblMy?= =?utf-8?B?WFNrSG1MZ0kzTjc0T3JPWklNVFBRZm42Q2Vmd1pFTm9hTWNMR0habmpRc0xB?= =?utf-8?B?VDBQbGZUVngrRVJ5MmtxSCszY2t6UjBGTExIck00bE9WNkljLzEzOWEvY3N1?= =?utf-8?B?RDZCRkMxbEYzSWd2ZmNlVHl2L0lQRzFENkplNlVRMVlnYXk2amJmSVlTa0Fa?= =?utf-8?B?NG02OFJYZkZDTFd3a2hXbFhnLzFSVGtWaC9QdGNLU3VDcVJKQnlZdmtYUVZD?= =?utf-8?B?cDR6WVYvRmYrTzZaMnhLQXlwOGF2Zjh3LzU3cWxhNktJWllNam1mMXp0anp6?= =?utf-8?Q?N85wzuSYJJM=3D?= X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2366; 6:wewybZgZHmyraLOPeB/pDrC+7MRVlTc4uwCes7lcaElR38438D6SUDiqGf/RBKCXFyh0MAr+IeOcd4gluRoXvZ/3JK0a2IiAMGaGbrEE02Ms4lcs4/6fk5VP+JxQaNMaTi/hUsC8meSkaAXb86VC01q60YxN/NoNkC95flNAPDInVar9sYpDJ/Tx6E/7c4d3qAeSYvOSvRu/6/3AnSSTJtlkTXEW8OhTCa3I823XlKjLVRhRh7IIbW0cW5FsDO3PZTpz+cZEmRQNfWTMEmZvizT8YfJhOa7wg9PrnFLQJ9I5fB7TKQIqNvJDVaVG3duvGwxKerHfRU3hXd3Ouk6KR8/RQrT/1Q3DIoCJuN6zfBU=; 5:wQZDC+Mc0jzKA3tyBoTDE3WNe9c+bjLm5k9kuarwIix8MiefciCwfmG8r73fSViH4kCMYHjOVw96oN67DTxH17fsdImUCsQejc3KTDdFM27C10LZfrDudIvEybSjnanmbNMd1vC+M/S8+aPWwr+KFOsfRidiLJdCi3wIQETDBO4=; 24:9Mfiahnly8lWEN0wWyevrAXd8Vkd15Z4hhDvSvMbpwKU8pbHyQkyrdozeFzI5mSsItvURy3TF+7rnm23NVs9WfcP3HrB8Rds71QOW/MRivE=; 7:Hw1D38PN54yekYDKU3ga8ewZzwjM+1+gN1DOZchs6mvUUVN/UHEmy1jRR0EuaRsBKGPmkn2ADjhSTtsryXlz9w7Y7iiHruhRPnAfhSfo3ydftpRLcBjw/nC1mTFmBexPyD1T2NguOpZfrq809AFC4SCoJHGb7twXHsku7eSEPJlc3+Gzi84U4IiDH56qnP+zBnPG4TTLo72PuOA/cHaIH0OjZoTbfUGKLsVHof8k94eKQTjdEC5Q+eAU69qPMJTx SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2018 14:21:08.4696 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 91c48c83-e6be-488a-c213-08d558356498 X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR03MB2366 Subject: Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: add cryptodev mask option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jan 2018 14:21:43 -0000 Hi Pablo, On 1/10/2018 6:17 PM, De Lara Guarch, Pablo wrote: > Hi Akhil, > >> -----Original Message----- >> From: Akhil Goyal [mailto:akhil.goyal@nxp.com] >> Sent: Thursday, December 14, 2017 6:52 AM >> To: dev@dpdk.org >> Cc: De Lara Guarch, Pablo ; >> hemant.agrawal@nxp.com; Gonzalez Monroy, Sergio >> ; Nicolau, Radu >> ; Akhil Goyal >> Subject: [PATCH] examples/ipsec-secgw: add cryptodev mask option >> >> Previously, ipsec-secgw application did not give user the flexibility to decide >> which crypto device(s) will be used. >> >> In this patch, a new cryptodev_mask option is added to the application. >> Same as portmask, the cryptodev_mask avails the user to mask out the >> unwanted crypto devices in the system. >> >> This patch is similar to the support added in l2fwd-crypto >> (d2797f51cc63: examples/l2fwd-crypto: add cryptodev mask option) >> >> Signed-off-by: Akhil Goyal >> --- > > ... > > Not sure if you should change the order of the crypto devices that was set previously > (starting from the end and not from the beginning). Shouldn't we keep it as it was? Actually as per the current code base there is no fix order of the devices to be available. In bus scan, all(pci,fslmc,vdev) have same priority(110), which means whatever is first recognized/linked will come first. So the assumption that last cdev_id is HW doesn't seem to be correct. I just wanted to make the code similar to l2fwd-crypto and the behavior of cryptodev_mask similar to what l2fwd-crypto understands. Please let me know if my understanding is not correct. > >> idx = 0; >> - /* Start from last cdev id to give HW priority */ >> - for (cdev_id = rte_cryptodev_count() - 1; cdev_id >= 0; cdev_id--) { >> + for (cdev_id = 0; cdev_id < rte_cryptodev_count(); cdev_id++) { >> struct rte_cryptodev_info cdev_info; >> >> + if (check_cryptodev_mask((uint8_t)cdev_id)) >> + continue; >> + >> rte_cryptodev_info_get(cdev_id, &cdev_info); >> >> if (nb_lcore_params > cdev_info.max_nb_queue_pairs) >> -- >> 2.9.3 > > For the rest, I don't have other objections, so apart from the comment above: > > Acked-by: Pablo de Lara > > Thanks, Akhil