From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5D29FA034F; Tue, 8 Jun 2021 12:34:43 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D40104067A; Tue, 8 Jun 2021 12:34:42 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 63B344013F for ; Tue, 8 Jun 2021 12:34:41 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id F0E357F5F5; Tue, 8 Jun 2021 13:34:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru F0E357F5F5 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1623148481; bh=9gIhNoKWR63HtB8sz2M+lnoGKzVatWDKbQCaA8Zjfd8=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=EAPUsKSNayQIb/fDahnadXHE5qOtYUtJF56N03YmHhQF+nQPoB+D5XM4j+Q849jJQ C9gWUTmnwSAu22Idte5PbIywQxmlVp/RxFhtoEK6L2C8XmQTq9Jx9Bklv4CvMVm3kN QWDO6kOyh5oOGhOYYldAPowyuOU2I8ieZPCpM3lA= To: "Li, Xiaoyun" , "Min Hu (Connor)" , "dev@dpdk.org" Cc: "Yigit, Ferruh" References: <1618813303-32945-1-git-send-email-humin29@huawei.com> <1619599019-46246-1-git-send-email-humin29@huawei.com> <1619599019-46246-2-git-send-email-humin29@huawei.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <12f1a7fa-a1b9-6f6c-098d-9cf499478a1f@oktetlabs.ru> Date: Tue, 8 Jun 2021 13:34:40 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 1/2] app/testpmd: add link speed check before port start X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/30/21 6:19 AM, Li, Xiaoyun wrote: > >> -----Original Message----- >> From: Min Hu (Connor) >> Sent: Wednesday, April 28, 2021 16:37 >> To: dev@dpdk.org >> Cc: Yigit, Ferruh ; Li, Xiaoyun >> Subject: [PATCH v2 1/2] app/testpmd: add link speed check before port start >> >> From: Huisong Li >> >> Currently, to check whether the configured link_speeds is valid, we have to run >> "port start". In addition, if the configuration fails, "port->dev_conf.link_speeds" >> maintained in testpmd cannot be restored. >> >> This patch adds the link_speeds check before port start by calling dev_configure, >> and resolves these problems. > > Not sure about this patch. I don't think you can fix the issue you mentioned. > Probably only hns3 does speed check in dev_configure. I don't see this in other drivers, not in i40e/ice/mlx. The configuration check may be done by passing the configuration to HW and HW may reject it. (Just as a side note that it is not that simple/) > I guess it's because if it's not supported speed, it will just be UNKNOWN and user can config again? > > BTW, even if this behavior is accepted by others, still some comments below. > [snip]