From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id DEDAA4A63 for ; Wed, 29 Mar 2017 11:23:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490779407; x=1522315407; h=subject:to:references:cc:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=7Y6B8ptHft8kBUq8O+Gcsl8GBqJ2tqIJnTPtS95zTqE=; b=IbKCyqecrZtGXbYseVNXQ4+q7moQ6VMMd/UWhMYl3ncTOLlA+gcJ5zGF hjydkPwg+ywStSFUuAa07b4y503LCA==; Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Mar 2017 02:23:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,240,1486454400"; d="scan'208";a="82219803" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122]) ([10.237.220.122]) by fmsmga006.fm.intel.com with ESMTP; 29 Mar 2017 02:23:24 -0700 To: "Mody, Rasesh" , "dev@dpdk.org" References: <798af029-9a26-9065-350b-48781c1d3c55@intel.com> <1490683952-24919-32-git-send-email-rasesh.mody@cavium.com> <575911f6-467b-4153-1ac3-a452989a8ce5@intel.com> Cc: Thomas Monjalon From: Ferruh Yigit Message-ID: <12f2f80f-85b0-bd88-695b-82004c1ad9ba@intel.com> Date: Wed, 29 Mar 2017 10:23:23 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 31/62] net/qede/base: revise tunnel APIs/structs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Mar 2017 09:23:27 -0000 On 3/28/2017 10:18 PM, Mody, Rasesh wrote: >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit >> Sent: Tuesday, March 28, 2017 4:23 AM >> >> On 3/28/2017 7:52 AM, Rasesh Mody wrote: >>> Revise tunnel APIs/structs. >>> - Unite tunnel start and update params in single struct >>> "ecore_tunnel_info" >>> - Remove A0 chip tunnelling support. >>> - Added per tunnel info - removed bitmasks. >>> >>> Signed-off-by: Rasesh Mody >> >> I hate to say this, but this patch gives build error with clang [1], it seems it is >> fixed in next patch. > > We also observed this error on clang, however, the fix got wrongly applied to the next patch, sorry about that. > >> >> This patchset is big, and takes time to review / validate it, and a small error >> requires whole patchset done again. I am not suggesting updating this one, >> but for further patchsets, what do you think making multiple smaller >> patchsets? > > Please let us know if we need to refresh the current v4 patchset to address the clang issue. Yes, can you please send a new version of the patchset. > It's good suggestion, for further patchsets, we can do multiple smaller patchsets. > > Thanks! > -Rasesh > >> >> Thanks, >> ferruh >> >> >> [1] >> Building x86_64-native-linuxapp-clang ... >> .../drivers/net/qede/base/ecore_sp_commands.c:141:25: error: implicit >> conversion from enumeration type 'enum tunnel_clss' to different >> enumeration type 'enum ecore_tunn_clss' [-Werror,-Wenum-conversion] >> p_tun->vxlan.tun_cls = type; >> ~ ^~~~ >> .../drivers/net/qede/base/ecore_sp_commands.c:143:26: error: implicit >> conversion from enumeration type 'enum tunnel_clss' to different >> enumeration type 'enum ecore_tunn_clss' [-Werror,-Wenum-conversion] >> p_tun->l2_gre.tun_cls = type; >> ~ ^~~~ >> .../drivers/net/qede/base/ecore_sp_commands.c:145:26: error: implicit >> conversion from enumeration type 'enum tunnel_clss' to different >> enumeration type 'enum ecore_tunn_clss' [-Werror,-Wenum-conversion] >> p_tun->ip_gre.tun_cls = type; >> ~ ^~~~ >> .../drivers/net/qede/base/ecore_sp_commands.c:147:29: error: implicit >> conversion from enumeration type 'enum tunnel_clss' to different >> enumeration type 'enum ecore_tunn_clss' [-Werror,-Wenum-conversion] >> p_tun->l2_geneve.tun_cls = type; >> ~ ^~~~ >> .../drivers/net/qede/base/ecore_sp_commands.c:149:29: error: implicit >> conversion from enumeration type 'enum tunnel_clss' to different >> enumeration type 'enum ecore_tunn_clss' [-Werror,-Wenum-conversion] >> p_tun->ip_geneve.tun_cls = type; >> ~ ^~~~ >> 5 errors generated. >> make[10]: *** [base/ecore_sp_commands.o] Error 1 >> make[10]: *** Waiting for unfinished jobs.... >> .../drivers/net/qede/qede_ethdev.c:1724:45: error: variable 'p_tunn' is >> uninitialized when used here [-Werror,-Wuninitialized] >> rc = ecore_sp_pf_update_tunn_cfg(p_hwfn, p_tunn, >> ^~~~~~ >> .../drivers/net/qede/qede_ethdev.c:1711:34: note: initialize the variable >> 'p_tunn' to silence this warning >> struct ecore_tunnel_info *p_tunn; >> ^ >> = NULL >> .../drivers/net/qede/qede_ethdev.c:1877:5: error: variable 'p_tunn' is >> uninitialized when used here [-Werror,-Wuninitialized] >> p_tunn, ECORE_SPQ_MODE_CB, NULL); >> ^~~~~~ >> .../drivers/net/qede/qede_ethdev.c:1822:34: note: initialize the variable >> 'p_tunn' to silence this warning >> struct ecore_tunnel_info *p_tunn; >> ^ >> = NULL >> 2 errors generated. >