From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF3EB43B77; Thu, 22 Feb 2024 15:57:20 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A6FC7402CE; Thu, 22 Feb 2024 15:57:20 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by mails.dpdk.org (Postfix) with ESMTP id E88FC4027F for ; Thu, 22 Feb 2024 15:57:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708613839; x=1740149839; h=message-id:date:subject:to:references:from:in-reply-to: content-transfer-encoding:mime-version; bh=dgf7YkBo1l9JNkCAxh0ECXWx3DTfv3cb8qDMvd03MFw=; b=XvITW//4gX/zMXn3p/8kv+03Z08e407ZZNXgKgNSZiVjbYQod0uRYcxZ +vMhCR8CWIl06RPVbXQji/ezqCTGH2EdodNE1vY6isV9NVAHRINM5A+B9 Y0cnezVxVGXGqNMVajuyxmn2i0lO8cVRNHoCfuZxHyF7fN/tuUYVwLVLZ TZxmu+n7/utJMAuUFW1MCYW6aCt+HddqdvGo8rY3oNazAQhn/Tyh8tuYl NUBU48BPAeBy53xcPbIITSLGRb6HJoD6QOcKPekfT3ROEpANZd1jSY7PC PBZnVH4il4OiWcVOi1Iuh8QgD/sMGa/lwOeKbysiH/MKctXn99sr1p+fE g==; X-IronPort-AV: E=McAfee;i="6600,9927,10992"; a="25304570" X-IronPort-AV: E=Sophos;i="6.06,179,1705392000"; d="scan'208";a="25304570" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2024 06:57:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,179,1705392000"; d="scan'208";a="36349190" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 22 Feb 2024 06:57:17 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 22 Feb 2024 06:57:17 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 22 Feb 2024 06:57:16 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 22 Feb 2024 06:57:16 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 22 Feb 2024 06:57:16 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TQ2GG7y2MVPBGYzGwybg/6tpG2KUOyitcdEHwDjq4ehGtF76i0+Zb+CLmqIfLQfISya6PnRnYNk0VzuaLkeN5nJvi4UzLxu4FywLZySCXT91EIXyphPJPz6lbGvX7BH1nLrcN7yYK9ysON0D533ODaarxkEvBzOcF8nkPnzZ9zBqu8Gh9B5T3IuyB9zT3SjuCsAO0qrmLxyJReMP6ivkN8XbgQZ4C8UaJgmf3EF/XvSDJFNCvQl4BlptmZxPE5c9nG0PDTDf/h1PBOHOBlkXmUeWHyudsSkjHu7zghLDOkT/kYALXDFL9lM9yB7aXMPHRi+gn55uxSO9yp5+8/mNSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5/odeLbVzzpFxQ+HQ+JlqlCrlC9DqvTCQ4cr6uDJyQA=; b=V5TkRDHwvz+44NhzQ+AqL5LSdPPj30FW97QUCTtxfpWdsZkbIyzTSsfhkwHmVn43CvFgXuyUWfgJ/qn719mY2FL8XUnlfppnPMLiukGVmcTdZhG10qvFtHLYilt3vsFTcsan271i5O043fYQY15r3VXCyQycMWUC3Vbn/ktdNKmq5GNBp2vdKCkjhQsMOMzofOTUHy+WTMAk23Q/a+IVc0c9mOKxMpqGNQTy3OavGsZ/s5nExRW/51efUFFHCzN3qBHeEpYVLc1yTX2PwRKeZdqwyWa+GCUlEA4duXkQNeQTGcapntM7cG0ZT4LemX4rTWdNKF0qzXmwd06R556DKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH7PR11MB6498.namprd11.prod.outlook.com (2603:10b6:510:1f1::21) by CH3PR11MB7817.namprd11.prod.outlook.com (2603:10b6:610:123::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.10; Thu, 22 Feb 2024 14:57:14 +0000 Received: from PH7PR11MB6498.namprd11.prod.outlook.com ([fe80::60f:d984:1a35:2085]) by PH7PR11MB6498.namprd11.prod.outlook.com ([fe80::60f:d984:1a35:2085%4]) with mapi id 15.20.7292.029; Thu, 22 Feb 2024 14:57:14 +0000 Message-ID: <12f8a391-2a54-4b5d-a72c-17712d544c64@intel.com> Date: Thu, 22 Feb 2024 15:57:09 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/6] remove incorrect code for loading 16B descriptors To: Bruce Richardson , References: <20240123114053.172189-1-bruce.richardson@intel.com> Content-Language: en-US From: "Burakov, Anatoly" In-Reply-To: <20240123114053.172189-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB7PR05CA0062.eurprd05.prod.outlook.com (2603:10a6:10:2e::39) To PH7PR11MB6498.namprd11.prod.outlook.com (2603:10b6:510:1f1::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH7PR11MB6498:EE_|CH3PR11MB7817:EE_ X-MS-Office365-Filtering-Correlation-Id: 50388528-29d3-4bb2-7e94-08dc33b68e55 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /MCJZY/JSwN0GoFvATh7XLIn5EFo7O9RdISLBPFDkhfPWWwu7U0F3CnHcrq+xlFcqsMSNW951eOnqOjps2H5lsUdDjaOld3P/MnZctiB5OyIukDPDC9+V6p6TgiovwPHPwDT0mB2fkwYrFGzN32tPMn8L60dPOwvwuIenSbSWJFkH89fRhnqHVSnXRjugqyKh8Dqih7fkRoL5MSwm3RRympGH0tdKns21YG+XtY5Ffxf2pF3iWuEk21WTxKXjfGi5u0vIdTJ0QQ7USffL7a6qfvne6rCtBNGE9B5EQ5vWMdNAJyeAMRXsp95SfjxDA5rf8vIQsXSxBPL++taxZ+hds1wCRzTAqARpN0rLDehysXK4Vw8f6mvVj0BnwKPyoGbEyRGJmV1i+anEFRYHm+XF2ICr4WzardTwKmkxMrP6NAl7oEzKCrjKW3zyP4ConOf6sUnWQjC9qAt4L9UdpYBLu85sWmEKxcbHnxwDCVuRvalm/TEcU2BblkVBPfRkQkBcGkJtHsmoe/hrxWfvSwqsg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR11MB6498.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y1VZTlp3RHlVTzVOWkZFeWx2ZUIrNXBaTk1NZVNBMEVIZml5UHJrMnlUSHBQ?= =?utf-8?B?TXFIdnhKMnNDY04zUmt1am95b0VvR2d4R1NrZjNHNHZXbmZhTG8yOGJnaGlt?= =?utf-8?B?Qi9qYVkzeUZreUROUHhUc1hZQUNsVTY4YVY3d01OdFdNR1Y5dUI5ZkdPNks5?= =?utf-8?B?M0poQkdDYUZybWdvOE1HWUl1VlAvZFQvUGtEY0VJZ1FHVkxvZTIrbm1UQkU5?= =?utf-8?B?eFJjWENXc1haNXg2ZnVQVFVjT0YxNWJOYmJOYTFNS1RlOTU1N2pxd0xzQ25y?= =?utf-8?B?OUU2cEZpRDVRdk1teVBYVHJ4Rk9vQWhTQVYvbVU1NGx3T2c0cDZWWlNzNWlY?= =?utf-8?B?Sk01SWFYZEYvSnAwN1RhajBMbFRqOFdCUVBUUVI2MXVyV1JmMUxHNFBwNFRy?= =?utf-8?B?V2V4SGQxWWt0NFJpbDJQbjJMRlZ6N3pEU3NFZGJMaEMwV0g2N0o4TkwzSnNS?= =?utf-8?B?Z3ZjM2k4TGVURmM3d2xwZ0k5YmZ3TzhVVXQ2MS9ieGZhMzhYMUlZVk9mR1VH?= =?utf-8?B?R3Y1TWJ1cGdHNFRZNE8wRHp2M1pDM3pKZDVXWmdoa2pMZHlsNDU4bENLcFdz?= =?utf-8?B?RmdlK1lTbG5QcmxEUzdLVDBxREMwZnp4djMwWjZnd0hvV21jaEpUM0hCRzVl?= =?utf-8?B?RzRsZHVLbXk3dkk0RDNRY1dybzNuTXRWQ0tWMDE4bkFLRndPZ2o3TU1hMTdJ?= =?utf-8?B?dVl5dkFzd3ZpQWI4bnFWV3NKTTh1TVJRUmZXbGR6VnhLSGxRTlY4emZMUm14?= =?utf-8?B?UHBIbGdUdjRyY3kyQktpMVVBRnF0S3dOTXBlN1dEVDB5dlBhOGg5ZklSRnB6?= =?utf-8?B?MnVpcjlQWlFTVmR5Z1dUc3QyZGN0ZG5xWCtvNWRGeEpSaGpBMzg0TDVXT05G?= =?utf-8?B?S1lGZnRyc3l5ekdOaGtSU05KZ3hNZlZlbmcvTFBWQmoxNVcyTWRnZDJHOHZ5?= =?utf-8?B?L2NJdVhNS0EzL0RkSEQzM3BMV2NtV1QrOG9teTNUY2EyL3ZPbkVpT2RZK1Y3?= =?utf-8?B?eE83WGR5RDNFUDFwc0ZIL2pnQmd0bUNCUVp0UDhvV0gvdUh6aTFJRWRGUkFP?= =?utf-8?B?ZG9Od3hXWFRSdUNsUmVXeWFMdFk3NTdBVnlDR2NrVWQ3aG1ZM08veHo4Njc4?= =?utf-8?B?Q3A5S2VGMkdaRXNhQ1hqMUhrYWI1MmdRdXZ4NmF6eUVVbE9hZXNIUjZMU09U?= =?utf-8?B?T25IRHcrelliQjhBdGRneDNEeGQrV1VtaGhpaytYR2lxSG52MVpNNUdoMUNj?= =?utf-8?B?aXd0UkFIZlZubFIzWnhlTWkzTEtJbWV2VUxxSllmRjhwd0h2OVJCdEpSSDVj?= =?utf-8?B?dmt5YXMzRXU2cWxNT1FkeXBZeVEySTkwdEhWNVVmMDJROFpIdFBHQnl1SURJ?= =?utf-8?B?Q0VXWWc2b3A0N2VyLy9uNldkMlMzRVZsLytHWm1ER2g1d21nNk1YdTlLTDZl?= =?utf-8?B?dzFQUHlDNUJSZ1Nua1NjeC9WSEYyZ054SFJ0TTBNVk93cmswYnZQV0Uxbm1k?= =?utf-8?B?bGFZb0p2dGhrZ0ZmVTlTRWx2eGtYTk02ZTA2Tm15SmQxTDNRQmxWMEhMOHBN?= =?utf-8?B?SmVGVVhEUlFsWGdla3NxWTJicE9DaUk2U2NwdlUxdjkweE4zUTVhSEVPb0k3?= =?utf-8?B?S0Zqd3FGK3hWTFJoVlNzRTlaQ1VmWmFqQUZEZDhaNlF0VnhMYzJpNXFpRWNp?= =?utf-8?B?T0FwYmEwbWNNWGdzb1NSTE9VTmtLWllzWkJsaTR1L08yU0dEbUZad0Z0MW5R?= =?utf-8?B?VzIyZjY2VlRpZnJzeHJGZUlqZHlBR1NCR1BBYUlhVW00aFhwdHZkU3R3bytP?= =?utf-8?B?TXh6bC93RnZWRys0WnY4bEx3ZjlWV1pzbkNtZmFhZWtmeENia25KN1QrWHYx?= =?utf-8?B?UDJBakRxcmxodzh6WktGQnRBNXFrVU02V3g5d2pqSkxlS0xMNlEzakZiZWg4?= =?utf-8?B?cTZjbHUvWFBTT1BqanAwRElZRjlMQnBITXRpSkp4b0ZzQVMxcnVXckNIRGtG?= =?utf-8?B?ZmJOcW5GM0E0TEVaWXB0VGE5S0MxRkVsTFZnVWh0MnhEWjh0VitmdGl6cExD?= =?utf-8?B?U0NyclV6OWQzZWZnYU11OHBKMnhoZnNsSERvVEV5K3cxbTA3elgyQ2U0M1oz?= =?utf-8?B?dG9LTWI3QUpyVDlaM1JuOVpPbVg5anFKVGdKVjRpdWdwQXF2cFlkTzRMTzg0?= =?utf-8?B?T1E9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 50388528-29d3-4bb2-7e94-08dc33b68e55 X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB6498.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2024 14:57:14.7138 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: njFU0wmhVg+jXXBjVsfyJEWotUBquNkWepj+CRoWr00jK/zOKBe978FhywJeEf+JgpVGiZs/2NXKjLP6njopVAcV/4a+fX9lgE+AX2Xudig= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7817 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/23/2024 12:40 PM, Bruce Richardson wrote: > Inside the AVX2 code paths, there was special case code for loading two > 16-byte descriptors simultaneously, if that build-time feature was > enabled. As well as not being enabled by default, these code blocks also > were incorrect as there is no guarantee of the two descriptors being > loaded either atomically or in a defined order. If they were loaded in > an unexpected order the driver logic would break. Therefore we remove > these blocks, and do come cleanup of the following code to remove > indentation. > > NOTE: I've split out the removal and subsequent cleanup into separate > patches for ease of review. These can be merged into a single patch on > merge, if so desired. > > Bruce Richardson (6): > net/i40e: remove incorrect 16B descriptor read block > net/i40e: reduce code indentation > net/iavf: remove incorrect 16B descriptor read block > net/ice: remove incorrect 16B descriptor read block > net/ice: reduce code indent > net/iavf: reduce code indent > > drivers/net/i40e/i40e_rxtx_vec_avx2.c | 64 ++++++++------------- > drivers/net/iavf/iavf_rxtx_vec_avx2.c | 80 ++++++++------------------- > drivers/net/ice/ice_rxtx_vec_avx2.c | 80 ++++++++------------------- > 3 files changed, 72 insertions(+), 152 deletions(-) > > -- > 2.40.1 > Series-Acked-by: Anatoly Burakov -- Thanks, Anatoly