From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 79EB41BAF5 for ; Tue, 3 Jul 2018 23:57:26 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id D684721C24; Tue, 3 Jul 2018 17:57:25 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 03 Jul 2018 17:57:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=+VaM4lZdoH3uJEdmIwFvd7/hmz UWUajip0J4josTXj0=; b=snLSkri0f7yNdszGNitnBrGoCMgeua+u8EgHxw3A9f 3t2X8/Vf0jUe9sHwWgCshHeGhzh6r5lNRu2gwAH30ZBQRQfrDTlV9l1zr+ipLVfd AZSZQ8kif3x1aGcWDi/o0b7525uDHWLC8kftHDxp+MZrGLwJmTwBmKgde3bJC/GO w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=+VaM4l ZdoH3uJEdmIwFvd7/hmzUWUajip0J4josTXj0=; b=KWGCJuNOHg110WlQF2M0DK dIX5jIte9LptTts3H99GyueSaB7STudACma9cr7ymKsNNVqigluTGff7CMTFA9oO vBarLrwC8LfcOFrTNLmOtvoyIzJWRY51afkSwGjGBYbBiLEmlWX9wNjBKLVW7x0o hQsoNcAXP5rH0YeedU2RN1JiJP92NPe+UW6HnNl8pBC1a0U4yHo7u632t8XYWOBk DtQSj5+8U0kvjGeuOqGQwNdtyG3/CMRumolDjVSZAYZtM0uVG/O/6dIB7BYryB34 XtrnsfgPzmtqsrR0ZfLr5hAUyPYgigfyJkbHQ0p2aXTQXekEw5RBjfOewnUHteKw == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5A75B10261; Tue, 3 Jul 2018 17:57:24 -0400 (EDT) From: Thomas Monjalon To: "Zhang, Qi Z" Cc: dev@dpdk.org, "Burakov, Anatoly" , "Ananyev, Konstantin" , "Richardson, Bruce" , "Yigit, Ferruh" , "Shelton, Benjamin H" , "Vangati, Narender" Date: Tue, 03 Jul 2018 23:57:23 +0200 Message-ID: <13002513.5KdvWrtVWc@xps> In-Reply-To: <039ED4275CED7440929022BC67E7061153243554@SHSMSX103.ccr.corp.intel.com> References: <20180607123849.14439-1-qi.z.zhang@intel.com> <1673164.0Yk3bj6gtc@xps> <039ED4275CED7440929022BC67E7061153243554@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v8 03/19] ethdev: enable hotplug on multi-process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jul 2018 21:57:26 -0000 03/07/2018 17:03, Zhang, Qi Z: > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > 03/07/2018 14:59, Zhang, Qi Z: > > > > > +do_eth_dev_attach(const char *devargs, uint16_t *port_id); > > > > > > > > So you are duplicating rte_eth_dev_attach which is flawed in its > > > > design and should be deprecated... > > > > > > OK, just to know this, but I guess it will not be the issue, if we move the dev > > sync mechanism into eal layer in future right? > > > > Future is now :) > > We must stop mixing devargs and port id in the same layer. > > Ok, is there any RFC I can learn? RFC for what? It is just a design issue that we must stop propagating. > > > > As you may have noticed, rte_eth_dev_attach() is calling > > > > rte_eal_hotplug_add() which manages the EAL device. > > > > It is wrong because the relation between an ethdev port and an EAL > > > > device is not a 1:1 mapping. > > > > We must manage the ethdev port as one of the possible abstractions > > > > of a device represented by rte_device.