From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mhall@mhcomputing.net>
Received: from mail.mhcomputing.net (master.mhcomputing.net [74.208.46.186])
 by dpdk.org (Postfix) with ESMTP id 767657EA8
 for <dev@dpdk.org>; Tue, 14 Oct 2014 17:31:27 +0200 (CEST)
Received: from android-fb5fc4f6ed62fb42.attlocal.net
 (99-34-229-174.lightspeed.sntcca.sbcglobal.net [99.34.229.174])
 by mail.mhcomputing.net (Postfix) with ESMTPSA id E779080C3D9;
 Tue, 14 Oct 2014 08:38:20 -0700 (PDT)
User-Agent: K-9 Mail for Android
In-Reply-To: <20141014094415.GB8912@BRICHA3-MOBL>
References: <1413273236-1873-1-git-send-email-mhall@mhcomputing.net>
 <20141014094415.GB8912@BRICHA3-MOBL>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain;
 charset=UTF-8
From: Matthew Hall <mhall@mhcomputing.net>
Date: Tue, 14 Oct 2014 08:38:45 -0700
To: Bruce Richardson <bruce.richardson@intel.com>
Message-ID: <1300A4C9-3CCF-48A9-8C33-901D700BAEB4@mhcomputing.net>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] virtio-net-pmd: .gitignore: ignore
	librte_pmd_virtio.so
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Oct 2014 15:31:27 -0000

I import all my DPDK dependencies as git submodules. When the submodules contain unignored files, they get marked as dirty by git, and it makes like difficult when it comes to updating my submodule pointers.

Matthew.
-- 
Sent from my mobile device.

On October 14, 2014 2:44:16 AM PDT, Bruce Richardson <bruce.richardson@intel.com> wrote:
>On Tue, Oct 14, 2014 at 07:53:56AM +0000, Matthew Hall wrote:
>> Signed-off-by: Matthew Hall <mhall@mhcomputing.net>
>> ---
>>  .gitignore | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/.gitignore b/.gitignore
>> index e69de29..08d831a 100644
>> --- a/.gitignore
>> +++ b/.gitignore
>> @@ -0,0 +1 @@
>> +librte_pmd_virtio.so
>> -- 
>> 1.9.1
>> 
>
>I thought our .gitignore could do with a few entries added alright, I
>just 
>never expected this one to be top of the list! While I don't think it
>does 
>any harm, I'm just curious why you think it needs to be added?
>
>/Bruce