From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id AD0381396 for ; Wed, 24 Feb 2016 17:39:19 +0100 (CET) Received: by mail-wm0-f52.google.com with SMTP id g62so38170497wme.0 for ; Wed, 24 Feb 2016 08:39:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=lmnaIpQCX5yX3n3S2JX8GNJUWkZpAXYa7Mr07TT4xb8=; b=tN2OYPZKMRQ2eXlCKcNCPlvgqIYt3wybMjrdHE9mtugmuzN51JAZhBGORGCmYKMjen ui4seKcbK7VhAeqa/2FpzaPSlp6KUNyO95oExQZUxqq42QQeerhozMTQSxsU23q2QTYq qPdoJAt0217/eTAVOCsR6Xk5hXe1on2rFl99C+28SeWbgRs7zRQd4tfi57/XvxGF3ZBs 7bnUBgVGiVB4xUgX57IF4FQOfcFGVqn9lRlLvylpByfNYavemb3OH20+Li2UKpk+3pZJ edVwyXauQscr+CfkY/r47eChYUFeUVHAvE8W57A3rADj1x0vx+cjLJrLKU3P9SVPXqlP wEMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=lmnaIpQCX5yX3n3S2JX8GNJUWkZpAXYa7Mr07TT4xb8=; b=Gb/FZW1W4saY7eZKNcp0diEmM5/v625Ji23RndvhxblJ20Z0GNkGB8re/M0n+VHv2Y yJlOuqKqFrBuJgVHusJuChckdbZrToagEiEMsTN8UdD4seas86gU9RjNqluDvhoHivT5 C9Ci+kWNa0Nyu33KCtb+FifEmdQTC/a/TM3fBojdP11n2yrKdc73dHfWwr7iZY6W5zTs PRmlzmx8kf4jdmyuYlH9JISvhdwtxyIRUlRBatjkRzaD/CtwDrUj1YOlgkghOM43dhnZ isjznw+v9KKbgb3SDv4BnGj4wX/jEs8Mtr7iOnJcfnRKmM6j14v1Ed2y0fLD73vbcz+a Q5Bw== X-Gm-Message-State: AG10YOQqCWaRVf4LOTdlunw5HjtHxwZOMnVDPwGtLsocpeKM6uyJmOv81p51p+tMJa2dAS4h X-Received: by 10.28.158.8 with SMTP id h8mr25521928wme.6.1456331959545; Wed, 24 Feb 2016 08:39:19 -0800 (PST) Received: from xps13.localnet (171.36.101.84.rev.sfr.net. [84.101.36.171]) by smtp.gmail.com with ESMTPSA id ei9sm3790180wjd.40.2016.02.24.08.39.18 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 24 Feb 2016 08:39:18 -0800 (PST) From: Thomas Monjalon To: Bruce Richardson , Wang Xiao W Date: Wed, 24 Feb 2016 17:37:45 +0100 Message-ID: <13026611.uCVrZtfrBT@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160224154255.GA21808@bricha3-MOBL3> References: <1454410216-13333-2-git-send-email-xiao.w.wang@intel.com> <1454557129-12825-2-git-send-email-xiao.w.wang@intel.com> <20160224154255.GA21808@bricha3-MOBL3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 1/3] fm10k: enable FTAG based forwarding X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Feb 2016 16:39:19 -0000 2016-02-24 15:42, Bruce Richardson: > On Thu, Feb 04, 2016 at 11:38:47AM +0800, Wang Xiao W wrote: > > This patch enables reading sglort info into mbuf for RX and inserting > > an FTAG at the beginning of the packet for TX. The vlan_tci_outer field > > selected from rte_mbuf structure for sglort is not used in fm10k now. > > In FTAG based forwarding mode, the switch will forward packets according > > to glort info in FTAG rather than mac and vlan table. > > > > To activate this feature, user needs to turn ``CONFIG_RTE_LIBRTE_FM10K_FTAG_FWD`` > > to y in common_linuxapp or common_bsdapp. Currently this feature is supported > > only on PF, because FM10K_PFVTCTL register is read-only for VF. > > > > Signed-off-by: Wang Xiao W > > Any comments on this patch? > > My thoughts: is there a way in which this could be done without adding in a new > build time config option? Bruce, it's simpler to explain that build time options are forbidden to enable such options. Or the terrific kid's approach: one day, the Big Build-Option Eater will come and will eat every undecided features! ;)