From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A56FDA0C42; Fri, 9 Apr 2021 00:39:06 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1AF6A14117A; Fri, 9 Apr 2021 00:39:06 +0200 (CEST) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id BAFDC4068E for ; Fri, 9 Apr 2021 00:39:04 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 2CF18167D; Thu, 8 Apr 2021 18:39:03 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 08 Apr 2021 18:39:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= JJn7lMa1kKOBM2v9VgsZjGolnxloBQm5u899Em+z3ps=; b=bO5tDk3dONba5adq gAMBse+be/Het8T2rCtduQFBbESzRj2CSJ7WEL39Y2b8E2OfTr8bHXojZRi0NtLw qMZRGOv2c9mLnpS5zbJR9csTeMoNoOX5EbuF4tCBZZHCyDmQa/kBx389Q4pEhBXr xUr9azL/oB52yFCaTR4cCEl5z/0ZE57xPtxelW82m37SPHvPiGO25PAxcacd6V+I je8DVBoNiD93Q+HEbn8vr+Xkl2bGVnXoZcXGksRX7SuMDLQjTNd0+sKYbTwL32tF 3v+adNCE+JKnXm6X+hr2nJrsF/wSCSQ6k1nnaFVx3aM52hfok1mgfSgoRHn5bTNk nK6XlQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=JJn7lMa1kKOBM2v9VgsZjGolnxloBQm5u899Em+z3 ps=; b=c7WaW6pYPwk6WT+2vBSOCNvH6EsHJbqTWTG/JrE8iGSBP0o8NciEgnBe2 EXMXsXXH9A1RHavHyixYdAgKkOfRUNdFSCnyeMRHyek18daZM39RMUsHNuyyCWPr rWr0XhcHs6pd8ySZ9I9hDiBAYO9ZlEnt84O5J3rgSFkkoqPs9+VmFqR1enMgr4Ob Uk6SXHEgcSWItj7brZo6ysBYTEF48GyOrX6vOEPL/3OuQsxr9udWfF7hSKINC613 GSHqXFYcWSTCfSThz9DluykmA+4+yH4w459GwOa5qzZ64hrqnSRRpAND91W7VXq9 BbVLSzFC84rZJAr6WL16ooFi3wCBQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudektddguddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 96DD624005E; Thu, 8 Apr 2021 18:39:01 -0400 (EDT) From: Thomas Monjalon To: Gabriel Ganne Cc: Bruce Richardson , thierry.herbelot@6wind.com, dev@dpdk.org, olivier.matz@6wind.com, david.marchand@redhat.com Date: Fri, 09 Apr 2021 00:38:59 +0200 Message-ID: <13049033.jPmt81Ii10@thomas> In-Reply-To: <20210326082223.1398-1-gabriel.ganne@6wind.com> References: <20210326082223.1398-1-gabriel.ganne@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] meson: remove unnecessary explicit link to libpcap X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thank you, the fix looks good. I would like to improve the explanation. If I understand the issue, the title should be "build: remove redundant libpcap link" 26/03/2021 09:22, Gabriel Ganne: > libpcap is already found and registered as a dependency by meson, and > the dependency is already correctly used in librte_port. This line is > just unnecessary. To be precise, the pcap PMD and the librte_port both declare their dependency to libpcap with a line "ext_deps += pcap_dep" and meson automatically adds this dependency to the pkg-config file in the private section for static builds. That's why it is not needed to add the dependency explicitly in dpdk_extra_ldflags (involved in static build with pkg-config). > It also has the side effect of messing with the meson link line: dpdk Which "link line"? > link will be declared twice: manually and then through pkg-config. If What is "manually"? > you configure meson to prefer static linking over dynamic, this will No need to configure meson for that. Static linking can be tested with make in an example. Please avoid messing with meson explanation for application linking, it is already complicate enough :) > cause the build to fail on librte_port, since the pcap deps are not yet > seen by the linker. Sorry it is not clear to me. I think it would help to see a before/after effect on the link command. Something like: before: Libs.private: -lpcap Requires.private: libpcap after: Libs.private: Requires.private: libpcap [...] > - dpdk_extra_ldflags += '-lpcap'