From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7EF36A09FF; Wed, 6 Jan 2021 10:11:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2C36D160852; Wed, 6 Jan 2021 10:11:43 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id A421E1607E9 for ; Wed, 6 Jan 2021 10:11:41 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 02EAB5C017F; Wed, 6 Jan 2021 04:11:40 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 06 Jan 2021 04:11:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= 6ke1Bl5m/wxJi6V4UpqUelN7pwZxOo2VM6VB11gHBT8=; b=CkOTqXdh+zB878rw 6+SZbrL5eoUpIwsCc5yhU2EOg8h/0tkfClPN0Tj3S8h51TzrjwSXpyCgqwIUB8Ez Y5PhWfU2VWjxim1is8SMa7MCycESoux3w4vmRQWWGveG9aZw9JhJIcSfd8fLxMib VFjWSCvdmgFMNI1U/4Gsupa/QGripwoikkRDV42sqxzBiEdQEae5DFO1AHDBjIUr shKZoyNeXSWEn21FgjHIt8RjJAO5pWo9fNUqfRVayWqZxdCGbZJYYODYXfofJbpT cLChIGUkjI8ZEQM2wsA/pnxMjmQ4JIJenlbRGCTflXTYDRU46sE6wwpZ8WxKUw1C w0NeNA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=6ke1Bl5m/wxJi6V4UpqUelN7pwZxOo2VM6VB11gHB T8=; b=BOjsb5g7Kb0bhKIbcF87G+wXMwZtVNMO2N+GQUouOtQzeNcleW0DDxl9m IsFLcoKU02F3GLuwerR4afTWMwZ1ilSzb/4c2An8BQX0u+9jq9Sf0rwa9QyvMFH7 mtf9/O0LW9p9KON2jOojj49BqqJwk1Ch8DWarBqI556eLutRT1rracAD5seuZgS1 l58liSePuShati262N1TE7CgYp9YXt0igClR1OSUnQCPpEm9mEtuZ4Ehs2vrHhPa DSxYyfhW37sgD1mRgybIy0N0bc0irMSyhajY0YLwKFW4mGNWBAkJYCi/l2ZciUw7 rICg7FVY1g1p3ZLx4fcGDLqaFnoJQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrvdefledgtddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8D0AF24005E; Wed, 6 Jan 2021 04:11:38 -0500 (EST) From: Thomas Monjalon To: Maxime Coquelin , David Marchand Cc: Ray Kinsella , dev , "Xia, Chenbo" , Olivier Matz , Adrian Moreno Zapata Date: Wed, 06 Jan 2021 10:11:37 +0100 Message-ID: <13089839.ugh3R6DZUH@thomas> In-Reply-To: References: <20201220211405.313012-1-maxime.coquelin@redhat.com> <20201220211405.313012-9-maxime.coquelin@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 08/40] net/virtio: force IOVA as VA mode for Virtio-user X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 06/01/2021 10:06, David Marchand: > On Sun, Dec 20, 2020 at 10:14 PM Maxime Coquelin > wrote: > > diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c > > index 1f1f63a1a5..f4775ff141 100644 > > --- a/drivers/net/virtio/virtio_user_ethdev.c > > +++ b/drivers/net/virtio/virtio_user_ethdev.c > > @@ -663,6 +663,17 @@ virtio_user_pmd_probe(struct rte_vdev_device *vdev) > > char *mac_addr = NULL; > > int ret = -1; > > > > + /* > > + * ToDo 1: Implement detection mechanism at vdev bus level as PCI, but > > + * it implies API breakage. > > Extending rte_vdev_driver to implement this detection would be an ABI breakage. > This is a driver-only API (rte_vdev_driver is only used by the vdev > bus and drivers afaics). > > Doing this is allowed as per my understanding of the ABI policy which > guarantees ABI stability for applications. > We do not guarantee this stability for OOT drivers. I agree. As a reminder, the A in ABI stands for Application.